Commit Graph
1036 Commits
Author SHA1 Message Date
Kgothatso NgakoandClaude Opus 5.5 1ccd8c7f09 feat: a keyed room is born needing the group's signature; the switch is gone
The rule that a keyed room's changes need the group's signature was
switched on after founding, once every member's device had said it could
follow signed commits. That protected Bennu members and older Giza
builds from being left behind by the first signed change. Giza is in
development and keeps compatibility with neither, so the switch
protected nobody, and it kept an invited member from ever being made an
admin.

MarmotGroupCreation.createFor now writes GovernanceMarker's line, with
the floor the ceremony's quorum sets, into the room's epoch-0
description. Founding still needs no signature: the founding invite is
the creator's commit while it is the only member, which no other device
processes.

Removed: GovernanceSupport and its event (30372), the announcements on
joining, at start and in answer, the automatic switch and
requireSignatures, and the screen's waiting and ready states.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 09:28:47 +02:00
Kgothatso NgakoandClaude Opus 5.5 950ed24756 feat: a keyed room switches on the group's signature by itself
Requiring the group's signature for changes was a button an admin had
to find on the room's screen. Nothing about it was a decision: the two
conditions it waits on -- every member's device can follow, enough of
them are admins -- were already checked in code. The button is gone.

One device switches it on: the admin in the room's lowest leaf, which
in a room as made is its creator (GovernanceSupport.switcherOf). Not
every admin's, because two commits at one epoch are not settled for
their authors (docs/marmot-v2.md, Phase 8); every device reads the same
leaf, so they agree on one without talking. GovernanceFollowThrough
runs the switch whenever a member says it follows signed commits, and
on start.

Not at creation: a Bennu or older-Giza founder would be cut off without
anyone knowing, and a founding invite finished later is a bare commit a
governed room refuses. The room switches seconds after its founders
join instead. The screen names whose device it is waiting on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 09:16:22 +02:00
Kgothatso NgakoandClaude Opus 5.5 469c5632c7 Merge branch 'giza' into claude/remove-convenient-group-kinds-888dd3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 09:05:55 +02:00
Kgothatso NgakoandClaude Opus 5.5 6aae56520b fix: a member invited into a keyed room says it follows signed commits on joining
An invited member of a robust group could never be made an admin. Making
one needs the room to require the group's signature, which waits until
every member's device has said it follows signed commits. A device said
so when the room's screen was opened, or back when it heard another say
it -- but the founders said it before the invite, at an epoch the new
member cannot read, so it heard nothing, nobody said it again, and the
room waited on a screen the member had no reason to open.

A device now says it on joining (the Welcome path) and once each start
(GovernanceSupport.announceAll), for members who joined before this.
The waiting notice names who the room waits on and what for, instead of
"X need to update Giza".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 09:01:14 +02:00
Kgothatso NgakoandClaude Opus 5.5 f1493d8c3b Merge branch 'giza' into claude/member-admin-promotion-plan-d9d716
remove-convenient-groups' new test makes its phones with Phone(profile);
since the legacy KeyPackage slot was retired every phone publishes the one
package the app does, so it is Phone().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 08:46:40 +02:00
Kgothatso NgakoandClaude Opus 5.5 01da88ce97 feat: the legacy KeyPackage slot is retired (marmot-v2, Phase 9, the retirement)
MarmotProfile.PUBLISHED is the current profile alone. The repository
publishes only the current-profile package and refuses to be asked for a
legacy one; KeyPackageEvent.build and the legacy leaf builder have no caller
and are gone. The notary republishes only what PUBLISHED names, so a legacy
bundle still active is left to be consumed and not replaced.

A legacy room still invites: the current-profile leaf advertises 0xF2EE.
RobustGroupAdminsJvmTest's legacy-room cases now join from the one package
the app publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 08:43:02 +02:00
Kgothatso NgakoandClaude Opus 5.5 b17a2b1ac5 feat: new rooms are made on the Marmot current profile (marmot-v2, Phase 9, the flip)
MarmotProfile.DEFAULT_FOR_NEW_ROOMS goes from LEGACY to CURRENT, so every
creation site -- direct messages, convenient rooms, keyed rooms -- makes a
current-profile group, and the pickers ask peers for current-profile
KeyPackages. Rooms made before stay legacy for good.

Two creation tests read the legacy 0xF2EE extension directly; they now read
the room id, name and admins through the accessors that work on both
profiles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 08:35:21 +02:00
Kgothatso NgakoandClaude Opus 5.5 aa4c8eba05 Merge branch 'giza' into claude/remove-convenient-group-kinds-888dd3
Two files this branch deleted were changed on giza:

- SelectChatRoomTypeViewModel: giza added a reconcileAdmins call to the
  convenient path, which this branch removed. The robust path
  (MarmotGroupCreation) and direct messages (MarmotOutboundDao) already
  reconcile, so the deletion stands.
- ChatRoomType: giza added minimumAdmins(threshold) for the admin floor.
  It moves to Quorum.minimumAdmins beside the other quorum rules (D6);
  AdminGovernance and AdminChangesJvmTest call it there.

docs/member-admin-promotion.md now notes where the names it cites went.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 08:24:09 +02:00
Kgothatso NgakoandClaude Opus 5.5 638d1d291a feat: a member is made an admin of a keyed room, and enrolled into its key (member-admin-promotion, Phase 8)
Under the experimental FROST enrollment. In a governed keyed room past its
ceremony's generation, Make admin is an offer (30374); the member accepts
(30375), naming the ChillDKG host key their shares will be sealed to,
which is the one decision only they can make. The offering device then
proposes one batch for the group to sign: the change making them an admin,
and the key state binding the next participant id to them, with that id's
public share -- interpolated from the table every device already holds --
added to the table it hashes.

Every device adds the id when it files that key state, and only if the
extended table hashes to what the group signed. Once the change lands the
offering device hands over (30376) the table, roster and signed key state;
the new member's device checks them against the room's own signature,
files its record of the key, and asks to be enrolled. t holders run
reduced FROST enrollment at newId = n through the repair protocol, with no
approval of their own -- the signed binding was it -- and the new share is
checked against the signed table.

A signing session's n is now the generation's table size, which an
enrollment grows; the repair session carries the n an enrollment runs
with (schema v42, still unshipped). GovernanceFollowThrough drives the
offerer's and the new member's steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:52:20 +02:00
Kgothatso NgakoandClaude Opus 5.5 51eda2d211 feat: a keyed room demotes an admin with the group's signature, then rotates them out (member-admin-promotion, Phase 9)
In a governed keyed room, with share rotation on, an admin can propose
removing another as admin -- never themselves, since the rotation that
has to follow is the remaining holders'. The demotion is a signed change
like any other, and the floor holds. A removal of a member who holds a
live share is the same.

Either one remembers who to rotate out (GovernanceProposal.thenRotateWithout,
schema v42), is marked applied when a relay accepts it, and
GovernanceFollowThrough -- a driver beside the ceremony follow-through,
with the key pair -- then proposes the rotation without them. A change
that landed while the app was closed is caught from the group's state; a
rotation that cannot start is said in the room, and offered from the
Shares section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:40:21 +02:00
Kgothatso NgakoandClaude Opus 5.5 b15b51c123 Merge branch 'giza' into claude/member-admin-promotion-plan-d9d716
robust-group-admins built the same thing as this branch's Phase 1: a single
writer for Participant.adminAt, run at creation, on the Welcome, on every
commit and once at start. Its AdminFlags is kept as that writer; this
branch's MarmotInboundManager.reconcileAdmins and adminFlagChanges are
gone, and the direct-message and convenient-room creation sites and the
detail screen's catch-up call AdminFlags instead. The admin captions stay,
on top of it.

Both sides added to the room's details: the founding-admin repair and
invite beside the member menu, admin labels and governance section. The
member row keeps one label line -- Admin from adminAt, Holds a share
beside it -- and the removal message now has three cases: proposed for the
group's signature, rotation held, or sent. The rotation offer waits for
both: a rotation available, and the removal not still awaiting signatures.

addAdmins, the founding-admin repair, proposes its commit for the group's
signature in a governed room instead of committing it bare.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:29:23 +02:00
Kgothatso NgakoandClaude Opus 5.5 41409434a7 feat: a group run by one person says so, and is still joined (remove-convenient-groups, Phase 5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:19:59 +02:00
Kgothatso NgakoandClaude Opus 5.5 7de80452a1 fix: the statement's KDoc names the retired wallet range by its constant
The wallet audit fails on a retired kind's number anywhere in the app's
code, comments included; Phase 3 spelled the range out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:17:48 +02:00
Kgothatso NgakoandClaude Opus 5.5 76fbca3ecc feat: a governed room's ordinary changes go through the group's signature (member-admin-promotion, Phase 5b)
In a governed room, removing a member, inviting one and disbanding are
proposed and signed by the group instead of committed by one admin. A
removal is now one commit -- the Remove and, for an admin, their entry off
the admin list -- since a copy of the group can stage both where the
manager could not. Disbanding a room that has not yet agreed it can be
disbanded proposes that agreement first.

An admin's device folding in a member's leave sends it inside its own
envelope (30371), not bare. The commit builders live on GovernanceManager
so the DAO and the tests use the same ones.

Fixes a gate bug the inbound removal test found: a Remove's account is
now read off the group as it stood before the commit, because the copy's
view can already have the removed leaf blank.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:17:37 +02:00
Kgothatso NgakoandClaude Opus 5.5 03704db3fb refactor: ChatRoomType goes, and the screen is named for the quorum (remove-convenient-groups, Phase 4)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:17:14 +02:00
Kgothatso NgakoandClaude Opus 5.5 7fc1233bbc feat: the member picker holds the three-person floor (remove-convenient-groups, Phase 3)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:14:37 +02:00
Kgothatso NgakoandClaude Opus 5.5 c2010abe44 feat: a room with no key behind it takes no new members (remove-convenient-groups, Phase 2b)
A one-to-one chat, or a group its creator runs alone, grown by one more
person would be a group run by one person. The invite screen refuses such
a room and the detail screen no longer offers the invite there. The plan
gains D7, since D1 had assumed no such invite path existed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:12:07 +02:00
Kgothatso NgakoandClaude Opus 5.5 59509e425d feat: a change to a governed room is proposed, signed by the group, then published (member-admin-promotion, Phase 5)
GovernanceManager.propose builds the commit on a copy of the group whose
policy records its proposals -- so the statement is read off the very
commit -- builds the kind:445 that carries it without publishing it, and
opens a signing session over the statement whose content is that kind:445.
A GovernanceProposal (schema v41) keeps the states either side, because
this device cannot process its own commit and signing outlasts a session.

Every member's device runs the same checks as the door before its owner is
asked, and declines a statement whose commit does not say what its tags
say. When the session completes on the proposer's device, it sends the
signed statement in a carrier and raises the publish gate with the kept
state; the relay's OK on the carrier installs it. A proposal the group
moved past is marked stale and said so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:09:02 +02:00
Kgothatso NgakoandClaude Opus 5.5 eb2c8aa090 feat: every group a member creates is robust (remove-convenient-groups, Phase 2)
The group-creation screen no longer offers a group its creator runs alone.
It asks only how many of the members have to agree, then opens the NIP-17
room and its key ceremony. The single-admin Marmot path, its invite round
and its 'couldn't be added' card are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:08:46 +02:00
Kgothatso NgakoandClaude Opus 5.5 0a4453da81 refactor: Quorum takes the threshold rules from ChatRoomType (remove-convenient-groups, Phase 1)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:05:08 +02:00
Kgothatso NgakoandClaude Opus 5.5 b9396643a9 test: pin every new group as robust, ignored until it is (remove-convenient-groups, Phase 0)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 02:02:01 +02:00
Kgothatso NgakoandClaude Opus 5.5 dd00d0f701 feat: a keyed room's changes can be made to need the group's signature (member-admin-promotion, Phase 4b)
Each device says once per keyed room, as GovernanceSupportEvent (30372),
that it follows signed commits, and says it back whenever it hears another
member say it, so a member who never opens the room is still counted.

An admin's Require the group's signature for changes is one bare commit
adding GovernanceMarker's line, with the floor the room's quorum sets, to
the profile description: the room's last bare commit. It is refused while
any member has not said it -- they would be left in a different group by
the first change -- and while the room has fewer admins than the floor.
The room's screen says which, or that the rule is on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:59:00 +02:00
Kgothatso NgakoandClaude Opus 5.5 1deff002d3 feat: a governed room applies a commit only from inside the group's signature (member-admin-promotion, Phase 4a)
A keyed room whose profile description carries GovernanceMarker's line --
changes need the group's signature, and at least N admins -- is governed,
and every device reads that from the same epoch's state.

GovernanceGate is the door. At the one inbound call into the engine, a
commit sent bare into a governed room is dropped before the engine sees
it: the outer layer is peeled with the current and retained epochs' keys
and the MLS content type read from the header. A commit arrives instead
inside an envelope whose content is the proposer's own kind:445, so every
device applies the same event with the same id:

- a statement (30370), signed by the room and sent in a member's carrier
  (30373), since an application message has to be its sender's;
- an own commit (30371) for D6's exemptions, sent by its committer.

The commit is run on a throwaway copy of the group under a policy that
records its proposals and committer -- no library change -- and admitted
only at the current epoch, matching its statement exactly, and leaving the
marker's floor of admins. A refusal says so in the room.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:53:44 +02:00
Kgothatso NgakoandClaude Opus 5.5 e78dfe50cf Merge branch 'giza' into claude/rotate-shares-single-approval-338a7d
giza brought rotation-waits-for-key-state, built in parallel from the
same base, and robust-group-admins. The first overlaps this branch, and
the two agreed on not asking the proposer. Where they met:

- The proposer's dialog is this branch's, read from the proposal's own
  plan with its refusal, under giza's title and caveat; giza's dialog,
  which listed stale members from the summary, went. The preview's
  refusal carries rotationHold's reason, and ChatRoomDetailSharesJvmTest
  asks its question of the kept dialog.
- The proposer is approved to take part only; giza also set
  confirmApprovedAt, which nothing reads.
- The Shares section keeps both: giza's held button, its reason and
  'Ask the group to sign', and this branch's running card and abandon.
- giza's hold tests left the new key state unsigned by not signing it.
  It signs itself now, so they hold the signing messages after the
  proposal (signingHeldOpen). This branch's test of two rotations opened
  at once gave way to giza's, which asserts more.

jvmTest 1281/1281, compileDebugKotlinAndroid, m3Audit at its budgets,
brand and wallet audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:43:23 +02:00
Kgothatso NgakoandClaude Opus 5.5 d5fbc56899 feat: the statement a keyed room's quorum signs before it changes (member-admin-promotion, Phase 3)
GovernanceStatementEvent, kind 30370 (past the retired wallet kinds): one
epoch, and exactly what the commit made at it does -- who it adds, by the
KeyPackage that adds them; who it removes, by account; the whole admin
list after; and every other component it changes, by id and the hash of
its new value. Signed by the room, whose id is the key that must have
signed, so isSignedByRoom checks it with nothing looked up.

GovernanceChange.of reads a commit's proposals into those terms, refusing
anything a statement cannot describe; authorises holds a commit to its
statement, nothing more and nothing less; isExempt is D6's exemption, a
member's own leave and a committer's own key update. The signing approval
reads it in names. Pure: nothing enforces it until Phases 0 and 4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:34:23 +02:00
Kgothatso NgakoandClaude Opus 5.5 6e601a9e37 Merge branch 'claude/group-initial-members-admins-2243d3' into giza
Every founding member of a robust group is its admin, phases 0-7
(docs/robust-group-admins.md). Two conflicts, both adjacent additions:
the detail screen's strings read outside the click handlers, and the
view model's companion constants. Both sides kept. jvmTest 1261/1261,
compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:30:29 +02:00
Kgothatso NgakoandClaude Opus 5.5 6e3ed2bb38 feat: a robust group keeps at least three admins, and never fewer than its quorum (member-admin-promotion, Phase 7, app side)
ChatRoomType.minimumAdmins(t) is max(3, t): in a keyed room the admins are
the share holders, so fewer than t of them is a key that can never sign
again. AdminGovernance.adminFloor reads t off the room's completed
ceremony (the size floor alone where this device holds none), removeMember
refuses a removal that would cross it, and the member row stops offering
one. A convenient room's floor stays the library's depletion guard.

The policy half -- every receiving device refusing such a commit -- waits
on Phase 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:28:07 +02:00
Kgothatso NgakoandClaude Opus 5.5 ef33349e7f feat: the member row's menu, and leaving as an admin (member-admin-promotion, Phases 10 and 11, convenient rooms)
Each member row says Admin and Holds a share as two labels, read off the
group's state and the Shares roster; when they disagree a share is owed
or still to be rotated away. An admin's row has an overflow menu whose
items AdminGovernance.memberActions decides: make admin, remove as admin,
step down on your own row, remove from group. Promotion and demotion ask
first, and promotion says what it gives away.

Leave group, pressed by an admin, opens a dialog instead of a refusal:
step down and leave when another admin remains, or, for the only admin,
pick who takes over (or disband instead). stepDownAndLeave chains the
commits through MarmotEngine.afterConfirmed, which is now registered
before the commit it waits on and taken back if publishing throws.

Keyed rooms keep removal only; their admins wait on the group's signature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:26:15 +02:00
Kgothatso NgakoandClaude Opus 5.5 01e33f5a6f fix: rooms joined before the Welcome wrote flags are caught up at start (robust-group-admins, Phase 6)
AdminFlags.reconcileAll runs AdminFlags.reconcile over every room this
device holds MLS state for, and the sync start calls it once, through
ChatRepository.reconcileAdminFlags, beside the ceremony resume. A room
joined before Phase 2 flags nobody on the joiner's device until some
commit arrives, and a robust group's admin room may never get one.

No stored "done" flag: a room whose rows already agree is a read and no
write, so a second start costs one decode per room. A room that will not
decode is logged and passed over.

RobustGroupAdminsJvmTest: a joiner's cleared flags are restored on both
profiles, and a second pass changes nothing. jvmTest 1250/1250,
compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:21:12 +02:00
Kgothatso NgakoandClaude Opus 5.5 d95412ffda feat: an admin makes a member an admin, or not, in a convenient room (member-admin-promotion, Phase 6)
MarmotOutboundDao.promote and demote commit the room's admin list through
the publish gate, built from the list the group holds when the commit is
staged. AdminGovernance holds the rules once: the library's permissions,
plus that a promoted account holds a leaf, and that a keyed room's admins
are changed by none of this -- they need the group's signature and a
share of its key, which are not built.

Removing an admin now takes them off the admin list first and removes
them when that commit is confirmed, chained by MarmotEngine.afterConfirmed.
A bare Remove left their key on the list, so inviting them back made them
an admin again with nobody having said so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:19:34 +02:00
Kgothatso NgakoandClaude Opus 5.5 baf63b8d7a feat: the room's details say who administers it, and whether the founders do (robust-group-admins, Phase 5)
The member list labels admins, from the flags AdminFlags keeps. Two
cards on the error container, under the signing key and the parent:
founding members the room's policy does not list as admins, with "Make
them admins" for an admin of a current-profile room; and founding
members the founding invite never reached, with "Invite them" on the
device that holds the room at epoch 0. Founders are named through their
profiles, since an uninvited one is not in the room to read a row off.

A robust group's NIP-17 room has no admins of its own, so its details
link to the admin room its ceremony made (ChatRepository.adminRoomOf),
saying every member is an admin there.

Strings in the catalogue, sentence case; colours from the error
container roles; spacing from the scale; the actions guard a second tap.
m3Audit: all budgets met. jvmTest 1249/1249, compileDebugKotlinAndroid.
Not looked at in a running app.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:18:00 +02:00
Kgothatso NgakoandClaude Opus 5.5 1dc94ad423 feat: a founding invite that never went out is finished (robust-group-admins, Phase 4)
MarmotGroupCreation.finishFoundingInvite invites the founders a room's
founding invite never reached, in one commit, every key package first as
at creation. It acts only on a room still at epoch 0: the founding
invite is the commit that ends epoch 0, and leaving is a commit too, so
a founder without a leaf there is one nobody ever invited -- never one
who left. CeremonyFollowThrough takes it as step 4 once the room exists,
on the coordinator's device; the repository exposes it by room for the
detail screen, with the set it would invite.

Also fixes what Phase 0 found. MarmotGroupCreation invited the founders
through a room read before its routing id was recorded, so on the
current profile the engine adopted a second copy of the group under the
room id, and the copy at the real address still held only its creator:
every later invite took the founding path, with no commit and nobody
already in the room told. It now reads the room again first.

RobustGroupAdminsJvmTest: a room left without its invite is finished and
every founder joins as an admin, on both profiles; a room past its
founding invites nobody; a later member on the current profile now gets
a real commit. CeremonyFollowThroughJvmTest: step 4's outcomes.
jvmTest 1249/1249, compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:14:19 +02:00
Kgothatso NgakoandClaude Opus 5.5 19f0fc0f1e feat: the room says who became an admin, and who stopped (member-admin-promotion, Phase 2)
TYPE_ADMIN_ADDED and TYPE_ADMIN_REMOVED, derived like the membership
lines: processGroupMembershipChanges compares the group's admin set before
the commit with the one after, on every device that applies it. The prior
set comes from the group's state -- captured before the engine moves the
group on the inbound paths, and from the obligation's prior state on a
confirmed own commit -- never from the adminAt flags. An account that
left the tree gets its departure line and no admin line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:13:37 +02:00
Kgothatso NgakoandClaude Opus 5.5 11f2cb2bab feat: the Shares section, with one approval (rotate-shares-single-approval, Phase 6)
Removing the second approval took away the only abandon button a member
who had taken part could reach: it lived on the approval row. A running
rotation is now a card above the members -- the step it is on (dealing,
storing, the group signing the new key state), who it waits on and since
when, and Abandon, behind a confirmation, for any member taking part.
It counts as running until the new generation's key state is signed,
while that signature is open, because the old shares wait on it. A
rotation that ended without completing says why until the next one.

The taking-part row now says what it decides: who is left out and as
what, and that nothing more will be asked. REFRESH_CONFIRM and its
string are gone from the UI state.

ShareRefreshManager.progress reads the step and who is missing from
stored messages. Those are now stored once, on first arrival, in record
and publishOwn: a redelivery rewrote the row and reset the stall clock.

Tests: the row names the withheld; the withheld member sees the rotation
run and cannot abandon it; the waiting-on names at dealing and storing;
the signing step, which nobody abandons; an abandoned rotation says why.
The stall-clock test backdates the messages first, and fails with the
old store-every-time behaviour put back. jvmTest 1250/1250; m3Audit at
its budgets; brand and wallet audits.

Not seen on a device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:12:23 +02:00
Kgothatso NgakoandClaude Opus 5.5 4671a86a6d feat: a device checks its admin room against the ceremony it took part in (robust-group-admins, Phase 3)
FoundingAdmins.check compares a key-backed room's admin policy with the
participants of the ceremony that made its key, as this device's own
DkgSession row has them -- and, for a subgroup, with the admins its
parent's birth certificate names. NotKeyBacked, CannotCheck (a later
joiner, who holds no ceremony), Matches, or Missing with who.

At the Welcome, after the key state is adopted, a room missing founders
gets one transcript line naming them (TYPE_FOUNDING_ADMINS_MISSING, a
membership line). The detail screen reads the check on every load into
ChatRoomDetailUIState.missingFoundingAdmins.

The repair is MarmotOutboundDao.addAdmins: one gated commit on the
current profile that writes the policy the group holds now plus the
missing founders -- additions only, never a list built elsewhere. The
legacy profile has no governance commits in this app, so a legacy room
gets the warning without the repair.

FoundingAdminsJvmTest: each Check, the pre-column fallback, the line
written once and only when someone is missing, and the repair on the
current profile through a relay's OK. jvmTest 1245/1245,
compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:10:01 +02:00
Kgothatso NgakoandClaude Opus 5.5 53acae68a4 feat: a member's admin flag is true from the room's first moment (member-admin-promotion, Phase 1)
Participant.adminAt was written only when a commit arrived, so on the
device that created a convenient room or a direct message nobody was an
admin until somebody else committed. MarmotInboundManager.reconcileAdmins
brings the flags into line with the group's admin set without a caption.
It runs where every Marmot room is made -- replacing stampAdmins, which
only the keyed rooms had -- and when a room's detail screen opens, which
catches up rooms made before this build.

processGroupMembershipChanges shares the same flag rule, adminFlagChanges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:09:56 +02:00
Kgothatso NgakoandClaude Opus 5.5 2ed83c55ab fix: an admin's refused leave is shown, not thrown out of the view model (member-admin-promotion, Phase 10a)
leaveGroup called the repository inside viewModelScope.launch and caught
nothing, so "An admin cannot leave; hand over admin first" escaped the
coroutine: never shown, and on Android a crash. It now goes to an onFailed
callback the screen reports through the notifier, as disbandGroup does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:07:57 +02:00
Kgothatso NgakoandClaude Opus 5.5 46eb23b777 feat: a rotation's key state signs itself (rotate-shares-single-approval, Phase 5)
GroupKeyStateManager.vouchesFor refused every key state naming a share
generation (fc437d05), so each recipient was asked to sign the new
generation before anyone's old share was deleted. vouchesForGeneration
now accepts the one state a rotation this device completed implies: the
generation it signs with and holds a share of, the rotation named and
complete here, its own table's hash, the ids its roster retires, a
session at that generation, and the path and parent of the room's
signed state. Rule 7 becomes 'nothing signed at h or later'. A state
that binds an id to a new identity is still never vouched for.

Vouching was decided once, on the proposal's arrival, and the
coordinator proposes the moment its own certificate verifies -- often
before a recipient's. resumeAt, which the rotation already calls on
activation, now asks again; resumeVouched does the same from the sync
sweep for a state an older build left asking.

Tests: one approval each and the group signs generation 1 and wipes the
old shares; a state heard before the certificate is vouched for once it
arrives; each rule broken on its own leaves the state asked; a withheld
member does not vouch; the sweep answers a state left asking, once. The
cutover test holds the proposal to keep checking that nothing is wiped
before the signature. jvmTest 1245/1245.

One earlier full run died on a SIGSEGV in SQLite's native code, in a
background key-package write unrelated to this change; the rerun was
clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:06:39 +02:00
Kgothatso NgakoandClaude Opus 5.5 83711419ef fix: a member welcomed into a room sees its admins at once (robust-group-admins, Phase 2)
Participant.adminAt had three writers and the Welcome was not one of
them: a joiner's rows came from Participant.fromMlsGroup with no flag, so
on every device but the creator's a robust group's admin room showed no
admins until some later commit happened to arrive.

AdminFlags.reconcile is now the one writer. It reads the room's rows
fresh and flags them from the group's own admin policy, both ways, and
writes nothing about membership. The Welcome path calls it after the
participant upsert; MarmotGroupCreation calls it in place of
stampAdmins, off the group it just made rather than its own list; and
processGroupMembershipChanges calls it in place of its three inline
computations.

Phase 0's ignored test passes. MarmotGroupCreationJvmTest: flags follow
the policy both ways, and a second pass changes nothing.
jvmTest 1237/1237, compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:05:42 +02:00
Kgothatso NgakoandClaude Opus 5.5 d7fb71036f feat: a robust group's admin room takes its admins from the ceremony (robust-group-admins, Phase 1)
ChatRepository.createMarmotGroup now takes the ceremony and the room it
ran in instead of a list of admins, and MarmotGroupCreation.createFor
derives the room's id, name, description and admins from it. The two
callers -- CeremonyFollowThrough's step 3 and the ritual screen's button
-- stop computing a set of their own. A room's epoch-0 admin list is
fixed for good at an address the key derives, so the one place the
founding set is read is now the one place a room is made.

A device that was not in the ceremony is refused rather than listed as
the room's creator.

MarmotGroupCreationJvmTest: the coordinator's device and a member's make
a room with the same admins, the ceremony's participants; an outsider
makes none. jvmTest 1236/1236 (1 skipped, Phase 2's),
compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:02:08 +02:00
Kgothatso NgakoandClaude Opus 5.5 69871c68a5 feat: proposing a rotation is the proposer's approval (rotate-shares-single-approval, Phase 4)
The proposer was asked like anyone because the button committed them to
a withheld list they were never shown. Now Rotate shares opens a dialog
naming who takes part and who is left out -- the stale members proposing
withholds again automatically included -- and why it would be refused,
before anything is sent. Pressing it is the proposer's agreement: the
session is created with dealApprovedAt set, and the proposer deals at
once.

ShareRefreshManager.plan is the one recipient/withheld split behind both
proposeRefresh and the new preview, so the dialog shows what the
proposal will say. The removal dialog names the stale members too.

Tests: the proposer's half of 'nothing goes out before they approve'
flips; the preview equals the proposal with nobody stale and with one;
a removal's preview names the removed for good and the stale until they
are back; a refused preview says why and sends nothing. jvmTest
1241/1241, m3Audit, brand and wallet audits.

Not seen on a device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 01:00:56 +02:00
Kgothatso NgakoandClaude Opus 5.5 3efa1af554 test: every founding member of a robust group is its admin (robust-group-admins, Phase 0)
RobustGroupAdminsJvmTest states the promise and shows where it breaks.
Three app phones: one creates the admin room through MarmotGroupCreation
with all three as admins, the others join by a real Welcome, gift wrapped
and stored through the sync funnel.

On every device the admin policy names the founders and isLocalAdmin is
true, on both profiles. The rows do not: a joiner's Welcome writes no
adminAt, so its own rows flag nobody -- ignored until Phase 2. A member
invited later is not an admin. The ceremony half checks that every device
that took part agrees on the founding set, for a group and a subgroup.

The later-member case runs on the legacy profile only: on the current
profile MarmotGroupCreation invites the founders through a room read
before its routing id is recorded, so a later invite skips its commit.
Phase 4 fixes that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:57:18 +02:00
Kgothatso NgakoandClaude Opus 5.5 959c120d52 feat: running rotations resume without a message (rotate-shares-single-approval, Phase 3)
ShareRefreshManager.resumeRunning advances every rotation this user is in
that has not finished, through a new ShareRefreshDao.getRunningSessionsFor.
resumeRunningCeremonies runs it after the ceremony sweep, under the same
lock as the inbound path, once the live subscription is open. Behind the
rotation flag.

Without it, Phase 2 strands a rotation an older build paused at 'store
your new share': the sum is on file and nothing more will arrive.

Tests: that upgrade case resumes from the sweep alone and completes, and
two more sweeps send nothing; a member who has not taken part is looked
at and sends nothing, asked once; a build without rotation resumes
nothing. ShareRefreshRitualJvmTest 26/26.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:55:34 +02:00
Kgothatso NgakoandClaude Opus 5.5 b4103bcb40 feat: taking part is a rotation's only approval (rotate-shares-single-approval, Phase 2)
ShareRefreshManager.advance no longer stops before round 2 for its owner.
The gate's two reasons never needed a person: participantStep2 is the
check that stops a substituted table, and it fails the rotation out loud
before any prompt could appear; ShareRefreshConfirmation is the one
confirmation per generation, claimed with the pending share in one
transaction. pendingApproval now only answers DEAL.

No migration: confirmApprovedAt and ShareRefreshApprovalStep.CONFIRM stay
so rows written before still decode, documented as read by nothing.

Tests: the pinned gate flips (taking part alone completes the rotation,
asked once); the last to take part deals and confirms with nothing more
asked; a tampered sum fails the rotation on every device with nobody
asked; two rotations opened at once never split the group.
ShareRefreshRitualJvmTest 23/23.

Must ship with Phase 3: a rotation paused at the old second approval has
nothing left to arrive and needs the sweep to move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:53:49 +02:00
Kgothatso NgakoandClaude Opus 5.5 18f426ca46 test: a rotation's approvals, counted as they are today (rotate-shares-single-approval, Phase 1)
Three tests pin where a rotation stops for its owners, so the phases that
remove those stops flip an assertion rather than pass by accident:
taking part alone leaves every recipient asked to store the new share;
a recipient is asked to take part, to store, and to sign the new key
state (the proposer the first two); and a completed rotation keeps the
old shares until the owners sign. answerEverything records each ask.

ShareRefreshRitualJvmTest 20/20.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:51:54 +02:00
Kgothatso NgakoandClaude Opus 5.5 951312489c feat: the proposer is not asked about their own rotation (Phase 4)
Tapping Rotate shares put "Take part in rotating the shares" in front of
the person who had just tapped it, and "Store your new share" after.
The button now asks first, in a dialog naming every member the rotation
leaves out -- the stale, withheld again -- and proposeRefresh approves
the proposer at both gates. DEAL is the decision about who is withheld,
which the dialog just took; CONFIRM guards against a coordinator
substituting a table, and the proposer is the coordinator. Every other
recipient is asked as before.

A test now shows two proposals crossing on the wire end with neither
running and every device on one table.

ShareRefreshRitualJvmTest 25/25, ChatRoomDetailSharesJvmTest 3/3,
m3Audit, compileDebugKotlinAndroid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:49:04 +02:00
Kgothatso NgakoandClaude Opus 5.5 98567629ba feat: the Shares section follows the group while it is open (Phase 3)
The room detail screen read the shares summary once, and again only
after one of its own actions, so a key state signed in the background
left Rotate shares disabled until the screen was reopened.
ChatRepository.observeSharesInputs emits when the room's key state,
signing sessions or refreshes change; the view model reads the section
again once they settle, and nothing else on the screen.

ChatRoomDetailSharesJvmTest 2/2, m3Audit, compileDebugKotlinAndroid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:47:00 +02:00
Kgothatso NgakoandClaude Opus 5.5 d358a0db38 feat: the Shares section holds Rotate shares and says why (Phase 2)
SharesSummary.canRotate becomes Rotation: Unavailable, Available, or
Held with a reason -- a rotation in progress, the group's signature on
the new shares still owed, or this device behind. The button stays,
disabled, with the reason beneath it.

While the key state is owed and nobody here is asking for it, the
section offers to ask the group to sign it
(ShareRefreshManager.proposeOwedKeyState), so a coordinator who is gone
does not hold every later rotation; while somebody is asking, it links
to the proposal. The offer to rotate without a removed member is made
only when a rotation could start now, and says so otherwise.

The section's actions run one at a time, through isActionPending.
ShareRefreshRitualJvmTest 24/24, m3Audit, compileDebugKotlinAndroid.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:44:59 +02:00
Kgothatso NgakoandClaude Opus 5.5 159ae402db feat: a rotation waits for the group to sign the last one (Phase 1)
A rotation is over when the group has signed the key state at the new
generation, not when its refresh completes. ShareRefreshManager.rotationHold
says why this device must not propose one now: a refresh still running,
a key state the group has not signed (or a key-state proposal still open
here, unless this device declined it), or a device behind the group.
proposeRefresh, and so proposeWithout, refuses on it.

The recovery walk test ran three rotations back to back with nothing
signed between; it signs each key state now. ShareRefreshRitualJvmTest
22/22.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:42:59 +02:00
Kgothatso NgakoandClaude Opus 5.5 fc437d0511 fix: a device does not vouch for a rotation's key state on its own
Material Design conformance / budgets (push) Canceled after 0s
Material Design conformance / tests (push) Canceled after 0s
The automatic ceremony lets a device sign, without asking its owner, the
one key state that can be true for a ceremony it finished
(GroupKeyStateManager.vouchesFor). Its seventh condition -- no state for
the room already signed here -- was what kept a share rotation's key
state out, and only in rooms that already had one. An eighth makes it
explicit: a state naming a share generation or a member binding says
more than the ceremony did, and its owner is asked.

Found by ShareRefreshRitualJvmTest after the merge: its devices hold no
first state, and the generation-1 state signed itself. jvmTest
1229/1229, compileDebugKotlinAndroid, audits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-20 00:08:21 +02:00