The rule that a keyed room's changes need the group's signature was
switched on after founding, once every member's device had said it could
follow signed commits. That protected Bennu members and older Giza
builds from being left behind by the first signed change. Giza is in
development and keeps compatibility with neither, so the switch
protected nobody, and it kept an invited member from ever being made an
admin.
MarmotGroupCreation.createFor now writes GovernanceMarker's line, with
the floor the ceremony's quorum sets, into the room's epoch-0
description. Founding still needs no signature: the founding invite is
the creator's commit while it is the only member, which no other device
processes.
Removed: GovernanceSupport and its event (30372), the announcements on
joining, at start and in answer, the automatic switch and
requireSignatures, and the screen's waiting and ready states.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Requiring the group's signature for changes was a button an admin had
to find on the room's screen. Nothing about it was a decision: the two
conditions it waits on -- every member's device can follow, enough of
them are admins -- were already checked in code. The button is gone.
One device switches it on: the admin in the room's lowest leaf, which
in a room as made is its creator (GovernanceSupport.switcherOf). Not
every admin's, because two commits at one epoch are not settled for
their authors (docs/marmot-v2.md, Phase 8); every device reads the same
leaf, so they agree on one without talking. GovernanceFollowThrough
runs the switch whenever a member says it follows signed commits, and
on start.
Not at creation: a Bennu or older-Giza founder would be cut off without
anyone knowing, and a founding invite finished later is a bare commit a
governed room refuses. The room switches seconds after its founders
join instead. The screen names whose device it is waiting on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An invited member of a robust group could never be made an admin. Making
one needs the room to require the group's signature, which waits until
every member's device has said it follows signed commits. A device said
so when the room's screen was opened, or back when it heard another say
it -- but the founders said it before the invite, at an epoch the new
member cannot read, so it heard nothing, nobody said it again, and the
room waited on a screen the member had no reason to open.
A device now says it on joining (the Welcome path) and once each start
(GovernanceSupport.announceAll), for members who joined before this.
The waiting notice names who the room waits on and what for, instead of
"X need to update Giza".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Marmot v2 rollout (docs/marmot-v2.md, Phase 9): new rooms are made on
the current profile, and the legacy KeyPackage slot is retired.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
remove-convenient-groups' new test makes its phones with Phone(profile);
since the legacy KeyPackage slot was retired every phone publishes the one
package the app does, so it is Phone().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotProfile.PUBLISHED is the current profile alone. The repository
publishes only the current-profile package and refuses to be asked for a
legacy one; KeyPackageEvent.build and the legacy leaf builder have no caller
and are gone. The notary republishes only what PUBLISHED names, so a legacy
bundle still active is left to be consumed and not replaced.
A legacy room still invites: the current-profile leaf advertises 0xF2EE.
RobustGroupAdminsJvmTest's legacy-room cases now join from the one package
the app publishes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotProfile.DEFAULT_FOR_NEW_ROOMS goes from LEGACY to CURRENT, so every
creation site -- direct messages, convenient rooms, keyed rooms -- makes a
current-profile group, and the pickers ask peers for current-profile
KeyPackages. Rooms made before stay legacy for good.
Two creation tests read the legacy 0xF2EE extension directly; they now read
the room id, name and admins through the accessors that work on both
profiles.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two files this branch deleted were changed on giza:
- SelectChatRoomTypeViewModel: giza added a reconcileAdmins call to the
convenient path, which this branch removed. The robust path
(MarmotGroupCreation) and direct messages (MarmotOutboundDao) already
reconcile, so the deletion stands.
- ChatRoomType: giza added minimumAdmins(threshold) for the admin floor.
It moves to Quorum.minimumAdmins beside the other quorum rules (D6);
AdminGovernance and AdminChangesJvmTest call it there.
docs/member-admin-promotion.md now notes where the names it cites went.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phases 8 and 9 of docs/member-admin-promotion.md, under the experimental
share enrollment: a keyed room makes a member an admin and enrolls them
into its key, and demotes an admin with the group's signature, then
rotates them out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under the experimental FROST enrollment. In a governed keyed room past its
ceremony's generation, Make admin is an offer (30374); the member accepts
(30375), naming the ChillDKG host key their shares will be sealed to,
which is the one decision only they can make. The offering device then
proposes one batch for the group to sign: the change making them an admin,
and the key state binding the next participant id to them, with that id's
public share -- interpolated from the table every device already holds --
added to the table it hashes.
Every device adds the id when it files that key state, and only if the
extended table hashes to what the group signed. Once the change lands the
offering device hands over (30376) the table, roster and signed key state;
the new member's device checks them against the room's own signature,
files its record of the key, and asks to be enrolled. t holders run
reduced FROST enrollment at newId = n through the repair protocol, with no
approval of their own -- the signed binding was it -- and the new share is
checked against the signed table.
A signing session's n is now the generation's table size, which an
enrollment grows; the repair session carries the n an enrollment runs
with (schema v42, still unshipped). GovernanceFollowThrough drives the
offerer's and the new member's steps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a governed keyed room, with share rotation on, an admin can propose
removing another as admin -- never themselves, since the rotation that
has to follow is the remaining holders'. The demotion is a signed change
like any other, and the floor holds. A removal of a member who holds a
live share is the same.
Either one remembers who to rotate out (GovernanceProposal.thenRotateWithout,
schema v42), is marked applied when a relay accepts it, and
GovernanceFollowThrough -- a driver beside the ceremony follow-through,
with the key pair -- then proposes the rotation without them. A change
that landed while the app was closed is caught from the group's state; a
rotation that cannot start is said in the room, and offered from the
Shares section.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Making a member an admin and back (docs/member-admin-promotion.md): in
convenient rooms by one admin's commit; in keyed rooms, a rule switched on
per room under which every change is proposed, signed by the group, and
applied only from inside that signature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robust-group-admins built the same thing as this branch's Phase 1: a single
writer for Participant.adminAt, run at creation, on the Welcome, on every
commit and once at start. Its AdminFlags is kept as that writer; this
branch's MarmotInboundManager.reconcileAdmins and adminFlagChanges are
gone, and the direct-message and convenient-room creation sites and the
detail screen's catch-up call AdminFlags instead. The admin captions stay,
on top of it.
Both sides added to the room's details: the founding-admin repair and
invite beside the member menu, admin labels and governance section. The
member row keeps one label line -- Admin from adminAt, Holds a share
beside it -- and the removal message now has three cases: proposed for the
group's signature, rotation held, or sent. The rotation offer waits for
both: a rotation available, and the removal not still awaiting signatures.
addAdmins, the founding-admin repair, proposes its commit for the group's
signature in a governed room instead of committing it bare.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The wallet audit fails on a retired kind's number anywhere in the app's
code, comments included; Phase 3 spelled the range out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a governed room, removing a member, inviting one and disbanding are
proposed and signed by the group instead of committed by one admin. A
removal is now one commit -- the Remove and, for an admin, their entry off
the admin list -- since a copy of the group can stage both where the
manager could not. Disbanding a room that has not yet agreed it can be
disbanded proposes that agreement first.
An admin's device folding in a member's leave sends it inside its own
envelope (30371), not bare. The commit builders live on GovernanceManager
so the DAO and the tests use the same ones.
Fixes a gate bug the inbound removal test found: a Remove's account is
now read off the group as it stood before the commit, because the copy's
view can already have the removed leaf blank.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A one-to-one chat, or a group its creator runs alone, grown by one more
person would be a group run by one person. The invite screen refuses such
a room and the detail screen no longer offers the invite there. The plan
gains D7, since D1 had assumed no such invite path existed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GovernanceManager.propose builds the commit on a copy of the group whose
policy records its proposals -- so the statement is read off the very
commit -- builds the kind:445 that carries it without publishing it, and
opens a signing session over the statement whose content is that kind:445.
A GovernanceProposal (schema v41) keeps the states either side, because
this device cannot process its own commit and signing outlasts a session.
Every member's device runs the same checks as the door before its owner is
asked, and declines a statement whose commit does not say what its tags
say. When the session completes on the proposer's device, it sends the
signed statement in a carrier and raises the publish gate with the kept
state; the relay's OK on the carrier installs it. A proposal the group
moved past is marked stale and said so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The group-creation screen no longer offers a group its creator runs alone.
It asks only how many of the members have to agree, then opens the NIP-17
room and its key ceremony. The single-admin Marmot path, its invite round
and its 'couldn't be added' card are gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each device says once per keyed room, as GovernanceSupportEvent (30372),
that it follows signed commits, and says it back whenever it hears another
member say it, so a member who never opens the room is still counted.
An admin's Require the group's signature for changes is one bare commit
adding GovernanceMarker's line, with the floor the room's quorum sets, to
the profile description: the room's last bare commit. It is refused while
any member has not said it -- they would be left in a different group by
the first change -- and while the room has fewer admins than the floor.
The room's screen says which, or that the rule is on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A keyed room whose profile description carries GovernanceMarker's line --
changes need the group's signature, and at least N admins -- is governed,
and every device reads that from the same epoch's state.
GovernanceGate is the door. At the one inbound call into the engine, a
commit sent bare into a governed room is dropped before the engine sees
it: the outer layer is peeled with the current and retained epochs' keys
and the MLS content type read from the header. A commit arrives instead
inside an envelope whose content is the proposer's own kind:445, so every
device applies the same event with the same id:
- a statement (30370), signed by the room and sent in a member's carrier
(30373), since an application message has to be its sender's;
- an own commit (30371) for D6's exemptions, sent by its committer.
The commit is run on a throwaway copy of the group under a policy that
records its proposals and committer -- no library change -- and admitted
only at the current epoch, matching its statement exactly, and leaving the
marker's floor of admins. A refusal says so in the room.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
giza brought rotation-waits-for-key-state, built in parallel from the
same base, and robust-group-admins. The first overlaps this branch, and
the two agreed on not asking the proposer. Where they met:
- The proposer's dialog is this branch's, read from the proposal's own
plan with its refusal, under giza's title and caveat; giza's dialog,
which listed stale members from the summary, went. The preview's
refusal carries rotationHold's reason, and ChatRoomDetailSharesJvmTest
asks its question of the kept dialog.
- The proposer is approved to take part only; giza also set
confirmApprovedAt, which nothing reads.
- The Shares section keeps both: giza's held button, its reason and
'Ask the group to sign', and this branch's running card and abandon.
- giza's hold tests left the new key state unsigned by not signing it.
It signs itself now, so they hold the signing messages after the
proposal (signingHeldOpen). This branch's test of two rotations opened
at once gave way to giza's, which asserts more.
jvmTest 1281/1281, compileDebugKotlinAndroid, m3Audit at its budgets,
brand and wallet audits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first draft's Phase 0 changed mls-kmp and marmot-kmp so that a device
could refuse an unsigned commit. Instead the group signs an event whose
content is the complete kind:445 commit, published as an application
message; every device checks it on a throwaway copy of the group and hands
the inner event to the engine, and drops a bare commit at the one inbound
door. The rule is a marker in the room's profile description, switched on
once every member has said it can follow it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GovernanceStatementEvent, kind 30370 (past the retired wallet kinds): one
epoch, and exactly what the commit made at it does -- who it adds, by the
KeyPackage that adds them; who it removes, by account; the whole admin
list after; and every other component it changes, by id and the hash of
its new value. Signed by the room, whose id is the key that must have
signed, so isSignedByRoom checks it with nothing looked up.
GovernanceChange.of reads a commit's proposals into those terms, refusing
anything a statement cannot describe; authorises holds a commit to its
statement, nothing more and nothing less; isExempt is D6's exemption, a
member's own leave and a committer's own key update. The signing approval
reads it in names. Pure: nothing enforces it until Phases 0 and 4.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every founding member of a robust group is its admin, phases 0-7
(docs/robust-group-admins.md). Two conflicts, both adjacent additions:
the detail screen's strings read outside the click handlers, and the
view model's companion constants. Both sides kept. jvmTest 1261/1261,
compileDebugKotlinAndroid, audits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChatRoomType.minimumAdmins(t) is max(3, t): in a keyed room the admins are
the share holders, so fewer than t of them is a key that can never sign
again. AdminGovernance.adminFloor reads t off the room's completed
ceremony (the size floor alone where this device holds none), removeMember
refuses a removal that would cross it, and the member row stops offering
one. A convenient room's floor stays the library's depletion guard.
The policy half -- every receiving device refusing such a commit -- waits
on Phase 0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each member row says Admin and Holds a share as two labels, read off the
group's state and the Shares roster; when they disagree a share is owed
or still to be rotated away. An admin's row has an overflow menu whose
items AdminGovernance.memberActions decides: make admin, remove as admin,
step down on your own row, remove from group. Promotion and demotion ask
first, and promotion says what it gives away.
Leave group, pressed by an admin, opens a dialog instead of a refusal:
step down and leave when another admin remains, or, for the only admin,
pick who takes over (or disband instead). stepDownAndLeave chains the
commits through MarmotEngine.afterConfirmed, which is now registered
before the commit it waits on and taken back if publishing throws.
Keyed rooms keep removal only; their admins wait on the group's signature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The plan is marked built, with a table of the nine places the build
chose differently -- among them that Phase 4 acts on a room at epoch 0
rather than on rows that were never written, since rows are hard-deleted,
and that it also fixed the current-profile routing bug Phase 0 found.
The README row says built; automatic-key-ceremony.md gains step 4 and
subgroups.md the repository taking the ceremony instead of a list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AdminFlags.reconcileAll runs AdminFlags.reconcile over every room this
device holds MLS state for, and the sync start calls it once, through
ChatRepository.reconcileAdminFlags, beside the ceremony resume. A room
joined before Phase 2 flags nobody on the joiner's device until some
commit arrives, and a robust group's admin room may never get one.
No stored "done" flag: a room whose rows already agree is a read and no
write, so a second start costs one decode per room. A room that will not
decode is logged and passed over.
RobustGroupAdminsJvmTest: a joiner's cleared flags are restored on both
profiles, and a second pass changes nothing. jvmTest 1250/1250,
compileDebugKotlinAndroid, audits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotOutboundDao.promote and demote commit the room's admin list through
the publish gate, built from the list the group holds when the commit is
staged. AdminGovernance holds the rules once: the library's permissions,
plus that a promoted account holds a leaf, and that a keyed room's admins
are changed by none of this -- they need the group's signature and a
share of its key, which are not built.
Removing an admin now takes them off the admin list first and removes
them when that commit is confirmed, chained by MarmotEngine.afterConfirmed.
A bare Remove left their key on the list, so inviting them back made them
an admin again with nobody having said so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The member list labels admins, from the flags AdminFlags keeps. Two
cards on the error container, under the signing key and the parent:
founding members the room's policy does not list as admins, with "Make
them admins" for an admin of a current-profile room; and founding
members the founding invite never reached, with "Invite them" on the
device that holds the room at epoch 0. Founders are named through their
profiles, since an uninvited one is not in the room to read a row off.
A robust group's NIP-17 room has no admins of its own, so its details
link to the admin room its ceremony made (ChatRepository.adminRoomOf),
saying every member is an admin there.
Strings in the catalogue, sentence case; colours from the error
container roles; spacing from the scale; the actions guard a second tap.
m3Audit: all budgets met. jvmTest 1249/1249, compileDebugKotlinAndroid.
Not looked at in a running app.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotGroupCreation.finishFoundingInvite invites the founders a room's
founding invite never reached, in one commit, every key package first as
at creation. It acts only on a room still at epoch 0: the founding
invite is the commit that ends epoch 0, and leaving is a commit too, so
a founder without a leaf there is one nobody ever invited -- never one
who left. CeremonyFollowThrough takes it as step 4 once the room exists,
on the coordinator's device; the repository exposes it by room for the
detail screen, with the set it would invite.
Also fixes what Phase 0 found. MarmotGroupCreation invited the founders
through a room read before its routing id was recorded, so on the
current profile the engine adopted a second copy of the group under the
room id, and the copy at the real address still held only its creator:
every later invite took the founding path, with no commit and nobody
already in the room told. It now reads the room again first.
RobustGroupAdminsJvmTest: a room left without its invite is finished and
every founder joins as an admin, on both profiles; a room past its
founding invites nobody; a later member on the current profile now gets
a real commit. CeremonyFollowThroughJvmTest: step 4's outcomes.
jvmTest 1249/1249, compileDebugKotlinAndroid, audits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The plan gets a Built header and a table of where the build chose
differently: the proposer was asked twice not three times; two rotations
opened at once never reach the write-once rule; the stall-clock test had
to backdate its messages to catch anything; one full run died on a
SQLite SIGSEGV unrelated to this change. frost-share-refresh.md's gate
table shrinks to one row with the history of CONFIRM, its key-state step
names the rule that now signs it, and README says both notes are built.
automatic-key-ceremony.md points here for the second automated key
state.
Not done: the emulator session. Nothing here has run on a device.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TYPE_ADMIN_ADDED and TYPE_ADMIN_REMOVED, derived like the membership
lines: processGroupMembershipChanges compares the group's admin set before
the commit with the one after, on every device that applies it. The prior
set comes from the group's state -- captured before the engine moves the
group on the inbound paths, and from the obligation's prior state on a
confirmed own commit -- never from the adminAt flags. An account that
left the tree gets its departure line and no admin line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Removing the second approval took away the only abandon button a member
who had taken part could reach: it lived on the approval row. A running
rotation is now a card above the members -- the step it is on (dealing,
storing, the group signing the new key state), who it waits on and since
when, and Abandon, behind a confirmation, for any member taking part.
It counts as running until the new generation's key state is signed,
while that signature is open, because the old shares wait on it. A
rotation that ended without completing says why until the next one.
The taking-part row now says what it decides: who is left out and as
what, and that nothing more will be asked. REFRESH_CONFIRM and its
string are gone from the UI state.
ShareRefreshManager.progress reads the step and who is missing from
stored messages. Those are now stored once, on first arrival, in record
and publishOwn: a redelivery rewrote the row and reset the stall clock.
Tests: the row names the withheld; the withheld member sees the rotation
run and cannot abandon it; the waiting-on names at dealing and storing;
the signing step, which nobody abandons; an abandoned rotation says why.
The stall-clock test backdates the messages first, and fails with the
old store-every-time behaviour put back. jvmTest 1250/1250; m3Audit at
its budgets; brand and wallet audits.
Not seen on a device.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>