Commit Graph
3514 Commits
Author SHA1 Message Date
Ethan Heilman 7ed8f6f38c Better quantum resistant section based Tim's comments
Adds additional acks
2024-04-25 13:42:24 -04:00
Ethan Heilman 0a3869d102 Fixes comment URI 2024-04-25 13:16:55 -04:00
Ethan Heilman 6c729c4b41 Renamed to use BIP-0347 2024-04-25 13:03:00 -04:00
Ethan Heilman f8ad6ede57 Changes OP_CAT BIP based on feedback given by Bob Summerwill
Bob Summerwill proposed a number of changes to the OP_CAT BIP to better follow BIP-2. This commit makes these changes:

* Using the section order specified in BIP-2
* Adding a Rationale section
* Expand the specification section by moving details from the abstract into the specification

Additionally this commit as rewords some confusing language.

Thanks Bob
2024-04-12 08:48:54 -04:00
Ethan Heilman c235aa4939 Adds more acknowledgements 2024-03-26 20:36:19 -04:00
Ethan Heilman ac231a17c2 Fixes broken mediawiki link 2024-03-20 23:53:53 -04:00
Ethan Heilman 35641a87d7 Merge pull request #3 from 0xBEEFCAF3/cat
Update OP_CAT implementation code
2024-03-20 23:39:53 -04:00
Armin Sabouri b3493746b1 update OP_CAT implementation 2024-03-20 18:33:02 -04:00
Ethan Heilman 2b5ab3b1fd Merge pull request #2 from 0xBEEFCAF3/patch-1
add clarifying note about the current opcode
2024-01-07 18:36:10 -05:00
Armin Sabouri 5dde7ea5cf revert changes to abstract 2024-01-07 18:18:46 -05:00
Armin Sabouri 2cec73a5b4 rm comment on disabled CAT opcode 2024-01-07 18:18:09 -05:00
Armin Sabouri 799dc0c96d Merge branch 'cat' into patch-1 2024-01-07 17:18:59 -05:00
Ethan Heilman f9e100e9de Notes that the opcode used is the same as the original cat opcode 2024-01-07 16:34:23 -05:00
Armin Sabouri ae68ef11cb add clarifying note about the current opcode
And some grammar + spelling cleanup
2024-01-07 13:24:04 -05:00
Ethan Heilman 82fe9fc3db specify the hex value of the opcode 2023-12-29 18:29:00 -05:00
Ethan Heilman e91621efce Merge pull request #1 from 0xBEEFCAF3/patch-1
Add backwards compatibility section
2023-12-29 12:23:39 -05:00
Armin Sabouri 785b11e861 Add backwards compatibility section 2023-12-29 12:14:45 -05:00
Ethan Heilman e492a90fec Better reference for OP_CAT removal 2023-12-18 20:28:22 -05:00
Ethan HeilmanandVojtěch Strnad e3dc3ba361 Italicize variables
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-17 12:53:07 -05:00
Ethan Heilman 97635f5c09 Lowercase the signatures 2023-12-17 12:49:46 -05:00
Ethan Heilman 4f39e4b9d5 Avoids designing or discussing how to add post-quantum commitments to Bitcoin 2023-12-16 16:23:49 -05:00
Ethan HeilmanandVojtěch Strnad 77509f6c23 Period to colon
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 15:57:08 -05:00
Ethan HeilmanandVojtěch Strnad 0b8a7e4b64 Code formatting
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 15:56:12 -05:00
Ethan HeilmanandVojtěch Strnad 82198302cd Code formatting
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 15:52:05 -05:00
Ethan Heilman 0a143d3969 Use BSD-3 license 2023-12-15 15:46:49 -05:00
Ethan HeilmanandVojtěch Strnad beb5802cc6 Adds subsection header
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 15:27:22 -05:00
Ethan HeilmanandVojtěch Strnad d4f85b1146 Lowercase bytes
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 14:44:07 -05:00
Ethan HeilmanandVojtěch Strnad 6f5a74d83e Increases conciseness and clarity
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 10:04:36 -05:00
Ethan HeilmanandVojtěch Strnad 7180c1cf8c Prefer bytes to Bytes
Co-authored-by: Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>
2023-12-15 09:54:50 -05:00
Ethan Heilmanandkallewoof 945e2a3742 Typos
TIL that it is "a one" rather than "an one"

Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:48:46 -05:00
Ethan Heilmanandkallewoof 01db3acab0 Removes space in ref
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:47:58 -05:00
Ethan Heilmanandkallewoof 6a790ec526 Removes space in ref
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:47:50 -05:00
Ethan Heilmanandkallewoof a2b0100671 Typo
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:47:36 -05:00
Ethan Heilmanandkallewoof 848352f408 Phrasing
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:45:04 -05:00
Ethan Heilmanandkallewoof c5d66d6706 Better phrasing
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:44:44 -05:00
Ethan Heilmanandkallewoof 9779dc9920 Keeps past tense consistant
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:44:14 -05:00
Ethan Heilmanandkallewoof bb725e6523 Wording
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-14 23:43:42 -05:00
Ethan Heilmanandkallewoof 3d31e5c894 Adds brackets
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-12 08:59:03 -05:00
Ethan Heilmanandkallewoof 0335c9d188 Grammar fix
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-12 08:27:35 -05:00
Ethan Heilmanandkallewoof 26e8e5f7fc Better fits bitcoin style guide
"If an if only has a single-statement then-clause, it can appear on the same line as the if, without braces. In every other case, braces are required, and the then and else clauses must appear correctly indented on a new line."

Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-12 08:26:36 -05:00
Ethan Heilmanandkallewoof f1169dd1fc Fixes typo
Co-authored-by: kallewoof <kalle.alm@gmail.com>
2023-12-12 08:24:39 -05:00
Ethan Heilman 83ca57f222 Create bip-???-cat.mediawiki 2023-12-11 18:11:22 -05:00
kallewoof e918b50731 Merge pull request #1498 from real-or-random/202309-0324-garbauth
bip324: Remove garbage authentication packet (breaking change)
2023-09-29 16:19:23 +09:00
Tim Ruffing 75dc363d20 bip324: Remove garbage authentication packet (breaking change)
by merging it with the version packet. Or more accurately, by merging
it with the first packet sent after garbage termination, which may be
a decoy packet or the version packet.

The new protocol simplifies implementations:
 - A protocol state machine won't need separate states for garbage
   authentication and version phases.
 - The special case of "ignoring the ignore bit" is removed.
 - The freedom to choose the contents of the garbage authentication
   packet is removed. This simplifies testing.

The reason for having a separate garbage authentication packet was
to materialize the separation of the key exchange phase and version
negotiation phase even in the bytestream on the wire. However, this
is not necessary, and arguably, these phases are still properly
separated: Since the AEAD will ensure that AAD (=garbage) is checked
before looking at the contents (=version), the peers won't interpret
version data before having authenticated the garbage.
2023-09-28 10:19:53 +02:00
kallewoof 7004ad1a82 Merge pull request #1496 from sipa/bip324
bip324: small improvements
2023-09-21 10:31:25 +09:00
Pieter Wuille cdcb6801a1 For now, remove BIP330 messages before being adopted 2023-09-11 13:43:29 -04:00
Pieter Wuille 397016ebdf Allow detecting/disconnecting wrong-network v1 peers 2023-09-11 13:43:23 -04:00
Pieter Wuille 175c5c06e0 Use 16-byte prefix to distinguish v1 from v2 2023-09-11 12:00:53 -04:00
Luke Dashjr e643d247c8 Merge pull request #1485 from luke-jr/bip300_adj20230726
BIP 300: Various improvements
2023-08-17 21:25:39 -04:00
Luke Dashjr fa21bdec66 Merge pull request #1482 from JeremyRubin/patch-8
Add James O'Beirne to 119 Author List
2023-08-16 09:49:21 -04:00