Commit Graph
2051 Commits
Author SHA1 Message Date
Pieter Wuille 5dab10b0b6 Merge pull request #135 from pyskell/patch-1
ADD: Require BIPs for Taproot and Tapscript
2019-11-16 12:48:23 -08:00
Pieter Wuille bc0c57e1fd Merge pull request #144 from devrandom/wording
Clarify 211 hash bytes and non-reuse of keys
2019-11-15 19:43:39 -08:00
Pieter Wuille e5d6ee25e9 Merge pull request #145 from instagibbs/patch-11
remind reader where [:] is defined
2019-11-15 14:24:24 -08:00
Gregory Sanders 8861bd503a remind reader where [:] is defined
in addition to `point`. This caused confusion for one reader who expected inclusive at end of range.
2019-11-15 13:46:35 -05:00
Dev Random b8cbd419e6 tweak 211 bytes text 2019-11-14 10:55:32 -08:00
Devrandom 1a9c7f948a clarify 211 hash bytes and non-reuse of keys 2019-11-13 18:46:05 +01:00
Pieter Wuille 1e27c4e307 Merge pull request #142 from OrfeasLitos/python-typo
Replace R with P in taproot_tweak_seckey
2019-11-13 08:50:18 -08:00
Orfeas Stefanos Thyfronitis Litos 7bce5a0930 Replace R with P in taproot_tweak_seckey 2019-11-13 14:00:03 +00:00
Anthony f620c87eb7 FIX: BIPs should be specified as lowercase to match filenames 2019-11-12 15:47:39 -05:00
Anthony 0af4a35295 ADD: Require Schnorr and Taproot BIPs for Tapscript
https://github.com/sipa/bips/pull/135#issuecomment-552754867
2019-11-12 14:08:09 -05:00
Pieter Wuille b79935a883 Merge pull request #136 from instagibbs/patch-10
BIP16 has no relation to bip-taproot/tapscript
2019-11-11 16:04:47 -08:00
Gregory Sanders c98970085d BIP16 has no relation to bip-taproot/tapscript
Previously did.
2019-11-11 15:32:57 -05:00
Anthony 5abcbca343 ADD: Require Schnorr BIP for Taproot
Per https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki:

"BIPs may have a Requires header, indicating the BIP numbers that this BIP depends on"
2019-11-11 13:40:42 -05:00
Pieter Wuille c936a9bc4b Merge pull request #132 from agis/patch-2
Fix typo
2019-11-11 08:03:40 -08:00
Agis Anastasopoulos af1638ce18 Fix typo 2019-11-11 12:39:53 +02:00
Pieter Wuille c9931d156c Merge pull request #130 from LaurentMT/patch-1
Fxied typo in taproot_sign_script()
2019-11-11 00:54:22 -08:00
LaurentMT ad4156a394 Fxied typo in taproot_sign_script() 2019-11-11 01:20:28 +01:00
Pieter Wuille 3700e18055 Merge pull request #128 from codeShark149/tweak_pubkey_change
Internal pubkey calculation fixed in taproot_tweak_pubkey()
2019-11-06 12:48:56 -08:00
codeShark149 de82b3ad26 Internal pubkey calculation fixed in taproot_tweak_pubkey() 2019-11-06 23:48:29 +05:30
Pieter Wuille 230f6cb734 Merge pull request #125 from fjahr/patch-1
Link design section of BIP Schnorr in Specification
2019-11-06 07:44:44 -08:00
Pieter Wuille 73ade2d61b Merge pull request #126 from MaxHillebrand/patch-1
fix: script spend, not key spend reveals tree depth
2019-11-06 07:44:00 -08:00
Max Hillebrand 78eb015f63 fix: script spend, not key spend
For the key spend the script tree depth is not revealed, it is only done for script spends. This sentence makes sense only for the script spend.
2019-11-06 05:58:11 +01:00
Pieter Wuille 3f62751809 Merge pull request #121 from jonasnick/add-test-vector
Fix point_from_bytes accepting out-of-range pubkeys and add test vector
2019-11-05 09:57:41 -08:00
Fabian Jahr 08622c9494 Link design section of BIP Schnorr in Specification 2019-11-05 14:53:16 +01:00
Jonas Nick 8a8a35bfc5 Update test-vectors.csv 2019-11-05 10:14:23 +00:00
Pieter Wuille 857dd625b5 Merge pull request #114 from real-or-random/patch-11
improve rationale for key prefixing
2019-11-04 16:06:29 -08:00
Jonas Nick 8e7aef083e Fix point_from_bytes accepting out-of-range pubkeys and add test vector 2019-11-05 00:05:07 +00:00
Pieter Wuille 1bb025aa22 Merge pull request #116 from jonasnick/test-vec-terminology
Adjust reference code and test vectors to latest bip
2019-11-04 16:00:42 -08:00
Jonas Nick 0ec01e9255 Fix typo in reference code comment 2019-11-04 23:35:55 +00:00
Jonas Nick 35f1fface5 Make more clear that signing function in test vectors generation code isn't intended to be used anywhere else 2019-11-04 23:35:31 +00:00
Jonas Nick c0f0c8d43d Check infinity in is_positive 2019-11-04 23:35:24 +00:00
Jonas Nick 220df7da78 Adjust test vector generation code to latest terminology 2019-11-04 23:35:17 +00:00
Jonas Nick 854a33ab48 Fix test vector generation code after changing schnorrsig_sign api 2019-11-04 23:35:11 +00:00
Pieter Wuille 2f1c4d80ae Merge pull request #124 from sipa/square_terminology
Settle on notation: is_square(y), has_square_y(P)
2019-11-04 13:59:59 -08:00
Pieter Wuille 0c6a9cffad Settle on notation: is_square(y), has_square_y(P) 2019-11-04 13:42:24 -08:00
Pieter Wuille eacf0c6533 Merge pull request #120 from dgpv/patch-2
bip-taproot: fix docstring in taproot_output_script
2019-11-04 13:28:36 -08:00
Dmitry Petukhov db8d6d426f fix docstring in taproot_output_script
the final "-None" line in the docstring of `taproot_output_script` example function was actually outside of the docstring
2019-11-05 02:13:24 +05:00
Pieter Wuille fda77055c7 Merge pull request #122 from dgpv/patch-3
bip-taproot: use bytes() instead of b'' - avoid markdown issue
2019-11-04 11:34:37 -08:00
Dmitry Petukhov 12d8d5baa8 use bytes() instead of b'' - avoid markdown issue
Currently github markdown renders `b''` inside `<source>` tags incorrectly. This makes `h = b''` show as `h = b` and creates some confusion.
The issue can be avoided by using bytes() to create empty byte array
2019-11-04 19:15:12 +05:00
Pieter Wuille e174022b36 Merge pull request #115 from real-or-random/patch-12
typos
2019-10-30 01:28:41 -07:00
Tim Ruffing db1973ffba improve rationale for key prefixing 2019-10-30 01:32:07 +01:00
Tim Ruffing 73b8e3aeeb typos 2019-10-30 01:27:26 +01:00
Pieter Wuille cf43d29fff Merge pull request #112 from sipa/201910_success_above_all_else
Consistently mention resource limits in bip-tapscript
2019-10-28 13:38:58 -07:00
Pieter Wuille 89b32a095d Merge pull request #113 from sipa/201910_altsigning
Elaborate on default and alternative signing
2019-10-27 14:31:45 -07:00
Pieter WuilleandTim Ruffing da4721cdc6 Update bip-schnorr.mediawiki
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2019-10-25 10:18:29 -07:00
Pieter WuilleandTim Ruffing 322ce53625 Update bip-schnorr.mediawiki
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
2019-10-25 10:18:17 -07:00
Pieter Wuille f95ac70606 Elaborate on default and alternative signing 2019-10-24 16:03:33 -07:00
Pieter Wuille 6d6b9c6940 Consistently mention resource limits in bip-tapscript 2019-10-24 11:12:59 -07:00
Pieter Wuille 436f14d9d7 Merge pull request #111 from sipa/201910_whynocmssuccess
Explain why CMS is not turned into SUCCESSx
2019-10-24 09:31:31 -07:00
Pieter Wuille 852951276f Merge pull request #109 from sipa/201910_multisig
Improve section on alternatives to OP_CHECKMULTISIG
2019-10-23 11:20:00 -07:00