Files
giza-kmp/composeApp
Kgothatso NgakoandClaude Opus 5 e4657df08e test(frost): cover the transport every ordinary session actually uses
Nine tests for gaps found by auditing the suite against the branches rather than
by counting tests.

The big one: every existing resend test ran on a NIP-17 room, which is only a
group's *first* signature. Every ordinary session runs in the Marmot admin room,
and that path had never executed -- no coverage at all for the store it writes
to, the tags it omits, or the id guard on that store. Given the bug fixed in
daf8365a was transport-specific, this was the gap most likely to hide the next
one. Three tests now cover it: a resend is one group event naming nobody with
the silent tag still on it, a nudged member republishes the same bytes as an
inner event, and the id guard holds on that store too.

Also covered, each of them a branch that had never run:

 - resending while collecting partial signatures, which repeats the signer set.
   One of three arms of the stage table, and the arm a stalled signer needs: they
   have the proposal and their nonce is in, and the signer set that says what to
   sign against never arrived.
 - the same stage table sending no signer set before one is chosen.
 - republishing a partial signature -- the third kind `republishOwn` repeats, and
   the one whose loss stalls a session that has every other piece.
 - refusing a resend whose stored events will not parse.
 - ignoring a silent tag on anything but a proposal, so the nudge cannot be
   triggered by any message at all.
 - the singular transcript wording.

Two notes on what is still not covered. `broadcast` returning false needs four
identical publishes in four consecutive seconds behind a five-minute cooldown;
forcing it means injecting a clock, and a racy test of it would be worse than
the guard. And neither the screen section nor the view model has a test, though
both are established patterns in this project.

Found the same `maxBy`-on-a-shared-second trap again while writing these, which
is now a helper per transport rather than a thing to remember.

1288 tests, no failures. m3Audit: all budgets met.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-10-06 15:33:10 -05:00
..
2026-09-18 18:20:09 +02:00