feat(lightning): the rollout gates, and who has not answered (Phase 15)
The gates are in code and stay closed. `GroupLightningRollout.ENABLED` is false because its own condition, a regtest end-to-end run, has not been met; mainnet is refused by `allows` whatever a screen offers. The ceremony screen names every participant who has not answered the proposal, with a word that their build may not know the new kinds: a member on an old build is a co-signer who never answers, and the group is smaller for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
6140aef33a
commit
bab4b67fca
3 files changed
+13
-1
No files matched your search
@@ -774,4 +774,5 @@
|
||||
<string name="close_its_channels">Close its channels</string>
|
||||
<string name="sweep_s_sats">Sweep %1$s sats</string>
|
||||
<string name="nobody_runs_this_wallet_s_node">Nobody runs its node, and its channels close only through it.</string>
|
||||
<string name="hasn_t_answered_the_proposal_yet">Hasn't answered the proposal yet. Their device may need an update that knows Lightning wallets.</string>
|
||||
</resources>
|
||||
+11
-1
@@ -38,6 +38,7 @@ import bennu.composeapp.generated.resources.confirm_what_you_saw
|
||||
import bennu.composeapp.generated.resources.confirming_publishes_your_public_share
|
||||
import bennu.composeapp.generated.resources.couldn_t_approve_this_step
|
||||
import bennu.composeapp.generated.resources.couldn_t_start_the_key_ceremony
|
||||
import bennu.composeapp.generated.resources.hasn_t_answered_the_proposal_yet
|
||||
import bennu.composeapp.generated.resources.join_the_ceremony
|
||||
import bennu.composeapp.generated.resources.joining_publishes_commitments
|
||||
import bennu.composeapp.generated.resources.lightning_wallet_key
|
||||
@@ -234,7 +235,16 @@ private fun Ceremony(modifier: Modifier, state: IcebergCeremonyUIState.Loaded, i
|
||||
items(session.participants()) { participant ->
|
||||
ListItem(
|
||||
headlineContent = { Text(members[participant]?.profile?.humanReadableNameOrPubkey() ?: participant.take(16)) },
|
||||
supportingContent = { Text(stringResource(Res.string.s_of_3_steps, (state.progress[participant] ?: 0).toString())) },
|
||||
supportingContent = {
|
||||
// Phase 15: a member whose build does not know these kinds never answers, and the
|
||||
// group would be smaller for it, so the screen says who has not.
|
||||
val steps = state.progress[participant] ?: 0
|
||||
val failed = session.stage == IcebergRitualStage.FAILED
|
||||
Text(
|
||||
text = if (steps == 0 && !failed) stringResource(Res.string.hasn_t_answered_the_proposal_yet) else stringResource(Res.string.s_of_3_steps, steps.toString()),
|
||||
color = if (steps == 0 && !failed) MaterialTheme.colorScheme.error else MaterialTheme.colorScheme.onSurfaceVariant,
|
||||
)
|
||||
},
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -43,6 +43,7 @@ build chose differently, this table says so.
|
||||
| 12 | done: `GroupLightningAuthorisationEvent` (kind 30346, `pay`), budgets read from the signed authorisations, the node paying each once, its summary and transcript line, and the send screen (`GroupLightningSendScreen`). The co-signers now hold offered HTLCs under the statement's in-flight cap. Seven new tests |
|
||||
| 13 | done, except splicing out. `close` and `force-close` authorisations, the node acting on each once, the co-signers signing our own commitment only under a force-close authorisation and only after rebuilding it, and the channel menu on the wallet screen. Sweeps: the snapshot lists what closed channels left the group, any member proposes a sweep (`GroupSweep`, a new FROST subject), every member checks it against its own basepoints and the onchain wallet, and the watcher sends it. Five new tests: a force close and a two-input sweep both pass the script interpreter |
|
||||
| 14 | done: a room can have several Lightning wallets on a network, the highest-numbered current. A member who leaves is named on the wallet screen until a new wallet replaces it; the new key is made over the onchain key's holders who are still in the room; the old wallet keeps its operator and node until its channels are closed, in one decision for all of them; and removing a share holder says what it leaves. A five-device test re-keys after a removal |
|
||||
| 15 | the gates are in code and closed. `GroupLightningRollout.ENABLED` stays `false`: its own condition is a regtest end-to-end run, which has not been done (see Phase 0). Mainnet is refused by `GroupLightningRollout.allows`, whatever a screen offers. The ceremony screen names every participant who has not answered, with a word that their build may not know the new kinds |
|
||||
|
||||
| what the plan said | what it turned out to be |
|
||||
|---|---|
|
||||
|
||||
Reference in new issue
Block a user