Closes the last gap the review listed, and the one the plan left as
optional: no CI job built any experimental module through CMake, so the
src/CMakeLists.txt wiring for frost, chilldkg, iceberg, prefractal and
frost_enrollment was guarded only by developers running it locally.
The plan suggested "adding the experimental modules to one existing
CMake job". There are two candidates and they are not equivalent:
- win64-native is the only job that RUNS CMake tests, but it builds with
MSVC and clang-cl under CFLAGS="/WX". None of the five modules has
ever been compiled by MSVC. Turning them on there would be a porting
exercise whose first result is a wall of warnings-as-errors from code
unrelated to any regression -- and it would land that on four modules
this branch does not otherwise touch.
- The release job's "Check installation with CMake" step is gcc on
Linux, the same compiler and platform where all five are known to
build. It configures, builds and installs.
The second is where the flags go. It does not run ctest, which is fine:
the tests already run under autotools in 45 job contexts. What was
unguarded was the WIRING, and this step exercises exactly that -- the
SECP256K1_EXPERIMENTAL gate, the dependent-module block ordering, and
the PUBLIC_HEADER appends, which the install step then confirms landed
by listing the installed tree.
Verified that the guard is not decorative. Moving the frost_enrollment
block in src/CMakeLists.txt from before the FROST block to after it --
the exact trap the module's commit message describes, where a block that
force-enables a dependency runs too late for the block that emits its
compile definition -- makes this step fail with undefined references to
secp256k1_frost_derive_pubshare_at and friends. Before this change, that
mistake reached main with nothing complaining.
Also verified the command as written: configure, build and install with
all five modules on succeeds on gcc/Linux, the installed include
directory carries secp256k1_frost.h, secp256k1_chilldkg.h,
secp256k1_iceberg.h, secp256k1_prefractal.h and
secp256k1_frost_enrollment.h, and the step's follow-up compile of
examples/ecdsa.c against the installed library still links and runs. The
workflow parses, and the step really does carry all five module flags
plus the experimental gate.
This deliberately changes CI coverage for four modules beyond the one
this branch adds. It only adds coverage -- no existing job loses
anything -- but it is a one-line revert if the wider scope is unwanted.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
98aadc121f