LLFourn
890d6191a1
Remove Option trickery from TxBuilder API
...
see: https://github.com/bitcoindevkit/bdk/pull/258#issuecomment-754685962
2021-01-22 15:08:30 +11:00
LLFourn
735db02850
Assert that .finish() hasn't been called already in coin_selection
2021-01-22 14:33:37 +11:00
LLFourn
7bf46c7d71
Add comment explaining why params and coin_selection are Options
2021-01-22 14:33:37 +11:00
LLFourn
8319b32466
Fix wrong doc links
2021-01-22 14:33:37 +11:00
LLFourn
5fb7fdffe1
[wallet] Use doctest_wallet!() to remove some no_runs from doctests
...
...and improve the fee bumping example while trying to make it
no_run (but failed).
2021-01-22 14:33:37 +11:00
LLFourn
7553b905c4
[wallet] Overhaul TxBuilder internals and externals
...
Fixes #251
TxBuilders are now not created directly but are created through the
wallet with `build_tx` and `build_fee_bump`.
The advantages of this realised in this commit are:
1. Normal tx creation and fee bumping use the code internally. The only
difference between normal tx and fee bump is how the builder is created.
2. The TxBuilder now has a refernce to the wallet and can therefore
lookup things as methods are called on it. `add_utxo` now uses this to
look up UTXO deta when it is called (rather than having to do it and
possibly error later on).
To support these changes `get_utxo` and `get_descriptor_for_keychain`
public methods have been added to Wallet. I could have kept them
pub(crate) but they seem like fine APIs to have publicly.
2021-01-22 14:33:37 +11:00
LLFourn
f74f17e227
Change "received_tx" into "populate_test_db" macro
...
A `[cfg(test)]` function is not as helpful as a macro since it can't be
called in the context of a doctest.
Also adds doctest_wallet macro which can be used to create a wallet in a
doctest.
2021-01-22 14:23:36 +11:00
Tobin Harding
03b7c1b46b
Use contains combinator
...
As suggested by clippy, use the `contains` combinator instead of doing
manual range check on floats.
2021-01-18 10:46:12 -08:00
Justin Moon
7bc8c3c380
[wallet] Add "needed" and "available" metadata to Error::InsufficientFunds
2021-01-13 23:00:37 -06:00
Alekos Filini
6955a7776d
Merge commit 'refs/pull/264/head' of github.com:bitcoindevkit/bdk
2021-01-12 14:02:41 +01:00
Alekos Filini
bf04a2cf69
descriptor: Use DescriptorError instead of Error when reasonable
...
Change the return type of the `descriptor!()` macro and `ToWalletDescriptor` to
avoid having to map errors.
Also introduce more checks to validate descriptors built using the macro.
2021-01-12 12:21:22 +01:00
Riccardo Casatta
2b669afd3e
Permit to not set timeout in ElectrumBlockchainConfig
...
Allowing to use socks5 which requires None timeout
2021-01-11 14:06:56 +01:00
Alekos Filini
a95a9f754c
Merge commit 'refs/pull/260/head' of github.com:bitcoindevkit/bdk
2021-01-05 16:06:32 +01:00
Alekos Filini
3980b90bff
Merge commit 'refs/pull/248/head' of github.com:bitcoindevkit/bdk
2021-01-05 16:04:53 +01:00
Alekos Filini
b2bd1b5831
Merge commit 'refs/pull/257/head' of github.com:bitcoindevkit/bdk
2021-01-05 16:01:15 +01:00
Steve Myers
aa31c96821
[ci] Fail 'Build docs' job if warnings
2021-01-04 16:39:11 -08:00
Steve Myers
f74bfdd493
Remove 'cli.rs' module, 'cli-utils' feature and 'repl.rs' example
2020-12-31 09:44:30 -08:00
Steve Myers
5034ca2267
Fix clippy warnings for compact_filters feature
2020-12-30 19:23:35 -08:00
LLFourn
0c9c0716a4
[wallet] Fix details.fees being wrong when change is dust
2020-12-29 16:36:35 +11:00
Alekos Filini
c2b2da7601
Merge commit 'refs/pull/252/head' of github.com:bitcoindevkit/bdk
2020-12-23 18:39:05 +01:00
LLFourn
656c9c9da8
Use () to indicate a missing blockchain
...
So that:
1. There are no runtime errors
2. There less type annotations needed
3. Less traits and stuff to document
2020-12-23 14:52:29 +11:00
LLFourn
a578d20282
Fix incredibly annoying cargo-fmt problem
...
I must have a newer version of cargo-fmt which stops me from making
commits every time because of this.
2020-12-22 14:37:53 +11:00
Alekos Filini
63aabe203f
Merge commit 'refs/pull/235/head' of github.com:bitcoindevkit/bdk
2020-12-18 10:41:37 +01:00
Steve Myers
2325a1fcc2
[docs] Format code in docs with '--config format_code_in_doc_comments=true'
2020-12-16 15:12:51 -08:00
Steve Myers
fb5c70fc64
[docs] Replace all 'allow(missing_docs)' with basic docs
2020-12-16 15:12:49 -08:00
Steve Myers
8cfbf1f0a2
[docs] Add more docs to 'types.rs'
2020-12-16 15:12:47 -08:00
Alekos Filini
713411ea5d
[keys] impl ToDescriptorKey for &str
2020-12-16 19:06:02 +01:00
Alekos Filini
7e90657ee1
[descriptor] Make the syntax of descriptor!() more consistent
...
The syntax now is pretty much the same as the normal descriptor syntax,
with the only difference that modifiers cannot be grouped together (i.e.
`sdv:older(144)` must be turned into `s:d:v:older(144)`.
2020-12-16 19:00:55 +01:00
Riccardo Casatta
635d98c069
[docs] use only sled instead of crate::sled
2020-12-16 12:11:49 +01:00
Riccardo Casatta
680aa2aaf4
[docs] fix NetworkMessage::Ping docs link
2020-12-16 12:11:26 +01:00
Alekos Filini
5f373180ff
Merge commit 'refs/pull/223/head' of github.com:bitcoindevkit/bdk
2020-12-16 11:11:38 +01:00
Alekos Filini
931a110e4e
Merge commit 'refs/pull/229/head' of github.com:bitcoindevkit/bdk
2020-12-16 10:48:10 +01:00
Steve Myers
148e8c6088
[docs] Add docs to the 'wallet' module
2020-12-15 15:12:32 -08:00
Evgenii P
09730c0898
Take ID into account in SignersContainerKey's PartialEq impl
2020-12-15 22:40:07 +07:00
Alekos Filini
6d9472793c
Merge commit 'refs/pull/228/head' of github.com:bitcoindevkit/bdk
2020-12-15 14:33:59 +01:00
Alekos Filini
eadf50042c
[wallet] Add tests for check_nsequence_rbf and check_nlocktime
2020-12-15 12:01:44 +01:00
Alekos Filini
322122afc8
[wallet] Set the correct nSequence when RBF and OP_CSV are used
...
This commit also fixes the timelock comparing logic in the policy module, since
the rules are different for absolute (OP_CLTV) and relative (OP_CSV) timelocks.
Fixes #215
2020-12-15 12:01:41 +01:00
Evgenii P
5315c3ef25
rustfmt
2020-12-15 11:36:26 +07:00
Evgenii P
c58236fcd7
Fix SignersContainer::find to filter out incorrect IDs
2020-12-15 11:36:26 +07:00
Evgenii P
2658a9b05a
Fix SignersContainerKey PartialOrd to respect the ID
2020-12-15 11:36:26 +07:00
Evgenii P
c075183a7b
Revert replacing BTreeMap to HashMap in SingersContainer
2020-12-15 11:35:34 +07:00
LLFourn
9b31ae9153
Fix doc comment fallout from s/script type/keychain
2020-12-15 08:39:19 +11:00
Alekos Filini
1713d621d4
Rename ScriptType to KeychainKind
...
This avoids confusion with the "type of script".
2020-12-14 17:14:24 +01:00
Alekos Filini
c83cec3777
Merge commit 'refs/pull/221/head' of github.com:bitcoindevkit/bdk
2020-12-14 11:27:51 +01:00
Alekos Filini
0ef0b45745
Merge commit 'refs/pull/224/head' of github.com:bitcoindevkit/bdk
2020-12-14 11:18:51 +01:00
Evgenii P
351b656a82
Use unstable sort by key for performance
2020-12-14 16:27:54 +07:00
Steve Myers
f8d3cdca9f
[docs] Add experimental warning to compact_filters and policy modules
2020-12-13 21:04:17 -08:00
Steve Myers
0f2dc05c08
[docs] Add docs to the 'descriptor' module
2020-12-13 20:57:28 -08:00
Steve Myers
4e771d6546
[docs] Add docs to the 'template' module
2020-12-13 20:41:32 -08:00
Steve Myers
60e5cf1f8a
[docs] Add docs to the 'policy' module
2020-12-13 20:40:23 -08:00
