frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove wrong TODO comment in build_fee_bump

Browse Source 
The proposed solution is bad for privacy as well.
Let's call the initial change output, which is normally shrink when you
fee bump, change#1, and the extra output aforementioned change#2 (as,
in this case, it's going to be a change output as well). If you add change#2
you might not revel change#1, but you're still revealing change#2.
You're not improving your privacy, and you're wasting money in fees.
This commit is contained in:
Daniela Brozzoni 2022-06-30 20:31:38 +02:00
parent ec22fa2ad0
commit 1d9fdd01fa
No known key found for this signature in database
GPG Key ID: 7DE4F1FDCED0AB87
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/mod.rs
View File

@ -899,8 +899,6 @@ where
/// # Ok::<(), bdk::Error>(()) /// # Ok::<(), bdk::Error>(())
/// ``` /// ```
// TODO: support for merging multiple transactions while bumping the fees // TODO: support for merging multiple transactions while bumping the fees
// TODO: option to force addition of an extra output? seems bad for privacy to update the
// change
pub fn build_fee_bump( pub fn build_fee_bump(
&self, &self,
txid: Txid, txid: Txid,