From 1d9fdd01faf3a0f17c57381a7c54d136e9d69ffe Mon Sep 17 00:00:00 2001 From: Daniela Brozzoni Date: Thu, 30 Jun 2022 20:31:38 +0200 Subject: [PATCH] Remove wrong TODO comment in build_fee_bump The proposed solution is bad for privacy as well. Let's call the initial change output, which is normally shrink when you fee bump, change#1, and the extra output aforementioned change#2 (as, in this case, it's going to be a change output as well). If you add change#2 you might not revel change#1, but you're still revealing change#2. You're not improving your privacy, and you're wasting money in fees. --- src/wallet/mod.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/wallet/mod.rs b/src/wallet/mod.rs index 4abe2574..213cc60d 100644 --- a/src/wallet/mod.rs +++ b/src/wallet/mod.rs @@ -899,8 +899,6 @@ where /// # Ok::<(), bdk::Error>(()) /// ``` // TODO: support for merging multiple transactions while bumping the fees - // TODO: option to force addition of an extra output? seems bad for privacy to update the - // change pub fn build_fee_bump( &self, txid: Txid,