Steve Myers 1f914c2b4d
Merge bitcoindevkit/bdk-ffi#209: Change TxBuilder.finish() to return new TxBuilderResult
fadb316451af080bf22774a164278cef04acd9cc Change TxBuilder.finish() to return new TxBuilderResult (Steve Myers)

Pull request description:

  ### Description

  Change TxBuilder.finish() to return new TxBuilderResult.

  ### Notes to the reviewers

  This fixes #179 in that it return both PartiallySignedBitcoinTransaction and TransactionDetails encapsulated in a new TxBuilderResult structure. It does not calculate the fee rate which requires #208.

  ### Changelog notice

  - Breaking Changes
    - Changed `TxBuilder.finish()` to return new `TxBuilderResult`.
  - APIs Added
    - Added `TxBuilderResult` with PSBT and TransactionDetails.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  thunderbiscuit:
    ACK [fadb316](fadb316451).

Tree-SHA512: b8aafc53ba86bf7ab12ae3d5bb251d1ec5cb54e4b7d6bfc342155d5cd3726d9a6d114591dc740a7467afb8ef402f3d77ad51e273a27865d6e47192291b570af9
2022-10-19 12:30:06 -05:00
2021-10-16 14:45:32 +05:30
2022-02-08 22:15:10 +01:00
2022-10-17 16:19:35 -04:00
2022-02-27 21:26:23 -08:00
2022-02-27 21:26:23 -08:00
2022-02-27 21:26:23 -08:00

Native language bindings for BDK

MIT or Apache-2.0 Licensed CI Status Rustc Version 1.61.0+ Chat on Discord

The workspace in this repository creates the libbdkffi multi-language library for the rust based bdk library from the Bitcoin Dev Kit project. The bdk-ffi-bindgen package builds a tool for generating the actual language binding code used to access the libbdkffi library.

Each supported language has its own repository that includes this project as a git submodule. The rust code in this project is a wrapper around the bdk library to expose it's APIs in a uniform way using the mozilla/uniffi-rs bindings generator for each supported target language.

Supported target languages and platforms

The below repositories include instructions for using, building, and publishing the native language binding for bdk supported by this project.

Language Platform Repository
Kotlin jvm bdk-kotlin
Kotlin android bdk-kotlin
Swift iOS, macOS bdk-swift
Python linux, macOS bdk-python

Language bindings generator tool

Use the bdk-ffi-bindgen tool to generate language binding code for the above supported languages. To run bdk-ffi-bindgen and see the available options use the command:

cargo run -p bdk-ffi-bindgen -- --help

Contributing

Adding new structs and functions

See the UniFFI User Guide

For pass by value objects

  1. create new rust struct with only fields that are supported UniFFI types
  2. update mapping bdk.udl file with new dictionary

For pass by reference values

  1. create wrapper rust struct/impl with only fields that are Sync + Send
  2. update mapping bdk.udl file with new interface

Goals

  1. Language bindings should feel idiomatic in target languages/platforms
  2. Adding new targets should be easy
  3. Getting up and running should be easy
  4. Contributing should be easy
  5. Get it right, then automate

Thanks

This project is made possible thanks to the wonderful work by the mozilla/uniffi-rs team.

Description
Frost experimentation on bdk-ffi
Readme 22 MiB
Languages
Rust 64.6%
Kotlin 18.1%
Swift 9.5%
Python 4.6%
Shell 2.2%
Other 1%