This commit resolves a build error related to mismatched JVM target
versions for the Kotlin and Java compile tasks. Previously, the
'compileJava' task was targeting JVM 11, while the 'compileKotlin'
task was targeting JVM 8.
Both tasks have now been set to target JVM 11, ensuring consistency
and eliminating the build error.
The current build instructions for bdk-jvm are insufficient for someone to build bdk-jvm from scratch. It's not outlined that JDK 11 and Rust is required on the system.
beb75dd552 Use version 21 of the Android NDK in the CI test, build, and publish workflows (thunderbiscuit)
Pull request description:
This PR reverts an update to our Android CI workflows.
For info on why this is needed, see issues #242 and #243.
ACKs for top commit:
notmandatory:
ACK beb75dd552
Tree-SHA512: dfee0b1f335318b86fa490fa85e7ef5d7a032e01a78db64a186c5d75e9e77e8f0e2af58ee5407d4fe38a0aa3aabbc7b06b23189aef0dfaad1d246a354452870d
4e5537acd2 Add SignOptions to Wallet.sign() params (Steve Myers)
Pull request description:
### Description
Fixes#323
### Notes to the reviewers
I didn't include the `tap_leaves_options: TapLeavesOptions` because it would require more deeply nested structures and is not currently required.
### Changelog notice
- Add SignOptions to Wallet.sign() params.
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
#### New Features:
* [ ] I've added tests for the new feature
* [x] I've added docs for the new feature
Top commit has no ACKs.
Tree-SHA512: e846388b93b5270dd6d1f86ebff462d1c69aa0ea8359d7e4955c88eed4dac1ce00f8da3ecf2432e6eba6e1e5b2f52e3e789918aa31a4b739a7d0a5185b5c3c0c
cd10c75e96 Add to_qr_uri() method on Address type (thunderbiscuit)
cbd44249f3 Add kotlin api-docs for Address.payload() and Address.network() (Steve Myers)
20c31d5383 Expose Address payload and network properties (Steve Myers)
616cb21738 Update Cargo.lock (Steve Myers)
Pull request description:
### Description
Fixes#319
### Notes to the reviewers
The test data was generated with:
```
bitcoin-cli -rpcwallet="regtest2" -datadir=/tmp/regtest1/bitcoind -regtest validateaddress "bcrt1qqjn9gky9mkrm3c28e5e87t5akd3twg6xezp0tv"
{
"isvalid": true,
"address": "bcrt1qqjn9gky9mkrm3c28e5e87t5akd3twg6xezp0tv",
"scriptPubKey": "001404a6545885dd87b8e147cd327f2e9db362b72346",
"isscript": false,
"iswitness": true,
"witness_version": 0,
"witness_program": "04a6545885dd87b8e147cd327f2e9db362b72346"
}
```
### Changelog notice
Added
- Expose Address payload and network properties.
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
#### New Features:
* [x] I've added tests for the new feature
* [x] I've added docs for the new feature
ACKs for top commit:
thunderbiscuit:
ACK cd10c75e96.
Tree-SHA512: 65a1d550577fd4a35cfeb8fb765002e47e0703ff40fc7a68c07b78bc1ba642d33a0efbdfa8f9322024841ba84d25c0e289294c10ae4c1b4d52eb9beffa3d0e10
thunderbiscuit
Steve Myers
yellowhatpro
Matthew
David Sterling
andreasgriffin