mirror of
https://github.com/bitcoin/bips.git
synced 2025-05-26 12:10:14 +00:00
Updated Comments:BIP 0171 (markdown)
parent
6e12e112eb
commit
1744ff1e0e
@ -8,3 +8,21 @@ I just released CERISE ([website](http://www.cerise.tech/) & [github](https://gi
|
||||
|
||||
Stéphane Traumat ( @straumat )
|
||||
***
|
||||
**Change to make in the BIP ?**
|
||||
“a GET request to a common URI with parameters encoded in application/x-www-form-urlencoded format”
|
||||
May I ask you why parameters should be encoded this way ? From what I have seen in other projects, they also allow json for get method.
|
||||
|
||||
There is no description on how to return error messages ?
|
||||
For the moment, for any error, I return this message structure : {"message":"Currency-pair should be no longer than 255 characters","errors":["‘AAAAA.AAAA’ should be no longer than 255 characters", "‘BBBBB.BBBB’ should be no longer than 255 characters"]}
|
||||
The message field contains the error message and you can use errors to detail every errors found.
|
||||
|
||||
In the samples you provided, all returned fields are not set. For example, signature is never set. Of course it’s not a problem but I think it would be a good idea to have at least a result with all fields set so i could implement all the unit test cases.
|
||||
I have the same comment for “archive” and “signature” fiedls in Currency-pair information.
|
||||
I have the same comment for “minrate” and “maxrate” parameters in Current exchange rate and nonce in result.
|
||||
|
||||
“digits - The type of digits to use for the quote currency's numbers. "arabic" should be used for common 0-9 digits.” Don’t you think we should provide the list of supported digits ?
|
||||
|
||||
**Things I don’t understand.**
|
||||
I don’t understand what means “XBTUSD-ver4” ? I don’t see what it means.
|
||||
“Currency-pair information \ symbol : Any positive or negative symbols must be included in this prefix/suffix” I don’t understand this rule. Can you explain it more please ?
|
||||
“grouping” : can you provide more informations about how it works ? I don’t understand if it’s only 3 fields or if you can have more ?
|
Loading…
x
Reference in New Issue
Block a user