bitcoin/bips
1
0 Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2026-10-19 19:29:18 +00:00
Code Issues Releases Wiki Activity
4,674 Commits 1 Branch 0 Tags
dfe0895d414728a5bb45a5b44e547e2787f71c91
Commit Graph
4674 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
andrewtoth 5235781ea5 Add missing closing parenthesis and comma 2020-01-19 14:47:33 -08:00
Hennadii Stepanov fe03882a72 Fix paragraph naming and typo 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 55a31518b9 Rephrase "previous design choice" to "list above" 2020-01-19 14:47:33 -08:00
stefanwouldgo 79c515eb9e grammar typo fix: inserted "be" 2020-01-19 14:47:33 -08:00
Jonas Nick 3e5a79af88 Rename is_y_square to is_negated in taproot signing 2020-01-19 14:47:33 -08:00
Dmitry Petukhov 7a434d4d76 Add missing dots that denote multiplication 
Throughout the document, elliptic curve multiplication is denoted with dots,
as in `d'⋅G` as opposed to `d'G`.
This is not the case in one place in the 'Default Signing' section,
and one place in 'Adaptor Signatures' section

Missing dots are added for consistency.
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 1661efc999 Add missing quote 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos e72fffa028 Fix typo in schnorr, footnote 2 2020-01-19 14:47:33 -08:00
Max Hillebrand 54384a5710 make clear it's script branch 
In this context we are talking about the script branch, not the Merkle tree branch, right? If so, then this should clear things up a little.
 2020-01-19 14:47:33 -08:00
Thomas Kerin 769a17b3b9 tapscript: fix minor typo 2020-01-19 14:47:33 -08:00
Jon Atack 28f67764ec bip-taproot: clarify bip-schnorr reference code 
- update the paragraph in question to more clearly convey that the helper
  functions, and not the Python3 example code, are from the bip-schnorr
  reference code

- add a link to the reference code in
  https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr/reference.py
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos daff462f9d Add links to unlinked BIPs 
Only first mention of each BIP is made into a link
 2020-01-19 14:47:33 -08:00
Adam Gibson 4f67ed25c7 Add clarification of semantics of 0x00 hash type 2020-01-19 14:47:33 -08:00
Hennadii Stepanov ba7dd57697 G refers to secp256k1 base point rather generator 2020-01-19 14:47:33 -08:00
Anthony b2aed3e3fe FIX: BIPs should be specified as lowercase to match filenames 2020-01-19 14:47:33 -08:00
Anthony 662361cc44 ADD: Require Schnorr and Taproot BIPs for Tapscript 
https://github.com/sipa/bips/pull/135#issuecomment-552754867
 2020-01-19 14:47:33 -08:00
Anthony 4bc42d0f00 ADD: Require Schnorr BIP for Taproot 
Per https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki:

"BIPs may have a Requires header, indicating the BIP numbers that this BIP depends on"
 2020-01-19 14:47:33 -08:00
Dev Random ac33640bf5 tweak 211 bytes text 2020-01-19 14:47:33 -08:00
Devrandom b80ebbf287 clarify 211 hash bytes and non-reuse of keys 2020-01-19 14:47:33 -08:00
Gregory Sanders 758be14a2b remind reader where [:] is defined 
in addition to `point`. This caused confusion for one reader who expected inclusive at end of range.
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 4e88d4fae7 Replace R with P in taproot_tweak_seckey 2020-01-19 14:47:33 -08:00
Gregory Sanders 43fbb03235 BIP16 has no relation to bip-taproot/tapscript 
Previously did.
 2020-01-19 14:47:33 -08:00
Agis Anastasopoulos b5eb53451f Fix typo 2020-01-19 14:47:33 -08:00
LaurentMT 32f364c85c Fxied typo in taproot_sign_script() 2020-01-19 14:47:33 -08:00
codeShark149 e9e23e474f Internal pubkey calculation fixed in taproot_tweak_pubkey() 2020-01-19 14:47:33 -08:00
Fabian Jahr 4774e4d1e8 Link design section of BIP Schnorr in Specification 2020-01-19 14:47:33 -08:00
Max Hillebrand 3d97967b97 fix: script spend, not key spend 
For the key spend the script tree depth is not revealed, it is only done for script spends. This sentence makes sense only for the script spend.
 2020-01-19 14:47:33 -08:00
Jonas Nick fe74ab65db Update test-vectors.csv 2020-01-19 14:47:33 -08:00
Jonas Nick c8281deec6 Fix point_from_bytes accepting out-of-range pubkeys and add test vector 2020-01-19 14:47:33 -08:00
Tim Ruffing 9b5ba158c1 improve rationale for key prefixing 2020-01-19 14:47:33 -08:00
Jonas Nick c9196eeef4 Fix typo in reference code comment 2020-01-19 14:47:33 -08:00
Jonas Nick 301fef36de Make more clear that signing function in test vectors generation code isn't intended to be used anywhere else 2020-01-19 14:47:33 -08:00
Jonas Nick a6d2d42aa2 Check infinity in is_positive 2020-01-19 14:47:33 -08:00
Jonas Nick 82129e720d Adjust test vector generation code to latest terminology 2020-01-19 14:47:33 -08:00
Jonas Nick fdf6e897d9 Fix test vector generation code after changing schnorrsig_sign api 2020-01-19 14:47:33 -08:00
Pieter Wuille ae7122822a Settle on notation: is_square(y), has_square_y(P) 2020-01-19 14:47:33 -08:00
Dmitry Petukhov 0f9ab0cec9 fix docstring in taproot_output_script 
the final "-None" line in the docstring of `taproot_output_script` example function was actually outside of the docstring
 2020-01-19 14:47:33 -08:00
Dmitry Petukhov d87c5c8801 use bytes() instead of b'' - avoid markdown issue 
Currently github markdown renders `b''` inside `<source>` tags incorrectly. This makes `h = b''` show as `h = b` and creates some confusion.
The issue can be avoided by using bytes() to create empty byte array
 2020-01-19 14:47:33 -08:00
Tim Ruffing 7c00346cf2 typos 2020-01-19 14:47:33 -08:00
Pieter Wuille dbbe690c8a Consistently mention resource limits in bip-tapscript 2020-01-19 14:47:33 -08:00
Pieter WuilleandTim Ruffing 9c1670f345 Update bip-schnorr.mediawiki 
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
 2020-01-19 14:47:33 -08:00
Pieter WuilleandTim Ruffing 83cebb5326 Update bip-schnorr.mediawiki 
Co-Authored-By: Tim Ruffing <tim@timruffing.de>
 2020-01-19 14:47:33 -08:00
Pieter Wuille 1695f073d3 Elaborate on default and alternative signing 2020-01-19 14:47:33 -08:00
Pieter Wuille fc0a4ef542 Explain why CMS is not turned into SUCCESSx 2020-01-19 14:47:33 -08:00
Pieter Wuille 2059b9e35a Address aj comments 2020-01-19 14:47:33 -08:00
Pieter Wuille 3595c30acd Improve section on alternatives to OP_CHECKMULTISIG 2020-01-19 14:47:33 -08:00
Tim Ruffing 09e3f637b5 Change reference for ECDSA proofs 
Refer to Manuel Fersch's dissertation for provable security of ECDSA. It's freely accessible and multiple results put well in context.
 2020-01-19 14:47:33 -08:00
Anthony Towns feffc4e34d annex is bit 0 of spend_type 2020-01-19 14:47:33 -08:00
Pieter Wuille 23c1c3ed8b More on key generation 2020-01-19 14:47:33 -08:00
Pieter Wuille 7a7ab111c9 Clarify interaction x-only keys with verification 2020-01-19 14:47:33 -08:00