1
0
mirror of https://github.com/bitcoin/bips.git synced 2026-02-23 15:38:22 +00:00
Commit Graph

37 Commits

Author SHA1 Message Date
kallewoof
bd943663d6 Merge pull request #1156 from rage-proof/patch-2
typo in bip-0078
2021-08-31 21:21:57 +09:00
kallewoof
407d1178f3 Merge pull request #1171 from NicolasDorier/woieuq
[BIP78] Fix client implementation when there is output substitution
2021-08-31 19:50:37 +09:00
nicolas.dorier
d8db3d7608 [BIP78] Fix client implementation when there is output substitution 2021-08-31 15:48:16 +09:00
rage-proof
ec52492034 typo in bip-0078
This is a transaction with inputs P2SH-P2WPKH 
1. P2SH-P2WPKH is defined as type in this doc and the other type not
2. the RedeemScript(0 c78a45725355828d5658074dd5260d5fcb698530) consists of 0 + <20 bytes> and indicates therefore P2WPKH-Type. https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#P2WPKH_nested_in_BIP16_P2SH
2021-08-17 01:08:10 +02:00
Nicolas Dorier
1945eda0c2 [BIP78] Recommended fee rate estimation for P2TR
Non-Witness: 

Outpoint size = 32+4
Sequence size = 4
ScriptSig VarInt Size= 1

Witness: 

WitScript VarInt Size= 1
Then script itself: 65 signature size + 1 byte of push opcode

`(32 + 4 + 4 + 1) + (65+1+1)/4=57.75`, rounded up `58`.

We assume 65 of signature size rather than 64, since we can't assume the sighash to be `Default`.
2021-08-05 15:49:41 +09:00
kallewoof
65529b12bb Merge pull request #1082 from molnard/patch-1
Fix word duplication
2021-06-15 15:49:20 +09:00
kallewoof
127cdc3cda Merge pull request #1027 from rage-proof/patch-1
BIP-0078: fix typo
2021-06-15 15:49:06 +09:00
Dávid Molnár
38d2454210 Fix word duplication 2021-03-09 09:09:52 +01:00
rage-proof
55d37134cf Update bip-0078.mediawiki
the payjoin proposal has more inputs
2020-10-29 23:58:50 +01:00
Adam Gibson
1fbcd28584 update Joinmarket BIP78 status 2020-10-18 13:37:50 +01:00
kiminuo
a4fd5cc8ad Update bip-0078.mediawiki
Fix a few links.
2020-07-19 22:51:06 +02:00
nicolas.dorier
a76f5e4335 Clarify test vector 2020-06-23 17:46:18 +09:00
nicolas.dorier
b0be77f99e Removing non-sense paragraph 2020-06-22 11:06:57 +09:00
nicolas.dorier
e6418e5a76 Fix missing word 2020-06-22 10:58:40 +09:00
nicolas.dorier
5e4cc6d812 Fix grammar, additional note on ability to increase output of the receiver 2020-06-22 10:56:22 +09:00
nicolas.dorier
feac3d0035 Update special thanks 2020-06-19 16:12:29 +09:00
nicolas.dorier
c449c019f6 Do not allow decrease in absolute fee 2020-06-19 16:06:19 +09:00
nicolas.dorier
549107933c Allow outputs to be increased 2020-06-19 15:19:22 +09:00
nicolas.dorier
bd97400743 Introduce pjos=0 2020-06-19 15:00:19 +09:00
nicolas.dorier
e2778babfb additional comments 2020-06-19 14:31:19 +09:00
nicolas.dorier
6d4b491b31 Simplify sender's implementation, fix typos 2020-06-19 14:26:51 +09:00
nicolas.dorier
93c655a149 Fix typo 2020-06-19 13:24:59 +09:00
nicolas.dorier
3a16c24f5e Additional note for HW 2020-06-19 13:23:37 +09:00
nicolas.dorier
7803bf8335 Reformat the check list for sender 2020-06-19 13:17:34 +09:00
nicolas.dorier
a3fbc6c620 Do not crash reference implementation if there is no address in the bip21 2020-06-18 11:04:59 +09:00
nicolas.dorier
a2a085cdb4 Add disableoutputsubstitution= optional parameter 2020-06-18 10:11:20 +09:00
nicolas.dorier
63aa576fac Update from RHavar remarks 2020-06-18 09:59:44 +09:00
nicolas.dorier
3485af708c Add reference implementation 2020-06-18 00:12:29 +09:00
nicolas.dorier
ea7562fc90 Fix old error code 2020-06-17 21:51:09 +09:00
nicolas.dorier
3fc7032ec3 Fix some formatting 2020-06-17 16:20:38 +09:00
nicolas.dorier
f36ca8f43d Update recommendation for receiver and sender 2020-06-17 16:15:53 +09:00
nicolas.dorier
a07fef5797 Add fee output section 2020-06-17 16:09:35 +09:00
nicolas.dorier
d72e27535e [MoveOnly] Move optional parameters at the beginning 2020-06-17 15:06:28 +09:00
nicolas.dorier
801cc71114 Update PSBT invariants 2020-06-16 14:27:09 +09:00
nicolas.dorier
631d8e65cd Simplifies sender recommendation 2020-06-16 14:17:36 +09:00
nicolas.dorier
d13c784671 Remove parts refering to RBF, add recommendations for maxadditionalfeecontribution 2020-06-16 13:39:27 +09:00
nicolas.dorier
73a4d7c4ba Rename to BIP78 2020-06-16 12:38:11 +09:00