bitcoin/bips
1
0 Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2026-10-19 19:29:18 +00:00
Code Issues Releases Wiki Activity
4,640 Commits 1 Branch 0 Tags
a4668bb203c4dd36f1d35aec04f7c2bc0d242d7b
Commit Graph
4640 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Orfeas Stefanos Thyfronitis Litos 773133fb4a Typo: script signature max bytes unhashed are 247 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos da3837639f Typo: max bytes hashed for sig is 210 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 37bf225ea4 Replace BIP66 link with BIP146 
BIP66 does not mention the inherent ECDSA malleability, but BIP146 does
 2020-01-19 14:47:33 -08:00
stefanwouldgo 8baf6f5952 fix singular/plural ambiguity 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos a65101ff6d Replace signing with signature before validation 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 79738f2410 Link to proof sketch of security of implicit Y 
Thanks to @ajtowns for providing the link
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos ca472ed663 Mention that miners could malleate signatures 2020-01-19 14:47:33 -08:00
Orfeas Litos 5918b4666c Mention hash_type malleability would change wtxid 2020-01-19 14:47:33 -08:00
Jonas Nick 66e2931de2 Clarify bip-taproot digest difference to bip143 regarding sub-hashes 2020-01-19 14:47:33 -08:00
Jonas Nick 1f5bdb304e Improve clarity of footnotes for lift_x 2020-01-19 14:47:33 -08:00
Jonas Nick 708aeadf85 Replace references to Euler's criterion with Legendre symbol in bip-schnorr 2020-01-19 14:47:33 -08:00
Jonas Nick 5a25adc490 Fix bip-schnorr footnote 7 by specifying that we're referring to P's y coordinate and not some undefined 'x' 2020-01-19 14:47:33 -08:00
Kalle Rosenbaum 98983e177f Fix @jonasnick's comment 2020-01-19 14:47:33 -08:00
Kalle Rosenbaum 18d1774d81 Nits 2020-01-19 14:47:33 -08:00
Orfeas Litos 2aa865c33e Replace "both are not" with "neither is" 2020-01-19 14:47:33 -08:00
andrewtoth c7175e8005 Update bip-tapscript.mediawiki 2020-01-19 14:47:33 -08:00
andrewtoth 5235781ea5 Add missing closing parenthesis and comma 2020-01-19 14:47:33 -08:00
Hennadii Stepanov fe03882a72 Fix paragraph naming and typo 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 55a31518b9 Rephrase "previous design choice" to "list above" 2020-01-19 14:47:33 -08:00
stefanwouldgo 79c515eb9e grammar typo fix: inserted "be" 2020-01-19 14:47:33 -08:00
Jonas Nick 3e5a79af88 Rename is_y_square to is_negated in taproot signing 2020-01-19 14:47:33 -08:00
Dmitry Petukhov 7a434d4d76 Add missing dots that denote multiplication 
Throughout the document, elliptic curve multiplication is denoted with dots,
as in `d'⋅G` as opposed to `d'G`.
This is not the case in one place in the 'Default Signing' section,
and one place in 'Adaptor Signatures' section

Missing dots are added for consistency.
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 1661efc999 Add missing quote 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos e72fffa028 Fix typo in schnorr, footnote 2 2020-01-19 14:47:33 -08:00
Max Hillebrand 54384a5710 make clear it's script branch 
In this context we are talking about the script branch, not the Merkle tree branch, right? If so, then this should clear things up a little.
 2020-01-19 14:47:33 -08:00
Thomas Kerin 769a17b3b9 tapscript: fix minor typo 2020-01-19 14:47:33 -08:00
Jon Atack 28f67764ec bip-taproot: clarify bip-schnorr reference code 
- update the paragraph in question to more clearly convey that the helper
  functions, and not the Python3 example code, are from the bip-schnorr
  reference code

- add a link to the reference code in
  https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr/reference.py
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos daff462f9d Add links to unlinked BIPs 
Only first mention of each BIP is made into a link
 2020-01-19 14:47:33 -08:00
Adam Gibson 4f67ed25c7 Add clarification of semantics of 0x00 hash type 2020-01-19 14:47:33 -08:00
Hennadii Stepanov ba7dd57697 G refers to secp256k1 base point rather generator 2020-01-19 14:47:33 -08:00
Anthony b2aed3e3fe FIX: BIPs should be specified as lowercase to match filenames 2020-01-19 14:47:33 -08:00
Anthony 662361cc44 ADD: Require Schnorr and Taproot BIPs for Tapscript 
https://github.com/sipa/bips/pull/135#issuecomment-552754867
 2020-01-19 14:47:33 -08:00
Anthony 4bc42d0f00 ADD: Require Schnorr BIP for Taproot 
Per https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki:

"BIPs may have a Requires header, indicating the BIP numbers that this BIP depends on"
 2020-01-19 14:47:33 -08:00
Dev Random ac33640bf5 tweak 211 bytes text 2020-01-19 14:47:33 -08:00
Devrandom b80ebbf287 clarify 211 hash bytes and non-reuse of keys 2020-01-19 14:47:33 -08:00
Gregory Sanders 758be14a2b remind reader where [:] is defined 
in addition to `point`. This caused confusion for one reader who expected inclusive at end of range.
 2020-01-19 14:47:33 -08:00
Orfeas Stefanos Thyfronitis Litos 4e88d4fae7 Replace R with P in taproot_tweak_seckey 2020-01-19 14:47:33 -08:00
Gregory Sanders 43fbb03235 BIP16 has no relation to bip-taproot/tapscript 
Previously did.
 2020-01-19 14:47:33 -08:00
Agis Anastasopoulos b5eb53451f Fix typo 2020-01-19 14:47:33 -08:00
LaurentMT 32f364c85c Fxied typo in taproot_sign_script() 2020-01-19 14:47:33 -08:00
codeShark149 e9e23e474f Internal pubkey calculation fixed in taproot_tweak_pubkey() 2020-01-19 14:47:33 -08:00
Fabian Jahr 4774e4d1e8 Link design section of BIP Schnorr in Specification 2020-01-19 14:47:33 -08:00
Max Hillebrand 3d97967b97 fix: script spend, not key spend 
For the key spend the script tree depth is not revealed, it is only done for script spends. This sentence makes sense only for the script spend.
 2020-01-19 14:47:33 -08:00
Jonas Nick fe74ab65db Update test-vectors.csv 2020-01-19 14:47:33 -08:00
Jonas Nick c8281deec6 Fix point_from_bytes accepting out-of-range pubkeys and add test vector 2020-01-19 14:47:33 -08:00
Tim Ruffing 9b5ba158c1 improve rationale for key prefixing 2020-01-19 14:47:33 -08:00
Jonas Nick c9196eeef4 Fix typo in reference code comment 2020-01-19 14:47:33 -08:00
Jonas Nick 301fef36de Make more clear that signing function in test vectors generation code isn't intended to be used anywhere else 2020-01-19 14:47:33 -08:00
Jonas Nick a6d2d42aa2 Check infinity in is_positive 2020-01-19 14:47:33 -08:00
Jonas Nick 82129e720d Adjust test vector generation code to latest terminology 2020-01-19 14:47:33 -08:00