Commit Graph
4947 Commits
Author SHA1 Message Date
Jonas Nick 7cdaa7a183 bip-0327: isolate the range check in a PartialSigVerify test vector
The PartialSigVerify test vector with the partial signature n fails the
verification equation even without the range check. So it does not
detect implementations that omit the range check or that check s > n
instead of s >= n. Change the pubnonces of the test vector such that the
partial signature 0 is valid, keeping the aggregate nonce. Since
n*G = 0*G, the partial signature n then satisfies the verification
equation, and only the range check rejects it. The previous version of
the test vector detects no mistake that the new version does not detect,
so it is replaced rather than kept.

gen_vectors_helper.py computes the new pubnonces.
2026-11-16 09:29:52 +00:00
Jonas Nick b7557f897a bip-0327: add a NonceGen test vector without repeated bytes
In the previous NonceGen test vectors, every rand_ consists of the byte
0F repeated 32 times, every present sk of the byte 02 repeated 32 times,
and every pk has an even Y coordinate. Add a test vector whose rand_ and
sk are not a repeated byte and whose pk has an odd Y coordinate. It
detects implementations that reverse the byte order of rand_ or sk, that
replace the first byte of pk with 02, or that use only the first byte of
rand_.

With the last mistake, two NonceGen invocations with the same other
arguments return the same secnonce with probability 1/256, although the
BIP requires that Sign is never executed twice with the same secnonce.
2026-11-16 09:29:52 +00:00
Jonas Nick 17affe2861 bip-0327: add test vectors for a public key and its negation
A public key and its negation have the same X coordinate, and their
compressed encodings differ only in the first byte. Add a Sign test
vector with a secnonce generated for the negation of the signer's public
key, and a KeyAgg test vector with a public key and its negation. They
detect implementations that compare public keys only by their X
coordinates, in the public key check of Sign, in GetSecondKey, or in
KeyAggCoeffInternal. Distinct public keys in the previous test vectors
also have distinct X coordinates.

The public key check in Sign ensures that the secret key provided to
Sign is determined when NonceGen is invoked. Comparing only X
coordinates determines the secret key only up to negation.
2026-11-16 09:29:52 +00:00
Jonas Nick 0ba8e56a02 bip-0327: add test vectors for k2' >= n and 256-byte messages
Add Sign test vectors with k2' = n and k2' = n + 1. Together they
detect implementations that check the secret nonce values only for
zero, that check k2' <= n instead of k2' < n, or that reduce k2' mod n
before checking it for zero. No single value detects the last two:
among values of at least n, checking k2' <= n accepts only n, while
reducing first rejects only n. For k2' = n, the optional correctness
check at the end of Sign also fails, because k2'*G is infinity, so this
vector detects the k2' <= n mistake only in implementations that omit
that check.

Add NonceGen and DeterministicSign test vectors with a 256-byte
message. They detect implementations that encode only the low byte of
len(m); the longest message in the previous test vectors has 38 bytes.
DeterministicSign needs its own vector because it encodes len(m)
separately.
2026-11-16 09:29:52 +00:00
Jonas NickandFerdinando Ametrano 6e8dafd3c3 bip-0327: add test vectors and a README that describes them
Add Sign test vectors for a secnonce with k2' = 0 and for a secnonce
generated for a different public key. No previous test vector detected
an implementation that checks only k1', or one that omits the public
key check added in 1.0.0-rc.2.

Add test vectors for a single signer, a 4-byte extra_in, and plain and
x-only tweaks in DeterministicSign. They detect implementations that
reject a single signer, encode the length of extra_in as 32 whenever
extra_in is present, or treat every tweak in DeterministicSign as
x-only.

Add a README to the vectors directory. It states that the test vectors
only contain inputs whose length and number meet the specification of
BIP327, and that a test vector should only be added if it detects a
plausible implementation mistake that the other test vectors do not
detect. Name that mistake in the comment of each added test vector.

Co-authored-by: Ferdinando Ametrano <ferdinando@ametrano.net>
2026-11-16 09:29:52 +00:00
Jon Atack a0c977f375 Merge pull request #2346 from fjahr/95port
BIP95: Change default P2P port to 18353
2026-11-04 10:26:40 -06:00
Fabian Jahr ab3f20041f BIP95: Change default P2P port to 18353 2026-11-05 00:38:08 +09:00
Jon Atack a763725aa4 Merge pull request #2345 from MrHodlX/bip373-output-vector
BIP373: replace the duplicated x-only output participant vector
2026-11-04 09:15:00 -06:00
MrHodlX e315654e75 BIP373: replace the duplicated x-only output participant vector 2026-11-04 08:43:47 -05:00
Jon Atack 61ff3f1361 Merge pull request #2311 from jonatack/2026-09-bip375-reference-implementation
bip375: replace stale TODO with reference implementation
2026-11-03 21:42:17 -06:00
Jon Atack ea875b262c Merge pull request #2343 from achow101/375-deputize
375: Add deputy
2026-11-03 21:38:48 -06:00
Jon Atack d5ca385c8e Merge pull request #2212 from fjahr/cisa
BIP460: CISA for Taproot Key Path Spends
2026-11-03 21:33:06 -06:00
Ava Chow e4e02e14cf 375: Deputize macgyver 2026-11-03 19:28:09 -08:00
Fabian Jahr 3886890d7e bip-0460: Add entry to the README index 2026-11-04 11:01:32 +09:00
Fabian Jahr 6ee9ac116e bip-0460: Add CISA for Taproot key path spends 2026-11-04 11:00:26 +09:00
Fabian Jahr 55167425a1 bip-0460: Add vendored BIP 459 reference code 2026-11-04 11:00:26 +09:00
Fabian Jahr 4a801194d5 bip-0460: Add vendored BIP 458 reference code 2026-11-04 11:00:26 +09:00
Fabian Jahr 2106e90394 bip-0460: Add vendored secp256k1lab library 2026-11-04 11:00:25 +09:00
Liam Gilligan 5bbeeae962 BIP461: add test vectors and reference implementation (#2328)
All vectors were tested against libsecp256k1, and
all verification vectors were checked against OpenSSL.
A check was also added to the `verify` specification
to reject pubkeys with x or y coordinates greater than
or equal to `p`.
2026-11-03 14:23:55 -08:00
Jon Atack 21bfd24d6e Merge pull request #2210 from fjahr/fullagg
BIP459: DahLIAS fully aggregated signatures for secp256k1
2026-11-03 12:18:06 -06:00
Fabian Jahr 960e863e57 BIP459: Add entry to the README index 2026-11-03 21:40:46 +09:00
Fabian Jahr f3d1668891 BIP459: Add DahLIAS fully aggregated signatures for secp256k1 2026-11-03 21:39:57 +09:00
Fabian Jahr bd478d5087 BIP459: Add vendored secp256k1lab library
Add a vendored copy of the secp256k1lab library (master branch, commit
a265da139aea27386085a2a8760f8698e1bda64e) that the full-aggregation
reference implementation and test vector scripts depend on.
2026-11-03 21:39:56 +09:00
Jon Atack ada341963a Merge pull request #2205 from fjahr/halfagg
BIP458: Half-Aggregation of BIP 340 Signatures
2026-11-02 10:59:00 -06:00
Fabian Jahr fe7836100e bip-0458: Add entry to the README index 2026-11-01 07:56:15 +01:00
Fabian Jahr 2d439430b1 bip-0458: Add half-aggregation of BIP 340 signatures 2026-11-01 07:56:15 +01:00
Jon Atack 5aadddb511 Merge pull request #2337 from Eunovo/bip352-key-spend-annex-vector
BIP352: add taproot key-path spend with annex vector
2026-10-26 20:41:58 -06:00
Jon Atack f428b62526 Merge pull request #2335 from ViniciusCestarii/bip-374-new-test-vectors
bip374: add new test vectors checking for boundaries
2026-10-26 20:39:29 -06:00
Novo f827c44063 BIP352: add changelog for 1.1.2
Add key-spend with annex test vector log
2026-10-26 14:30:46 +01:00
ViniciusCestarii afaa856630 bip374: add new test vectors checking for boundaries 2026-10-26 07:17:45 -03:00
Novo 3c68d3f3a1 BIP352: add taproot key-path spend with annex vector
Add a BIP-352 test vector where a taproot input is spent via the key path with an annex (2-item witness). The annex must be stripped before deciding between key-path and script-path spends, so the input is still eligible and all expected values match the plain key-path case.

The annex is 0x50 followed by the BIP341 NUMS point H, so an implementation that fails to strip it reads it as a control block with the NUMS internal key and wrongly skips the input.
2026-10-25 17:20:33 +01:00
pythcoiner 100ba872c8 Add BIP139: Wallet Metadata Backup Format (#2130)
* bip139: wallet metadata format

* bip139: add the Version header to the preamble

* bip139: keep a single psbts field and fix the spend status link

* bip139: fold the version section and bip field into the version value

* bip139: capitalize Bitcoin Core and clarify the change_descriptor note

* bip139: replace the three account birth time fields with birth_block

* bip139: drop descriptor_id and change_descriptor_id

* bip139: drop field aliases, keeping name and labels

* bip139: restrict descriptor and change_descriptor to a string

* bip139: make version, type, descriptor, key, txid, outpoint and tweak mandatory

* bip139: move field definitions to a companion registry

* bip139: add the wallet survey behind these decisions

* bip139: replace the wallet description field with a backup note

* bip139: add the backup date field

* bip139: add the account gap_limit field

* bip139: add the multi_bip380 account type

* bip139: give the bip352_labels range an explicit encoding

* bip139: add a general coin object

* bip139: move signers above the account

* bip139: add signer modality and device records

* bip139: add bip85 application and index

* bip139: add Bitkey to the wallet survey

* bip139: state how to derive birth_block from a creation date

* bip139: define the timestamp format once

* bip139: rename the transaction time field to block_time

* bip139: keep last_height on the account only

* bip139: state that type names the descriptor language

* bip139: drop output_type, the descriptor already states it

* bip139: replace the account active flag with a status enum

* bip139: add mutinynet and scope a backup to one network

* bip139: record that the label gap belongs to BIP-329

* bip139: record that proprietary needs no change

* bip139: make the survey annex-ready

* bip139: record that mainnet mnemonics stay out of scope

* bip139: reword the mnemonic evidence heading

* bip139: correct the birth_block evidence, Sparrow stores a height

* bip139: type and descriptor fit every surveyed wallet

* bip139: correct the addr descriptor solvability note

* bip139: re-assess every partial score against fillability

* bip139: store psbts once at wallet level, reference them per account

* bip139: store transactions once at wallet level, reference them per account

* bip139: txid is the transaction map key, not a field

* bip139: refresh the matrix after the fillability re-assessment

* bip139: electrum holds no bip39 mnemonic at all

* bip139: sp_output.label has no constituency

* bip139: collapse the survey to a two-value scale

* bip139: drop the obsolete partial-score analysis

* bip139: size the matrix field column from the data

* bip139: cut the survey down to the table and its results

* bip139: recompute liana compat against the current draft

* bip139: correct the liana breaking-change count

* bip139: make network mandatory

* bip139: network no longer breaks liana on import

* bip139: render wallet fields as a wrapped table

* bip139: render account fields as a wrapped table

* bip139: render every field section as a wrapped table

* bip139: the registry is part of the bip, not a reference to it

* bip139: drop the registration process from the registry intro

* bip139: put field rationale in the cell, not below the table

* bip139: keep code spans whole when wrapping cells

* bip139: render field tables as preformatted blocks

* bip139: drop link definitions the tables no longer use

* bip139: use a bordered grid for the field tables

* bip139: give birth_block an estimation formula and drop the enum underscore

* bip139: merge silent payment outputs into the coin object

* bip139: restore spend_status and give the sp label scalar a home

* bip139: register the transaction fee field

* bip139: rebuild the survey matrix against the current field set

* bip139: drop survey findings the draft now addresses

* bip139: bar passphrase-protected seeds from bip39_mnemonic

* bip139: record the missing-field decisions in the survey

* bip139: cut the survey down to its revision list and matrix

* bip139: reword the survey as a wallet to field mapping

* bip139: reference the wallet support annex from the spec

* bip139: list the mandatory fields in the registry tables

* bip139: point the spec at the registry as the complete field list

* bip139: spell out mandatory and optional in the registry req column

* bip139: mark only the optional fields in the registry tables

* bip139: retitle and reframe the BIP around moving between wallets

* bip139: call the artefact an export throughout

* bip139: scope the mnemonic advice to exports kept as backups

* bip139: say that most metadata cannot be recovered from the chain

* bip139: clarify account and signer metadata fields

* bip139: cut the registry cells back to the field description

* bip139: reword the registry field descriptions

* bip139: give the device record its own registry table

* bip139: keep an unknown enum value from failing the import

* bip139: define the device transports field

* bip139: point the devices row at the device object

* bip139: backup -> export in README

* bip139: clarify export fields and remove survey annex

* bip139: Drop Version header in absence of Changelog
2026-10-24 08:11:13 -07:00
Jon Atack 93f161194f Merge pull request #2338 from fengxueweilai/my_feature
scripts: isolate diffcheck temporary files
2026-10-23 17:14:06 -06:00
Jon Atack 1fec65e55b Merge pull request #2336 from fametrano/bip322-taproot-upgradeable
BIP-0322: name taproot upgrade mechanisms in the upgradeable rules
2026-10-23 14:49:47 -06:00
Ferdinando Ametrano 99ece780c8 BIP-0322: name taproot upgrade mechanisms in the upgradeable rules
The upgradeable rules list the to_sign version, NOPs reserved for
upgrades and segwit versions above 1. BIP341 and BIP342 also reserve
unknown leaf versions, OP_SUCCESSx, unknown public key types and the
annex for upgrades. A verifier that follows the BIP322 text calls a
signature using any of them valid. Name them, so that these give the
inconclusive state like the other upgrade mechanisms.

Bump the version to 2.1.0 and add a changelog entry.
Add 342 to Requires.
2026-10-23 17:05:38 +02:00
fengxueweilai 9b1a7ef537 fix(scripts): isolate diffcheck temporary files
Signed-off-by: fengxueweilai <fengxueweilai@outlook.com>
2026-10-23 17:49:57 +08:00
Jon Atack c0c5aea41e Merge pull request #2334 from ViniciusCestarii/bip-0374-wording-nits 2026-10-21 22:14:03 -06:00
ViniciusCestarii af1e6e27c7 bip374: clarify DLEQ verification wording 2026-10-20 14:03:39 -03:00
Fabian Jahr 1eb496599c bip-0458: Add vendored secp256k1lab library
Add a vendored copy of the secp256k1lab library (master branch, commit
a265da139aea27386085a2a8760f8698e1bda64e) that the half-aggregation
reference implementation and test vector scripts depend on.
2026-10-20 17:53:54 +02:00
ViniciusCestarii e80c8549a1 bip374: justify G as input with a better reasoning 2026-10-20 10:13:45 -03:00
Murch 130b8e0fa7 Merge pull request #2332 from jonatack/2026-10-bip3-update-discussion-headers-to-bip3
bip3: update discussion headers to bip3 format
2026-10-19 14:21:00 -07:00
Jon AtackandAnthony Towns ef5b6ba9d0 bip3: update discussion headers to bip3 format
Co-Authored-By: Anthony Towns <aj@erisian.com.au>
2026-10-19 15:09:00 -06:00
Antoine Poinsot 927b6de991 Address some wording nits in BIP 54 (#2313) 2026-10-02 06:27:57 -07:00
Jon Atack 3a10b5b5f0 Merge pull request #2308 from FlashWayne/bip54-vectors-readme 2026-09-28 08:24:34 -07:00
FlashW b58f8ef865 bip54: describe the tree format of the timestamp test vectors
Since 977300d timestamps.json is a single JSON object whose children are
nested recursively in extensions arrays, with valid and comment only on the
leaves, but the README still described a flat array of objects with a
header_chain entry.
2026-09-28 18:56:05 +04:00
Jon Atack 7d92f13b83 bip375: replace TODO with reference implementation 2026-09-27 23:32:27 -06:00
Jon Atack 4f979daf78 Merge pull request #2286 from wangjingshuiku/master
BIP375: validate PSBT_OUT_SP_V0_LABEL length
2026-09-27 10:55:17 -07:00
Jon Atack 124324eef1 BIP375: add 0.1.2 changelog for LABEL length validation 2026-09-27 11:51:59 -06:00
Jon Atack 02bebeb5ef Merge pull request #2306 from 0xShadowX/bip98-example-proof
bip98: fix the third SKIP hash in the example proof
2026-09-25 11:50:40 -07:00
Jon Atack f4353baf2c Merge pull request #2304 from Bruce039/bip375-sync-dleq
bip375: sync vendored DLEQ code with BIP-374
2026-09-25 11:10:59 -07:00