1
0
mirror of https://github.com/bitcoin/bips.git synced 2026-08-24 18:47:19 +00:00
Commit Graph

7 Commits

Author SHA1 Message Date
Jon Atack
e7263a4cfe Merge pull request #2223 from jeanpablojp/bip360-fix-size-claim
bip360: correct the claimed P2MR witness size saving
2026-08-02 21:03:44 -07:00
JP
33202403b3 bip360: correct the claimed P2MR witness size saving
The Transaction Size and Fees section says a P2MR witness is always 32
bytes smaller than an equivalent P2TR script path spend witness. The
control blocks are 1 + 32*m and 33 + 32*m bytes, each serialised with
a compact size prefix, so at m = 7 the P2TR control block is 257 bytes
and takes a 3-byte prefix while the P2MR one is 225 bytes and takes 1.
The saving there is 34 bytes, not 32. Every other depth up to 128
gives 32.

The section already footnotes this boundary for the P2MR side a few
paragraphs earlier.
2026-07-28 15:22:24 +01:00
JP
19f5a224ee bip360: fix stale links, version header and a size example label
- The Test Vectors section linked P2MR_construction.json; the file on
  disk is lowercase p2mr_construction.json, so the link 404s.
- The same section still linked the rust implementation under
  bip-0360/ref-impl/rust, which #2202 moved out of the repository.
- The header said Version: 0.12.0 while the changelog's latest entry
  is 0.12.1.
- The 135-byte depth-1 witness example labeled the merkle path
  "(empty)" while counting 32 bytes for it (a depth-1 path has one
  32-byte node).
2026-07-27 21:44:00 +01:00
Jon Atack
0fdf6ffdbb bip360: add changelog entry for PR2202 2026-07-24 16:22:20 -06:00
conduition
6740c533e8 bip360: depth-zero script trees should be anyone-can-spend (#2198)
* bip360: depth zero trees should be anyone-can-spend

* bip360: update changelog and bump version to 0.12.0
2026-06-18 18:14:23 -07:00
boskodev790
1609a4f576 Fix broken BIP 3 reference in bip-0347 and bip-0360 changelogs
Both BIPs added a changelog entry on 2026-01-23 referencing the updated
BIP Process meta-BIP with the wrong form:

- bip-0360.mediawiki:404 rendered `[[bip-0003.mediawiki|BIP 003]]`, but
  the actual file is `bip-0003.md`. The MediaWiki link therefore failed
  to resolve to the BIP 3 page on the bitcoin/bips GitHub wiki render
  and on the bips.dev / bip339 style mirrors — readers of the bip-0360
  changelog landed on a 404.

- bip-0347.mediawiki:170 wrote the same reference as bare text
  `BIP 003` with no link at all, so readers of bip-0347 had no way to
  navigate to the BIP 3 they were meant to follow.

Rewrite both entries to use the canonical form `[[bip-0003.md|BIP 3]]`:

- `bip-0003.md` matches the actual filename.
- `BIP 3` matches the display text convention the README (line 40) and
  every other BIP in this repository already use when linking to
  bip-0003 — "BIP 003" with the three-digit zero-pad appears nowhere
  else in the repo for any BIP and is not part of the display style
  described in BIP 2.

Also drops the trailing whitespace on the bip-0347 line while we are
there (the `typos` CI tolerates it but it is inconsistent with every
other line in the same changelog block).
2026-04-23 04:03:40 +02:00
Hunter Beast
eae7d9fc57 BIP360: Pay to Merkle Root (P2MR) (#1670)
Review comments and assistance by:
  Armin Sabouri <armins88@gmail.com>
  D++ <82842780+dplusplus1024@users.noreply.github.com>
  Jameson Lopp <jameson.lopp@gmail.com>
  jbride <jbride2001@yahoo.com>
  Joey Yandle <xoloki@gmail.com>
  Jon Atack <jon@atack.com>
  Jonas Nick <jonasd.nick@gmail.com>
  Kyle Crews <kylecrews@Kyles-Mac-Studio.local>
  Mark "Murch" Erhardt <murch@murch.one>
  notmike-5 <notmike-5@users.noreply.github.com>
  Vojtěch Strnad <43024885+vostrnad@users.noreply.github.com>

Co-authored-by: Ethan Heilman <ethan.r.heilman@gmail.com>
Co-authored-by: Isabel Foxen Duke <110147802+Isabelfoxenduke@users.noreply.github.com>
2026-02-11 13:01:47 -08:00