Merge pull request #3209 from mempool/nymkappa/wipe-cache-always

Wipe nodejs backend cache for any mining pool change - Update pools before loading disk cache

backend/src/api/pools-parser.ts

@@ -39,6 +39,10 @@ class PoolsParser {
    * @param pools 
    */
   public async migratePoolsJson(): Promise<void> {
+    // We also need to wipe the backend cache to make sure we don't serve blocks with
+    // the wrong mining pool (usually happen with unknown blocks)
+    diskCache.wipeCache();
+
     await this.$insertUnknownPool();
 
     for (const pool of this.miningPools) {
@@ -142,10 +146,6 @@ class PoolsParser {
       WHERE pool_id = ?`,
       [pool.id]
     );
-
-    // We also need to wipe the backend cache to make sure we don't serve blocks with
-    // the wrong mining pool (usually happen with unknown blocks)
-    diskCache.wipeCache();
   }
 
   private async $deleteUnknownBlocks(): Promise<void> {
@@ -156,10 +156,6 @@ class PoolsParser {
       WHERE pool_id = ? AND height >= 130635`,
       [unknownPool[0].id]
     );
-
-    // We also need to wipe the backend cache to make sure we don't serve blocks with
-    // the wrong mining pool (usually happen with unknown blocks)
-    diskCache.wipeCache();
   }
 }
 

backend/src/index.ts

@@ -113,6 +113,7 @@ class Server {
 
     this.setUpWebsocketHandling();
 
+    await poolsUpdater.updatePoolsJson(); // Needs to be done before loading the disk cache because we sometimes wipe it
     await syncAssets.syncAssets$();
     if (config.MEMPOOL.ENABLED) {
       diskCache.loadMempoolCache();
@@ -171,7 +172,6 @@ class Server {
           logger.debug(msg);
         }
       }
-      await poolsUpdater.updatePoolsJson();
       await blocks.$updateBlocks();
       await memPool.$updateMempool();
       indexer.$run();