Merge pull request #4204 from mempool/mononaut/unfurl-symlink-fallbacks
Use symlink to avoid duplicate unfurler fallback images
This commit is contained in:
		
						commit
						d8900d40c7
					
				| @ -251,7 +251,7 @@ class Server { | ||||
| 
 | ||||
|       if (!img) { | ||||
|         // send local fallback image file
 | ||||
|         res.sendFile(nodejsPath.join(__dirname, matchedRoute.fallbackFile)); | ||||
|         res.sendFile(nodejsPath.join(__dirname, matchedRoute.fallbackImg)); | ||||
|       } else { | ||||
|         res.contentType('image/png'); | ||||
|         res.send(img); | ||||
|  | ||||
							
								
								
									
										1
									
								
								unfurler/src/resources
									
									
									
									
									
										Symbolic link
									
								
							
							
						
						
									
										1
									
								
								unfurler/src/resources
									
									
									
									
									
										Symbolic link
									
								
							| @ -0,0 +1 @@ | ||||
| ../../frontend/src/resources | ||||
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 94 KiB | 
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 289 KiB | 
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 1.8 MiB | 
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 96 KiB | 
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 289 KiB | 
										
											Binary file not shown.
										
									
								
							| Before Width: | Height: | Size: 607 KiB | 
| @ -2,7 +2,6 @@ interface Match { | ||||
|   render: boolean; | ||||
|   title: string; | ||||
|   fallbackImg: string; | ||||
|   fallbackFile: string; | ||||
|   staticImg?: string; | ||||
|   networkMode: string; | ||||
| } | ||||
| @ -32,7 +31,6 @@ const routes = { | ||||
|   lightning: { | ||||
|     title: "Lightning", | ||||
|     fallbackImg: '/resources/previews/lightning.png', | ||||
|     fallbackFile: '/resources/img/lightning.png', | ||||
|     routes: { | ||||
|       node: { | ||||
|         render: true, | ||||
| @ -71,7 +69,6 @@ const routes = { | ||||
|   mining: { | ||||
|     title: "Mining", | ||||
|     fallbackImg: '/resources/previews/mining.png', | ||||
|     fallbackFile: '/resources/img/mining.png', | ||||
|     routes: { | ||||
|       pool: { | ||||
|         render: true, | ||||
| @ -87,14 +84,12 @@ const routes = { | ||||
| const networks = { | ||||
|   bitcoin: { | ||||
|     fallbackImg: '/resources/previews/dashboard.png', | ||||
|     fallbackFile: '/resources/img/dashboard.png', | ||||
|     routes: { | ||||
|       ...routes // all routes supported
 | ||||
|     } | ||||
|   }, | ||||
|   liquid: { | ||||
|     fallbackImg: '/resources/liquid/liquid-network-preview.png', | ||||
|     fallbackFile: '/resources/img/liquid', | ||||
|     routes: { // only block, address & tx routes supported
 | ||||
|       block: routes.block, | ||||
|       address: routes.address, | ||||
| @ -103,7 +98,6 @@ const networks = { | ||||
|   }, | ||||
|   bisq: { | ||||
|     fallbackImg: '/resources/bisq/bisq-markets-preview.png', | ||||
|     fallbackFile: '/resources/img/bisq.png', | ||||
|     routes: {} // no routes supported
 | ||||
|   } | ||||
| }; | ||||
| @ -113,7 +107,6 @@ export function matchRoute(network: string, path: string): Match { | ||||
|     render: false, | ||||
|     title: '', | ||||
|     fallbackImg: '', | ||||
|     fallbackFile: '', | ||||
|     networkMode: 'mainnet' | ||||
|   } | ||||
| 
 | ||||
| @ -128,7 +121,6 @@ export function matchRoute(network: string, path: string): Match { | ||||
| 
 | ||||
|   let route = networks[network] || networks.bitcoin; | ||||
|   match.fallbackImg = route.fallbackImg; | ||||
|   match.fallbackFile = route.fallbackFile; | ||||
| 
 | ||||
|   // traverse the route tree until we run out of route or tree, or hit a renderable match
 | ||||
|   while (!route.render && route.routes && parts.length && route.routes[parts[0]]) { | ||||
| @ -136,7 +128,6 @@ export function matchRoute(network: string, path: string): Match { | ||||
|     parts.shift(); | ||||
|     if (route.fallbackImg) { | ||||
|       match.fallbackImg = route.fallbackImg; | ||||
|       match.fallbackFile = route.fallbackFile; | ||||
|     } | ||||
|   } | ||||
| 
 | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user