Make sure exchange API response format is valid before using it

2022-12-01 12:05:23 +01:00
parent 2b411aad0a
commit a671bfc226
6 changed files with 33 additions and 6 deletions
--- a/backend/src/tasks/price-feeds/bitflyer-api.ts
+++ b/backend/src/tasks/price-feeds/bitflyer-api.ts
@@ -13,7 +13,11 @@ class BitflyerApi implements PriceFeed {

  public async $fetchPrice(currency): Promise<number> {
    const response = await query(this.url + currency);
-    return response ? parseInt(response['ltp'], 10) : -1;
+    if (response && response['ltp']) {
+      return parseInt(response['ltp'], 10);
+    } else {
+      return -1;
+    }
  }

  public async $fetchRecentPrice(currencies: string[], type: 'hour' | 'day'): Promise<PriceHistory> {