machankura/mempool
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix response codes for various error states

Browse Source
This commit is contained in:
junderw 2022-09-10 16:03:31 +09:00
parent 90db8c15f2
commit 9b1fc1e000
No known key found for this signature in database
GPG Key ID: B256185D3A971908
1 changed files with 34 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
backend/src/api/bitcoin/bitcoin.routes.ts
View File

@ -252,36 +252,62 @@ class BitcoinRoutes {
*/ */
private async postPsbtCompletion(req: Request, res: Response) { private async postPsbtCompletion(req: Request, res: Response) {
res.setHeader('content-type', 'text/plain'); res.setHeader('content-type', 'text/plain');
const notFoundError = `Couldn't get transaction hex for parent of input`;
try { try {
let psbt: bitcoinjs.Psbt; let psbt: bitcoinjs.Psbt;
let format: 'hex' | 'base64'; let format: 'hex' | 'base64';
let isModified = false;
try { try {
psbt = bitcoinjs.Psbt.fromBase64(req.body); psbt = bitcoinjs.Psbt.fromBase64(req.body);
format = 'base64'; format = 'base64';
} catch(e1) { } catch (e1) {
try { try {
psbt = bitcoinjs.Psbt.fromHex(req.body); psbt = bitcoinjs.Psbt.fromHex(req.body);
format = 'hex'; format = 'hex';
} catch(e2) { } catch (e2) {
throw new Error(`Unable to parse PSBT`); throw new Error(`Unable to parse PSBT`);
} }
} }
for (const [index, input] of psbt.data.inputs.entries()) { for (const [index, input] of psbt.data.inputs.entries()) {
if (!input.nonWitnessUtxo) { if (!input.nonWitnessUtxo) {
// Buffer.from ensures it won't be modified in place by reverse() // Buffer.from ensures it won't be modified in place by reverse()
const txid = Buffer.from(psbt.txInputs[index].hash).reverse().toString('hex'); const txid = Buffer.from(psbt.txInputs[index].hash)
const transaction: IEsploraApi.Transaction = await bitcoinApi.$getRawTransaction(txid, true); .reverse()
if (!transaction.hex) { .toString('hex');
throw new Error(`Couldn't get transaction hex for ${txid}`);
let transaction: IEsploraApi.Transaction;
// If missing transaction, return 404 status error
try {
transaction = await bitcoinApi.$getRawTransaction(txid, true);
if (!transaction.hex) {
throw new Error('');
}
} catch (err) {
throw new Error(`${notFoundError} #${index} @ ${txid}`);
} }
psbt.updateInput(index, { psbt.updateInput(index, {
nonWitnessUtxo: Buffer.from(transaction.hex, 'hex'), nonWitnessUtxo: Buffer.from(transaction.hex, 'hex'),
}); });
if (!isModified) {
isModified = true;
}
} }
} }
res.send(format === 'hex' ? psbt.toHex() : psbt.toBase64()); if (isModified) {
res.send(format === 'hex' ? psbt.toHex() : psbt.toBase64());
} else {
// Not modified
// 422 Unprocessable Entity
// https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422
res.status(422).send(`Psbt had no missing nonUtxoWitnesses.`);
}
} catch (e: any) { } catch (e: any) {
res.status(500).send(e instanceof Error ? e.message : e); if (e instanceof Error && new RegExp(notFoundError).test(e.message)) {
res.status(404).send(e.message);
} else {
res.status(500).send(e instanceof Error ? e.message : e);
}
} }
} }