More robust error checking & handling in CPFP repositories

backend/src/repositories/TransactionRepository.ts

@@ -3,15 +3,6 @@ import logger from '../logger';
 import { Ancestor, CpfpInfo } from '../mempool.interfaces';
 import cpfpRepository from './CpfpRepository';
 
-interface CpfpSummary {
-  txid: string;
-  cluster: string;
-  root: string;
-  txs: Ancestor[];
-  height: number;
-  fee_rate: number;
-}
-
 class TransactionRepository {
   public async $setCluster(txid: string, clusterRoot: string): Promise<void> {
     try {
@@ -72,7 +63,9 @@ class TransactionRepository {
         const txid = txRows[0].id.toLowerCase();
         const clusterId = txRows[0].root.toLowerCase();
         const cluster = await cpfpRepository.$getCluster(clusterId);
-        return this.convertCpfp(txid, cluster);
+        if (cluster) {
+          return this.convertCpfp(txid, cluster);
+        }
       }
     } catch (e) {
       logger.err('Cannot get transaction cpfp info from db. Reason: ' + (e instanceof Error ? e.message : e));
@@ -81,13 +74,18 @@ class TransactionRepository {
   }
 
   public async $removeTransaction(txid: string): Promise<void> {
-    await DB.query(
-      `
-        DELETE FROM compact_transactions
-        WHERE txid = UNHEX(?)
-      `,
-      [txid]
-    );
+    try {
+      await DB.query(
+        `
+          DELETE FROM compact_transactions
+          WHERE txid = UNHEX(?)
+        `,
+        [txid]
+      );
+    } catch (e) {
+      logger.warn('Cannot delete transaction cpfp info from db. Reason: ' + (e instanceof Error ? e.message : e));
+      throw e;
+    }
   }
 
   private convertCpfp(txid, cluster): CpfpInfo {
@@ -95,7 +93,7 @@ class TransactionRepository {
     const ancestors: Ancestor[] = [];
     let matched = false;
 
-    for (const tx of cluster.txs) {
+    for (const tx of (cluster?.txs || [])) {
       if (tx.txid === txid) {
         matched = true;
       } else if (!matched) {