Better fix for unfurler race condition

2022-08-31 17:24:56 +00:00
parent 5300f84e77
commit 8bd4fcdab6
8 changed files with 56 additions and 46 deletions
--- a/unfurler/src/concurrency/ReusablePage.ts
+++ b/unfurler/src/concurrency/ReusablePage.ts
@@ -87,6 +87,10 @@ export default class ReusablePage extends ConcurrencyImplementation {
      page.repairRequested = true;
    });
    await page.goto(defaultUrl, { waitUntil: "load" });
+    await Promise.race([
+      page.waitForSelector('meta[property="og:preview:ready"]', { timeout: config.PUPPETEER.RENDER_TIMEOUT || 3000 }).then(() => true),
+      page.waitForSelector('meta[property="og:preview:fail"]', { timeout: config.PUPPETEER.RENDER_TIMEOUT || 3000 }).then(() => false)
+    ])
    page.free = true;
    return page
  }