machankura/mempool
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

log warnings for unexpectedly missing txs

Browse Source
This commit is contained in:
Mononaut 2023-03-26 05:41:31 +09:00
parent 61f24562fd
commit 8486c1117d
No known key found for this signature in database
GPG Key ID: A3F058E41374C04E
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
backend/src/api/audit.ts
View File

@ -1,4 +1,5 @@
import config from '../config'; import config from '../config';
import logger from '../logger';
import { TransactionExtended, MempoolBlockWithTransactions } from '../mempool.interfaces'; import { TransactionExtended, MempoolBlockWithTransactions } from '../mempool.interfaces';
const PROPAGATION_MARGIN = 180; // in seconds, time since a transaction is first seen after which it is assumed to have propagated to all miners const PROPAGATION_MARGIN = 180; // in seconds, time since a transaction is first seen after which it is assumed to have propagated to all miners
@ -77,6 +78,8 @@ class Audit {
} else { } else {
failures++; failures++;
} }
} else {
logger.warn('projected transaction missing from mempool cache');
} }
index++; index++;
} }
@ -129,6 +132,8 @@ class Audit {
} }
} }
overflowWeightRemaining -= (mempool[txid]?.weight || 0); overflowWeightRemaining -= (mempool[txid]?.weight || 0);
} else {
logger.warn('projected transaction missing from mempool cache');
} }
index--; index--;
} }

13
backend/src/api/mempool-blocks.ts
View File

@ -188,7 +188,12 @@ class MempoolBlocks {
this.txSelectionWorker.postMessage({ type: 'set', mempool: strippedMempool }); this.txSelectionWorker.postMessage({ type: 'set', mempool: strippedMempool });
let { blocks, clusters } = await workerResultPromise; let { blocks, clusters } = await workerResultPromise;
// filter out stale transactions // filter out stale transactions
const unfilteredCount = blocks.reduce((total, block) => { return total + block.length; }, 0);
blocks = blocks.map(block => block.filter(tx => (tx.txid && tx.txid in newMempool))); blocks = blocks.map(block => block.filter(tx => (tx.txid && tx.txid in newMempool)));
const filteredCount = blocks.reduce((total, block) => { return total + block.length; }, 0);
if (filteredCount < unfilteredCount) {
logger.warn(`tx selection worker thread returned ${unfilteredCount - filteredCount} stale transactions from makeBlockTemplates`);
}
// clean up thread error listener // clean up thread error listener
this.txSelectionWorker?.removeListener('error', threadErrorListener); this.txSelectionWorker?.removeListener('error', threadErrorListener);
@ -232,7 +237,12 @@ class MempoolBlocks {
this.txSelectionWorker.postMessage({ type: 'update', added: addedStripped, removed }); this.txSelectionWorker.postMessage({ type: 'update', added: addedStripped, removed });
let { blocks, clusters } = await workerResultPromise; let { blocks, clusters } = await workerResultPromise;
// filter out stale transactions // filter out stale transactions
const unfilteredCount = blocks.reduce((total, block) => { return total + block.length; }, 0);
blocks = blocks.map(block => block.filter(tx => (tx.txid && tx.txid in newMempool))); blocks = blocks.map(block => block.filter(tx => (tx.txid && tx.txid in newMempool)));
const filteredCount = blocks.reduce((total, block) => { return total + block.length; }, 0);
if (filteredCount < unfilteredCount) {
logger.warn(`tx selection worker thread returned ${unfilteredCount - filteredCount} stale transactions from updateBlockTemplates`);
}
// clean up thread error listener // clean up thread error listener
this.txSelectionWorker?.removeListener('error', threadErrorListener); this.txSelectionWorker?.removeListener('error', threadErrorListener);
@ -258,6 +268,7 @@ class MempoolBlocks {
let matched = false; let matched = false;
cluster.forEach(txid => { cluster.forEach(txid => {
if (!txid || !mempool[txid]) { if (!txid || !mempool[txid]) {
logger.warn('projected transaction ancestor missing from mempool cache');
return; return;
} }
if (txid === tx.txid) { if (txid === tx.txid) {
@ -280,6 +291,8 @@ class MempoolBlocks {
mempool[tx.txid].bestDescendant = null; mempool[tx.txid].bestDescendant = null;
} }
mempool[tx.txid].cpfpChecked = tx.cpfpChecked; mempool[tx.txid].cpfpChecked = tx.cpfpChecked;
} else {
logger.warn('projected transaction missing from mempool cache');
} }
}); });
}); });