From 680e9562a05c790fbae0010c70592af87c18584b Mon Sep 17 00:00:00 2001
From: nymkappa <1612910616@pm.me>
Date: Sat, 13 Jul 2024 21:07:13 +0900
Subject: [PATCH] [btcpay] handle new http code 204 when calling
 /payments/bitcoin/check api

---
 .../components/bitcoin-invoice/bitcoin-invoice.component.ts  | 5 ++++-
 frontend/src/app/services/services-api.service.ts            | 4 ++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/frontend/src/app/components/bitcoin-invoice/bitcoin-invoice.component.ts b/frontend/src/app/components/bitcoin-invoice/bitcoin-invoice.component.ts
index 20f88d5c5..79584b3d8 100644
--- a/frontend/src/app/components/bitcoin-invoice/bitcoin-invoice.component.ts
+++ b/frontend/src/app/components/bitcoin-invoice/bitcoin-invoice.component.ts
@@ -74,7 +74,10 @@ export class BitcoinInvoiceComponent implements OnInit, OnChanges, OnDestroy {
     }
     this.paymentStatusSubscription = this.apiService.getPaymentStatus$(this.invoice.btcpayInvoiceId).pipe(
       retry({ delay: () => timer(2000)})
-    ).subscribe((result) => {
+    ).subscribe((response) => {
+      if (response.status === 204 || response.status === 404) {
+        return;
+      }
       this.paymentStatus = 3;
       this.completed.emit();
     });
diff --git a/frontend/src/app/services/services-api.service.ts b/frontend/src/app/services/services-api.service.ts
index ca5f0eefd..bfd7da81b 100644
--- a/frontend/src/app/services/services-api.service.ts
+++ b/frontend/src/app/services/services-api.service.ts
@@ -181,7 +181,7 @@ export class ServicesApiServices {
     return this.httpClient.get<any[]>(`${this.stateService.env.SERVICES_API}/payments/bitcoin/invoice?id=${invoiceId}`);
   }
 
-  getPaymentStatus$(orderId: string): Observable<any[]> {
-    return this.httpClient.get<any[]>(`${this.stateService.env.SERVICES_API}/payments/bitcoin/check?order_id=${orderId}`);
+  getPaymentStatus$(orderId: string): Observable<any> {
+    return this.httpClient.get<any>(`${this.stateService.env.SERVICES_API}/payments/bitcoin/check?order_id=${orderId}`, { observe: 'response' });
   }
 }