Fix pool get blocks API undefined start block behavior

This commit is contained in:
nymkappa
2022-03-16 20:19:39 +01:00
parent 5326f34f66
commit 32f38cddba
4 changed files with 14 additions and 8 deletions

View File

@@ -235,7 +235,7 @@ class BlocksRepository {
/**
* Get blocks mined by a specific mining pool
*/
public async $getBlocksByPool(poolId: number, startHeight: number | null = null): Promise<object[]> {
public async $getBlocksByPool(poolId: number, startHeight: number | undefined = undefined): Promise<object[]> {
const params: any[] = [];
let query = ` SELECT *, UNIX_TIMESTAMP(blocks.blockTimestamp) as blockTimestamp,
previous_block_hash as previousblockhash
@@ -243,7 +243,7 @@ class BlocksRepository {
WHERE pool_id = ?`;
params.push(poolId);
if (startHeight) {
if (startHeight !== undefined) {
query += ` AND height < ?`;
params.push(startHeight);
}

View File

@@ -553,7 +553,7 @@ class Routes {
try {
const poolBlocks = await BlocksRepository.$getBlocksByPool(
parseInt(req.params.poolId, 10),
parseInt(req.params.height, 10) ?? null,
req.params.height === undefined ? undefined : parseInt(req.params.height, 10),
);
res.header('Pragma', 'public');
res.header('Cache-control', 'public');