Update block API to use indexing if available

backend/src/api/blocks.ts

@@ -134,26 +134,25 @@ class Blocks {
       blockExtended.extras.avgFeeRate = stats.avgfeerate;
     }
 
-    if (Common.indexingEnabled()) {
-      let pool: PoolTag;
-      if (blockExtended.extras?.coinbaseTx !== undefined) {
-        pool = await this.$findBlockMiner(blockExtended.extras?.coinbaseTx);
-      } else {
-        pool = await poolsRepository.$getUnknownPool();
-      }
-
-      if (!pool) { // We should never have this situation in practise
-        logger.warn(`Cannot assign pool to block ${blockExtended.height} and 'unknown' pool does not exist. Check your "pools" table entries`);
-        return blockExtended;
-      }
-
-      blockExtended.extras.pool = {
-        id: pool.id,
-        name: pool.name,
-        slug: pool.slug,
-      };
+    let pool: PoolTag;
+    if (blockExtended.extras?.coinbaseTx !== undefined) {
+      pool = await this.$findBlockMiner(blockExtended.extras?.coinbaseTx);
+    } else {
+      pool = await poolsRepository.$getUnknownPool();
     }
 
+    if (!pool) { // We should never have this situation in practise
+      logger.warn(`Cannot assign pool to block ${blockExtended.height} and 'unknown' pool does not exist. ` +
+        `Check your "pools" table entries`);
+      return blockExtended;
+    }
+
+    blockExtended.extras.pool = {
+      id: pool.id,
+      name: pool.name,
+      slug: pool.slug,
+    };
+
     return blockExtended;
   }
 
@@ -389,6 +388,39 @@ class Blocks {
     return prepareBlock(blockExtended);
   }
 
+  /**
+   * Index a block by hash if it's missing from the database. Returns the block after indexing
+   */
+  public async $getBlock(hash: string): Promise<BlockExtended | IEsploraApi.Block> {
+    // Block has already been indexed
+    if (Common.indexingEnabled()) {
+      const dbBlock = await blocksRepository.$getBlockByHash(hash);
+      if (dbBlock != null) {
+        logger.info('GET BLOCK: already indexed');
+        return prepareBlock(dbBlock);
+      }
+    }
+
+    const block = await bitcoinApi.$getBlock(hash);
+
+    // Not Bitcoin network, return the block as it
+    if (['mainnet', 'testnet', 'signet'].includes(config.MEMPOOL.NETWORK) === false) {
+      logger.info('GET BLOCK: using bitcoin backend');
+      return block;
+    }
+
+    // Bitcoin network, add our custom data on top
+    logger.info('GET BLOCK: index block on the fly');
+    const transactions = await this.$getTransactionsExtended(hash, block.height, true);
+    const blockExtended = await this.$getBlockExtended(block, transactions);
+    if (Common.indexingEnabled()) {
+      delete(blockExtended['coinbaseTx']);
+      await blocksRepository.$saveBlockInDatabase(blockExtended);
+    }
+
+    return blockExtended;
+  }
+
   public async $getBlocksExtras(fromHeight?: number, limit: number = 15): Promise<BlockExtended[]> {
     // Note - This API is breaking if indexing is not available. For now it is okay because we only
     // use it for the mining pages, and mining pages should not be available if indexing is turned off.

backend/src/api/common.ts

@@ -174,7 +174,7 @@ export class Common {
     return (
       ['mainnet', 'testnet', 'signet'].includes(config.MEMPOOL.NETWORK) &&
       config.DATABASE.ENABLED === true &&
-      config.MEMPOOL.INDEXING_BLOCKS_AMOUNT != 0
+      config.MEMPOOL.INDEXING_BLOCKS_AMOUNT !== 0
     );
   }
 }