Files
giza-kmp/docs/scripts/m3-touch-targets.py
T
Kgothatso NgakoandClaude Opus 5.5 34e802ce6f refactor: packages, classes and Res under mobi.giza (fork, Phase 3b)
docs/scripts/giza-rename.sh, run over the moves of Phase 3a:

- com.machankura.bennu.{compose,android,desktop} -> mobi.giza.{...}, in
  package lines, imports, fully qualified references, the manifest, mainClass,
  the Android namespace (one value with applicationId again), the m3Audit
  source path, the six docs/scripts tools, and the source links in docs/;
- Res moves from bennu.composeapp.generated.resources to
  mobi.giza.compose.resources, now pinned with packageOfResClass so a later
  rename of the root project leaves the imports alone;
- BennuDatabase, BennuTheme and the other eleven Bennu identifiers are Giza*.

The script's search is now the same pattern as its sed expressions, so on a
renamed tree it finds nothing and changes nothing.

Checked against the Phase 0 baseline: jvmTest 1643 run (1642 + AppDirJvmTest),
0 failed, 2 skipped; compileDebugKotlinAndroid passes; m3-audit prints the
baseline report line for line. iOS is not compiled on this Linux host.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 10:40:27 +02:00

57 lines
2.2 KiB
Python
Executable File

#!/usr/bin/env python3
"""Find `.clickable` chains with no minimum interactive size.
M3 asks for touch targets of at least 48x48dp and pointer targets of at least 44x44dp.
`Modifier.clickable` gives an element no minimum of its own, so a clickable `Text` is a
target the size of the text -- around 20dp here.
`minimumInteractiveComponentSize()` is a no-op on anything already 48dp or larger, so the
rule this checks is simply that every `.clickable` chain has it: correct everywhere, and
textual enough to enforce. It reserves *layout* space; touch expansion happens at the
input layer regardless, and the layout is what stops adjacent targets overlapping and what
a pointer on desktop has to land on.
Components that carry their own minimum -- IconButton, Button, Checkbox, ListItem and the
rest of material3 -- are not `.clickable` call sites and never appear here.
Usage: m3-touch-targets.py [--list]
"""
import os, re, sys
UI = 'composeApp/src/commonMain/kotlin/mobi/giza/compose/ui'
def offenders():
found = []
for root, _, files in os.walk(UI):
for f in sorted(files):
if not f.endswith('.kt'):
continue
path = os.path.join(root, f)
lines = open(path, encoding='utf-8').read().split('\n')
for i, line in enumerate(lines):
if '.clickable' not in line:
continue
if line.lstrip().startswith('//') or line.startswith('import '):
continue
# The modifier may sit on this line or on the one above, since a chain
# broken across lines is the common shape.
window = '\n'.join(lines[max(0, i - 1):i + 1])
if 'minimumInteractiveComponentSize' in window:
continue
found.append((path, i + 1, line.strip()[:90]))
return found
def main():
found = offenders()
print(f' {"clickable chains with no minimum target":42s} {len(found):6d}')
if '--list' in sys.argv:
for path, line, ctx in found:
print(f' {path.replace(UI + "/", "")}:{line} {ctx}')
return 1 if found else 0
if __name__ == '__main__':
sys.exit(main())