Eight libraries, the sqldelight plugin alias and six version keys that no
build script references, and the commented-out lines that named them or
Room 2's aliases. The jvm, debug and release runtime graphs are identical
to Phase 0's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
magpieLockAudit runs docs/scripts/magpie-lock-audit.sh from check, beside the
M3, brand, wallet and marmot audits. Every catalogue library in a group Magpie
serves must be declared strictly (D3) and have a lock line for its root,
-jvm and -android modules -- read as text, so a bump made on one platform is
caught on any. Verified both ways: silent on a clean tree; a dropped lock line
or a plain, unlocked bump names the module and fails the build.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
giza deleted FoundingAdmins.check (remove-founding-admins-card): it
cannot tell a founder left out by a buggy creator from one the group
demoted, and every founder is an admin when the room is made. RoomAdmins
drops its missing-founders guard, and A4 says why.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
C1 measured again on mls-kmp 1.3.1: the old-blob, shipped-profile, store,
sender-ratchet, skipped-generation and fork tests are green untouched, and the
authored fork is still open. The re-save test only said "newer than 4", which
a library that moved to 11 would pass, though a bump is what an older build
cannot read back; the seventh case pins 10 exactly, checked red at 11.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mls-kmp 1.3.1 gives a new group the RFC 9420 §11 epoch-0 interim transcript
hash, where quartz 1.15.2 and mls 1.3.0 left it empty. A state saved the old
way keeps its empty hash -- 1.3.1's audit commit dropped the restore-time
repair -- so the room the old engine created is restored as it was, and the
commit that adds its first member is the one the hash feeds. Pinned both ways,
and measured: the add, the Welcome, and a message each way across it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The running card names the members whose share it takes away because
the group removed them as admin, and their rows read Share being
rotated away instead of Holds a share. Removing an admin says nobody
is asked again.
The plan is marked built, with where the build chose differently, and
the notes it changes point to it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Make admin at the ceremony's generation no longer sends the admin to
rotate by hand and come back: the offer starts that rotation, which
withholds nobody new and so asks nobody, and the accepted offer's
proposal waits in GovernanceFollowThrough until the group has signed
the new shares. A rotation abandoned or failed ends the offer out loud,
once. The confirmation says the shares are rotated first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A recipient takes part unasked when the rotation withholds nobody the
group has not already decided about: everyone it leaves out until they
are back is stale already, and everyone it leaves out for good is
someone the group's signature took out of a governed room's admins.
The check sits at advance's one gate, so arrival, a replay and the
sweep all meet it, and the room is told in place of being asked.
Every rotation now retires the live holders the group removed as admin
(A3), so whichever runs first after a demotion takes their share away.
Neither applies in an ungoverned room or to a founder the admin policy
has been missing from the start.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A change that moves who holds a share -- any change of admins, or the
removal of a holder -- is refused while a rotation is under way, until
its key state is signed, and so are offers and step-down requests. A
step-down request or an accepted offer that arrives meanwhile waits and
is taken up on the next pass. A removal whose owed rotation would fail
the majority rule is refused before anyone signs (A12). The member rows
list the rotation as the reason, with whom it waits on.
rotateAway no longer takes a running rotation that still deals to the
removed member for the one it owes, which left them a live share and
said nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rotationHold gains two reasons: a signed change that moves who holds a
share is still being signed or on its way to a relay, and a new admin's
bound id has no share yet. rotationPending is the part admin changes
wait on, through AdminGovernance.adminChangeHold: a rotation running, or
its key state not yet signed. RoomAdmins reads the live admin policy,
with a seam for the in-memory ritual devices. The Shares section's held
line names the two new reasons.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A removal's rotation asks every remaining holder. A removal during a
rotation is handed the running one, which deals the removed member a
live share. A new admin bound mid-rotation fails the rotation's round-2
check. A statement being signed fails when the rotation lands. A
step-down request taken up during a rotation is used up. The first
promotion is refused at generation 0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FoundingAdmins.check, announceIfMissing, ChatRepository.foundingAdmins and
addAdmins, MarmotOutboundDao.addAdmins and FoundingAdminsJvmTest are deleted:
nothing calls them any more. ceremonyOf, the one piece still used, moves to
MarmotGroupCreation beside uninvitedFounders and finishFoundingInvite.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The line ended "An admin can add them back from the room's details", and
nothing there does that any more. TYPE_FOUNDING_ADMINS_MISSING stays in
MEMBERSHIP_TYPES, retired, so the rows already written still render as
captions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
missingFoundingAdmins and addMissingFoundingAdmins go with the card that read
them, and every detail load drops a group decode. founderNames now names only
the uninvited founders.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A founder missing from a keyed room's policy is now usually one the group
demoted or who stepped down, and the card's "Make them admins" offered to
undo that. The "not every founding member was invited" card stays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The retired caption type's place in MEMBERSHIP_TYPES moves to
ChatRoomLastMessagePreviewTest, and the legacy-room case asserts no key
state directly rather than through FoundingAdmins.check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in a keyed room's step-down by request (bb35d73c) and keyed rooms
born needing the group's signature, with the switch gone (1ccd8c7f).
Resolved: AdminGovernance keeps giza's canAskToStepDown and
stepDownProposer beside the policy-backed memberActions; the
repositories keep memberActionOptions and lose requireSignatures; the
loader no longer asks GovernanceSupport whose devices a room waits on.
Reconciled: the policy offers your own row Step down as admin in a keyed
room on canAskToStepDown's terms -- governed, rotation on, above the
floor, another admin to ask -- so the menu matches the request giza
added. SignaturesNotRequired carries no data and says the group was made
before signed changes and keeps its admins, since nothing switches the
rule on any more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An admin's own row had no menu in a keyed room: stepping down was not
offered, because a demotion's proposer starts the rotation that takes
the demoted admin's share away, and a rotation's proposer has to keep a
share.
Step down as admin now sends a request into the room
(PromotionEvents.STEP_DOWN, 30377) and commits nothing. The remaining
admin in the lowest leaf (AdminGovernance.stepDownProposer) -- one
device, named the same everywhere, so two never propose at one epoch --
takes it up in GovernanceFollowThrough and runs the same demote its own
Remove as admin would. A request is used once, and dropped by every
device once its requester is no longer an admin. Offered only above the
floor and while another admin is there to ask.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The note's status, a table of the build's departures from the plan --
the route carries the action by name, an unavailable item's state rather
than a second click label, the only admin as one reason -- the README
entry, and a pointer from member-admin-promotion's Phase 11. The unused
"See why" string goes with the click label it was for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two reasons that clear by themselves, said before anyone tries rather
than in a snackbar after: an earlier change the publish gate is holding
until a relay accepts it, and an admin offer the member has not
answered, by whoever made it. PromotionManager.unansweredOfferTargets
reads the second from the room's offer and acceptance events.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The overflow menu replaces the chevron on every row but the viewer's
own, whoever is looking. It lists every action that fits the member's
role, open or not, in a fixed order. One that is not open is marked --
the quieter role colour, an info icon, and an "Unavailable" state -- and
opens the screen that says why instead of acting. It is not disabled,
which would leave the explanation unreachable.
Your own row is unchanged: the menu when stepping down is open, the
chevron otherwise. The row says "View profile" to assistive technology
now that the chevron that said it is gone from most rows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MemberActionUnavailableRoute carries what was asked -- the room, the
member, the action -- and the screen works the reasons out again
through ChatRepository.memberActionOptions, following the room while it
is open. It leads with the first thing in the way, lists the rest under
it, and offers the one action that helps where there is one: the admin
room for a NIP-17 room, the group's page for the signature switch. A
reason that clears says so.
The action travels by name: the multiplatform navigation-compose has no
NavType for an enum, which the route test caught on its first run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rule that a keyed room's changes need the group's signature was
switched on after founding, once every member's device had said it could
follow signed commits. That protected Bennu members and older Giza
builds from being left behind by the first signed change. Giza is in
development and keeps compatibility with neither, so the switch
protected nobody, and it kept an invited member from ever being made an
admin.
MarmotGroupCreation.createFor now writes GovernanceMarker's line, with
the floor the ceremony's quorum sets, into the room's epoch-0
description. Founding still needs no signature: the founding invite is
the creator's commit while it is the only member, which no other device
processes.
Removed: GovernanceSupport and its event (30372), the announcements on
joining, at start and in answer, the automatic switch and
requireSignatures, and the screen's waiting and ready states.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChatRepository.memberActionOptions is the one loader of what each row
offers: the policy over the group's state, with having left and whose
devices a keyed room waits on added from the database. A NIP-17 room and
a legacy room answer from their kind. The view model asks for every
room, not only one this device governs; the row still shows only what
is open until the explanation screen exists.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MemberActionPolicy decides, over plain sets, every action a member row
offers and what stands in its way: the room's kind, the viewer's role,
the keyed room's two rules, the member's leaf, the floor, and work in
flight. AdminGovernance.memberActions is now that, filtered to what is
open, so its existing tests pin the agreement.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Requiring the group's signature for changes was a button an admin had
to find on the room's screen. Nothing about it was a decision: the two
conditions it waits on -- every member's device can follow, enough of
them are admins -- were already checked in code. The button is gone.
One device switches it on: the admin in the room's lowest leaf, which
in a room as made is its creator (GovernanceSupport.switcherOf). Not
every admin's, because two commits at one epoch are not settled for
their authors (docs/marmot-v2.md, Phase 8); every device reads the same
leaf, so they agree on one without talking. GovernanceFollowThrough
runs the switch whenever a member says it follows signed commits, and
on start.
Not at creation: a Bennu or older-Giza founder would be cut off without
anyone knowing, and a founding invite finished later is a bare commit a
governed room refuses. The room switches seconds after its founders
join instead. The screen names whose device it is waiting on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An invited member of a robust group could never be made an admin. Making
one needs the room to require the group's signature, which waits until
every member's device has said it follows signed commits. A device said
so when the room's screen was opened, or back when it heard another say
it -- but the founders said it before the invite, at an epoch the new
member cannot read, so it heard nothing, nobody said it again, and the
room waited on a screen the member had no reason to open.
A device now says it on joining (the Welcome path) and once each start
(GovernanceSupport.announceAll), for members who joined before this.
The waiting notice names who the room waits on and what for, instead of
"X need to update Giza".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
remove-convenient-groups' new test makes its phones with Phone(profile);
since the legacy KeyPackage slot was retired every phone publishes the one
package the app does, so it is Phone().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotProfile.PUBLISHED is the current profile alone. The repository
publishes only the current-profile package and refuses to be asked for a
legacy one; KeyPackageEvent.build and the legacy leaf builder have no caller
and are gone. The notary republishes only what PUBLISHED names, so a legacy
bundle still active is left to be consumed and not replaced.
A legacy room still invites: the current-profile leaf advertises 0xF2EE.
RobustGroupAdminsJvmTest's legacy-room cases now join from the one package
the app publishes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarmotProfile.DEFAULT_FOR_NEW_ROOMS goes from LEGACY to CURRENT, so every
creation site -- direct messages, convenient rooms, keyed rooms -- makes a
current-profile group, and the pickers ask peers for current-profile
KeyPackages. Rooms made before stay legacy for good.
Two creation tests read the legacy 0xF2EE extension directly; they now read
the room id, name and admins through the accessors that work on both
profiles.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two files this branch deleted were changed on giza:
- SelectChatRoomTypeViewModel: giza added a reconcileAdmins call to the
convenient path, which this branch removed. The robust path
(MarmotGroupCreation) and direct messages (MarmotOutboundDao) already
reconcile, so the deletion stands.
- ChatRoomType: giza added minimumAdmins(threshold) for the admin floor.
It moves to Quorum.minimumAdmins beside the other quorum rules (D6);
AdminGovernance and AdminChangesJvmTest call it there.
docs/member-admin-promotion.md now notes where the names it cites went.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under the experimental FROST enrollment. In a governed keyed room past its
ceremony's generation, Make admin is an offer (30374); the member accepts
(30375), naming the ChillDKG host key their shares will be sealed to,
which is the one decision only they can make. The offering device then
proposes one batch for the group to sign: the change making them an admin,
and the key state binding the next participant id to them, with that id's
public share -- interpolated from the table every device already holds --
added to the table it hashes.
Every device adds the id when it files that key state, and only if the
extended table hashes to what the group signed. Once the change lands the
offering device hands over (30376) the table, roster and signed key state;
the new member's device checks them against the room's own signature,
files its record of the key, and asks to be enrolled. t holders run
reduced FROST enrollment at newId = n through the repair protocol, with no
approval of their own -- the signed binding was it -- and the new share is
checked against the signed table.
A signing session's n is now the generation's table size, which an
enrollment grows; the repair session carries the n an enrollment runs
with (schema v42, still unshipped). GovernanceFollowThrough drives the
offerer's and the new member's steps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a governed keyed room, with share rotation on, an admin can propose
removing another as admin -- never themselves, since the rotation that
has to follow is the remaining holders'. The demotion is a signed change
like any other, and the floor holds. A removal of a member who holds a
live share is the same.
Either one remembers who to rotate out (GovernanceProposal.thenRotateWithout,
schema v42), is marked applied when a relay accepts it, and
GovernanceFollowThrough -- a driver beside the ceremony follow-through,
with the key pair -- then proposes the rotation without them. A change
that landed while the app was closed is caught from the group's state; a
rotation that cannot start is said in the room, and offered from the
Shares section.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robust-group-admins built the same thing as this branch's Phase 1: a single
writer for Participant.adminAt, run at creation, on the Welcome, on every
commit and once at start. Its AdminFlags is kept as that writer; this
branch's MarmotInboundManager.reconcileAdmins and adminFlagChanges are
gone, and the direct-message and convenient-room creation sites and the
detail screen's catch-up call AdminFlags instead. The admin captions stay,
on top of it.
Both sides added to the room's details: the founding-admin repair and
invite beside the member menu, admin labels and governance section. The
member row keeps one label line -- Admin from adminAt, Holds a share
beside it -- and the removal message now has three cases: proposed for the
group's signature, rotation held, or sent. The rotation offer waits for
both: a rotation available, and the removal not still awaiting signatures.
addAdmins, the founding-admin repair, proposes its commit for the group's
signature in a governed room instead of committing it bare.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The wallet audit fails on a retired kind's number anywhere in the app's
code, comments included; Phase 3 spelled the range out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In a governed room, removing a member, inviting one and disbanding are
proposed and signed by the group instead of committed by one admin. A
removal is now one commit -- the Remove and, for an admin, their entry off
the admin list -- since a copy of the group can stage both where the
manager could not. Disbanding a room that has not yet agreed it can be
disbanded proposes that agreement first.
An admin's device folding in a member's leave sends it inside its own
envelope (30371), not bare. The commit builders live on GovernanceManager
so the DAO and the tests use the same ones.
Fixes a gate bug the inbound removal test found: a Remove's account is
now read off the group as it stood before the commit, because the copy's
view can already have the removed leaf blank.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A one-to-one chat, or a group its creator runs alone, grown by one more
person would be a group run by one person. The invite screen refuses such
a room and the detail screen no longer offers the invite there. The plan
gains D7, since D1 had assumed no such invite path existed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GovernanceManager.propose builds the commit on a copy of the group whose
policy records its proposals -- so the statement is read off the very
commit -- builds the kind:445 that carries it without publishing it, and
opens a signing session over the statement whose content is that kind:445.
A GovernanceProposal (schema v41) keeps the states either side, because
this device cannot process its own commit and signing outlasts a session.
Every member's device runs the same checks as the door before its owner is
asked, and declines a statement whose commit does not say what its tags
say. When the session completes on the proposer's device, it sends the
signed statement in a carrier and raises the publish gate with the kept
state; the relay's OK on the carrier installs it. A proposal the group
moved past is marked stale and said so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The group-creation screen no longer offers a group its creator runs alone.
It asks only how many of the members have to agree, then opens the NIP-17
room and its key ceremony. The single-admin Marmot path, its invite round
and its 'couldn't be added' card are gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each device says once per keyed room, as GovernanceSupportEvent (30372),
that it follows signed commits, and says it back whenever it hears another
member say it, so a member who never opens the room is still counted.
An admin's Require the group's signature for changes is one bare commit
adding GovernanceMarker's line, with the floor the room's quorum sets, to
the profile description: the room's last bare commit. It is refused while
any member has not said it -- they would be left in a different group by
the first change -- and while the room has fewer admins than the floor.
The room's screen says which, or that the rule is on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A keyed room whose profile description carries GovernanceMarker's line --
changes need the group's signature, and at least N admins -- is governed,
and every device reads that from the same epoch's state.
GovernanceGate is the door. At the one inbound call into the engine, a
commit sent bare into a governed room is dropped before the engine sees
it: the outer layer is peeled with the current and retained epochs' keys
and the MLS content type read from the header. A commit arrives instead
inside an envelope whose content is the proposer's own kind:445, so every
device applies the same event with the same id:
- a statement (30370), signed by the room and sent in a member's carrier
(30373), since an application message has to be its sender's;
- an own commit (30371) for D6's exemptions, sent by its committer.
The commit is run on a throwaway copy of the group under a policy that
records its proposals and committer -- no library change -- and admitted
only at the current epoch, matching its statement exactly, and leaving the
marker's floor of admins. A refusal says so in the room.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
giza brought rotation-waits-for-key-state, built in parallel from the
same base, and robust-group-admins. The first overlaps this branch, and
the two agreed on not asking the proposer. Where they met:
- The proposer's dialog is this branch's, read from the proposal's own
plan with its refusal, under giza's title and caveat; giza's dialog,
which listed stale members from the summary, went. The preview's
refusal carries rotationHold's reason, and ChatRoomDetailSharesJvmTest
asks its question of the kept dialog.
- The proposer is approved to take part only; giza also set
confirmApprovedAt, which nothing reads.
- The Shares section keeps both: giza's held button, its reason and
'Ask the group to sign', and this branch's running card and abandon.
- giza's hold tests left the new key state unsigned by not signing it.
It signs itself now, so they hold the signing messages after the
proposal (signingHeldOpen). This branch's test of two rotations opened
at once gave way to giza's, which asserts more.
jvmTest 1281/1281, compileDebugKotlinAndroid, m3Audit at its budgets,
brand and wallet audits.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>