From d2e5fa082db9b005384e05c8be622cb17ef83297 Mon Sep 17 00:00:00 2001 From: Kgothatso Ngako Date: Sat, 24 Oct 2026 08:00:46 +0200 Subject: [PATCH] docs: member guarded wallets are built, and the notes they touched say so (Phase 12) The plan is marked built, with a table of the thirteen places the build chose differently -- the key notice carrying the key rather than the signed key state, the request travelling whole inside an inner event, Put to the group living on the group's page, the wallet screen following a member's spends while open, and the signet run still to make before the mainnet gate lifts. The guardians and subgroups notes point here, and the README says it has been built. Co-Authored-By: Claude Opus 5.5 --- docs/README.md | 5 +++-- docs/group-wallet-guardians.md | 11 +++++++++++ docs/member-guarded-wallets.md | 25 ++++++++++++++++++++++++- docs/subgroups.md | 4 ++++ 4 files changed, 42 insertions(+), 3 deletions(-) diff --git a/docs/README.md b/docs/README.md index 03f314b8..10a760db 100644 --- a/docs/README.md +++ b/docs/README.md @@ -54,10 +54,11 @@ Phases 4 and 5 first, and its own table of where the build chose differently before the code. The group-wallet-guardians note is a phased plan that has been built; it assumes the subgroups and group-chain-wallet notes, and changes one sentence in each. -The member-guarded-wallets note is a phased plan that has not been built. It +The member-guarded-wallets note is a phased plan that has been built. It takes the guardians note's derivation unchanged and gives the key path to one person: read that note and the policy note's D2 first, then this note's table -of why a birth certificate will not do, and its Phase 0. +of why a birth certificate will not do, its Phase 0, and its table of where the +build chose differently before the code. The subgroup-wallet-policy note is a phased plan that has been built. It reads as the guardians note's *whose choice it is* reversed: read that section, then this note's Phase 0, whose five decisions shape every phase diff --git a/docs/group-wallet-guardians.md b/docs/group-wallet-guardians.md index 074c1126..7195d032 100644 --- a/docs/group-wallet-guardians.md +++ b/docs/group-wallet-guardians.md @@ -330,6 +330,10 @@ every address and a root that cannot find a coin to use it on. A statement forwarded into the middle group can be forwarded again from there, so overlap is needed one level at a time, not between the grandchild and the root directly. +Since [member-guarded-wallets.md](./member-guarded-wallets.md) the thing +forwarded may also be a member wallet certificate, which the guarding group +signed itself and so needs no forwarding into that group. + Once it has the statement, the ancestor watches the descendant's addresses on the Electrum client it already holds — unknown script hashes are ignored, so this costs subscriptions and nothing else — and its wallet screen grows a *Guarded @@ -420,6 +424,13 @@ One commit each. ## What this does not do +**It does not, on its own, guard one person.** That is +[member-guarded-wallets.md](./member-guarded-wallets.md): a wallet whose key +path is one member's random key, carrying exactly the leaves a guarded subgroup +of their group would, under a member wallet certificate (30334) the group signs +over the member's own request. Forwarding, the ancestor's walk and the guardian +spend are the ones here, with the line of descent ending in the wallet's id. + **It does not guard a wallet that is already open.** A subgroup that opened a plain wallet before its certificate carried keys keeps it. Guarding it would be a second account and a spend into it, and the wallet screen shows one account per diff --git a/docs/member-guarded-wallets.md b/docs/member-guarded-wallets.md index 5e46a350..ab9ace7c 100644 --- a/docs/member-guarded-wallets.md +++ b/docs/member-guarded-wallets.md @@ -24,7 +24,30 @@ grant, the leaf, the tree, the signing cache, the forwarding notice and the guardian spend. What is new is who holds the key path, and the artefact the group signs to agree to it. -**Not built.** Written against the code as it stood at `8cb6f04e`, schema v29. +**Built**, phases 1-12, one commit each (Phase 9 in two), written against the +code as it stood at `8cb6f04e`, schema v29; the build is schema v30. +`MemberWalletDerivation`, `MemberWalletRequestEvent`, `MemberWalletCertificateEvent`, +`MemberWalletManager` and `GuardianManager.GuardedSubject` are the entry points, +and `GroupWalletRollout.MEMBER_WALLETS_ON_MAINNET` is the gate, shut. The phases +below are kept as written; where the build chose differently the table says so. + +| what the plan said | what it turned out to be | +|---|---| +| Phase 2: the answer carries the signed `GroupKeyStateEvent`, whole | it carries the threshold key, its path and the group's certificate. A `GroupKeyState` row keeps what the state said and not the event, and nothing in the event is needed beyond what checks itself: the key at the path rederives the room, and the certificate certifies it and names that key | +| Phase 2: the first share-holder by npub answers at once, the rest after a minute | every device holding the verified state answers a request no answer names yet, as the chronicle's request is answered. Duplicates cost bandwidth and nothing else | +| Phase 3: the request is an inner event signed by the member | an inner event is an unsigned rumor, and the row it travels in keeps no `sig`. The signed request travels whole as the content of an inner event of the same kind -- `MemberWalletRequestEvent.carried` -- the way a 30333 notice carries a statement, and only from the member who signed it | +| Phase 5: `MemberWalletSpend` in a later bump | the same bump, v30, beside `MemberWallet` | +| Phase 6: the screens talk to `ChatRepository` | a `MemberWalletRepository` of their own, which holds the active identity: nothing above it touches a key | +| Phase 6: the gate arrives in Phase 12 | with Phase 6, where an entrance is first offered, as the guardians note's gate came with its Phase 5 | +| Phase 7: requests join `observeProposalsAwaitingYou` | *Put to the group* is on the request's row in the group page's *Members' guarded wallets* (Phase 11). The transcript says a request arrived; the proposal list still lists only sessions | +| Phase 7: the summary names the member | `ProposedEvent.summarize` takes a `nameOf`, and the callers that have no profiles to hand pass none, so the proposal list and signing screen say *Guard a member's wallet* without the name. The certificate's `p` tag is the member either way | +| Phase 8: the wipe callers warn first | `wipeDatabase` has no callers and `BennuDatabase.wipeData` deletes nothing. There is nothing to guard yet; a note on `wipeData` says what a caller must do once it does | +| Phase 9: `GroupTransactionWatcher` generalised | a member's spend has no session, so `MemberWalletViewModel` follows the member's spends while the wallet screen is open, sending again any Electrum has not heard of -- the economy the guardian-spend notice makes. *Bump the fee* is not built for a member's spend | +| Phase 10: `descendantChatRoomId` becomes `subject.id`, `statement` becomes `signedEvent` | both keep their names -- `descendantChatRoomId` is `subject.id`, and `statement` is the 30334 for a member -- so the guardian spend path did not change a line. `Spender.Guardian.name` is `@name` for a member | +| Phase 11: the person's page shows the amount within each group's reach | it does not watch the chain, so it shows the guarding group and *Spend*; the group's wallet screen has the amount. On one's own profile the section is not drawn: the profile's own list is the answer there | +| Phase 12: the three-emulator run | not made. It is what lifts the gate | + +Still to do by hand: Phase 12's run on signet. --- diff --git a/docs/subgroups.md b/docs/subgroups.md index 099b6c83..027262cf 100644 --- a/docs/subgroups.md +++ b/docs/subgroups.md @@ -168,6 +168,10 @@ tags: ["p", ] ``` +A member's guarded wallet is not a subgroup and never a 30329: every reader of +this kind assumes a room. It has its own certificate, 30334 -- +[member-guarded-wallets.md](./member-guarded-wallets.md). + With those, a parent admin's device can check the thing that actually matters before it signs — `marmotGroupId(subgroup_key, frost_path) == content` — and `ProposedEvent` can render "Translation team, for Alice, Bob and Carol" rather