diff --git a/composeApp/src/commonMain/composeResources/values/strings.xml b/composeApp/src/commonMain/composeResources/values/strings.xml
index 72877f8e..706392b2 100644
--- a/composeApp/src/commonMain/composeResources/values/strings.xml
+++ b/composeApp/src/commonMain/composeResources/values/strings.xml
@@ -639,6 +639,8 @@
This group's guardian keys can't be read by this version of the app.
Guarded wallets for members aren't offered on this network yet.
This profile has no wallet of its own to watch the chain with, so it couldn't see its own coins.
+ This group doesn't guard members' wallets.
+ This group has stopped guarding members' wallets.
You have no guarded wallets.
Waiting for someone in %1$s to put it to the group
%1$s is signing
diff --git a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/managers/MemberWalletManager.kt b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/managers/MemberWalletManager.kt
index ddab15d1..b1c45090 100644
--- a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/managers/MemberWalletManager.kt
+++ b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/managers/MemberWalletManager.kt
@@ -154,6 +154,15 @@ object MemberWalletManager {
/** The profile has no Electrum client, so it could not see its own coins. Read by the screen, not here. */
CANNOT_WATCH,
+
+ /**
+ * The group has not said it guards members' wallets: no policy, as far as
+ * this device knows. `docs/member-wallet-delay.md`, D8.
+ */
+ NOT_OFFERED,
+
+ /** The group's newest policy closed it to new members' wallets. D9. */
+ CLOSED,
}
/** Why [chatRoomId] cannot guard a wallet for this profile on [chain], or null when it can. */
@@ -166,7 +175,14 @@ object MemberWalletManager {
if (groupKey.certificate != null && SubgroupBirthCertificateEvent.parseGuardians(groupKey.certificate.tags) == null) {
return Refusal.GUARDIANS_UNREADABLE
}
- return null
+ // Only a group that has opened guards members' wallets, at the delay it
+ // chose -- and a late member learns it with the key, so no key and no
+ // policy is KEY_UNKNOWN above, with its button to ask.
+ return when (policyFor(database, chatRoomId)) {
+ null -> Refusal.NOT_OFFERED
+ is MemberWalletPolicyEvent.Policy.Closed -> Refusal.CLOSED
+ is MemberWalletPolicyEvent.Policy.Open -> null
+ }
}
/**
@@ -179,13 +195,16 @@ object MemberWalletManager {
/**
* How long a coin in a wallet [chatRoomId] guards would wait for each of its
- * guardians, nearest first: the group's own leaf at the default, and every
- * group above it at the delay it chose -- `docs/guardian-delay.md`. The same
- * list the grant in [request] carries. Null when this device does not know
- * the group's key.
+ * guardians, nearest first: the group's own leaf at the delay its open policy
+ * sets, and every group above it at the delay it chose -- the same list the
+ * grant in [request] carries. Null when this device does not know the
+ * group's key, or the group is not open. `docs/member-wallet-delay.md`.
*/
- suspend fun delaysOf(database: BennuDatabase, chatRoomId: String): List? =
- groupKeyFor(database, chatRoomId)?.let { key -> listOf(GuardianDerivation.DEFAULT_DELAY) + key.guardians.map { it.delay } }
+ suspend fun delaysOf(database: BennuDatabase, chatRoomId: String): List? {
+ val key = groupKeyFor(database, chatRoomId) ?: return null
+ val policy = policyFor(database, chatRoomId) as? MemberWalletPolicyEvent.Policy.Open ?: return null
+ return listOf(policy.delay) + key.guardians.map { it.delay }
+ }
/**
* Steps 1 and 2: makes a random key, works out every ancestor's leaf and
@@ -213,9 +232,15 @@ object MemberWalletManager {
val groupKey = groupKeyFor(database, chatRoomId) ?: throw IllegalStateException("Cannot ask: ${Refusal.KEY_UNKNOWN}")
val memberPublicKey = memberPrivateKey.xOnlyPublicKey().value.toHex()
+ // The group's own leaf at the delay its newest policy sets, which the
+ // request carries so every signer judges it by what the group signed.
+ // refusal() has already refused a group that is not open.
+ val policy = policyFor(database, chatRoomId) as? MemberWalletPolicyEvent.Policy.Open
+ ?: throw IllegalStateException("Cannot ask: ${Refusal.NOT_OFFERED}")
+
val walletPrivateKey = MemberWalletDerivation.generate()
val walletId = MemberWalletDerivation.walletId(walletPrivateKey.publicKey())
- val grant = GuardianDerivation.grant(groupKey.thresholdPublicKey, chatRoomId.lowercase(), groupKey.guardians, walletId)
+ val grant = GuardianDerivation.grant(groupKey.thresholdPublicKey, chatRoomId.lowercase(), groupKey.guardians, walletId, policy.delay)
val account = MemberWalletDerivation.account(walletPrivateKey.publicKey(), chain, grant)
val request = MemberWalletRequestEvent.build(
@@ -225,6 +250,7 @@ object MemberWalletManager {
account = account,
label = label,
createdAt = createdAt.epochSeconds,
+ policy = policy.event,
)
checkNotNull(MemberWalletRequestEvent.verified(request)) { "The request this device built does not check out" }
diff --git a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/nostr/wallet/MemberWalletRequestEvent.kt b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/nostr/wallet/MemberWalletRequestEvent.kt
index 912edf7f..71bdea21 100644
--- a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/nostr/wallet/MemberWalletRequestEvent.kt
+++ b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/nostr/wallet/MemberWalletRequestEvent.kt
@@ -81,6 +81,7 @@ object MemberWalletRequestEvent {
private const val CHANGE_MARKER = "change"
private const val LABEL_TAG = "label"
private const val POSSESSION_TAG = "possession"
+ private const val POLICY_TAG = "member_wallet_policy"
/** The tag of the possession signature's message. Frozen once a request carries one. */
private const val POSSESSION_HASH_TAG = "bennu/member-wallet/possession/v1"
@@ -101,6 +102,13 @@ object MemberWalletRequestEvent {
val guardians: List,
val label: String?,
val possession: ByteVector64,
+ /**
+ * The group's member-wallet policy the request was built under, whole and
+ * unverified -- or null for a request from before policies, which every
+ * signer now refuses and every reader of an old certificate still
+ * accepts. See `docs/member-wallet-delay.md`.
+ */
+ val policy: Event? = null,
)
/** A request that checks out on everything a reader can check without the group's key. */
@@ -109,6 +117,8 @@ object MemberWalletRequestEvent {
val reading: Reading,
/** The account the request opens, rederived from the wallet key -- never what it said. */
val account: GroupWalletDerivation.Account,
+ /** The open policy it was built under, verified as the group's own; null for a request from before policies. */
+ val policy: MemberWalletPolicyEvent.Policy.Open? = null,
)
/**
@@ -135,6 +145,8 @@ object MemberWalletRequestEvent {
account: GroupWalletDerivation.Account,
label: String?,
createdAt: Long = Clock.System.now().epochSeconds,
+ /** The group's open policy the grant was worked out under, carried whole. */
+ policy: Event? = null,
): Event {
val memberPublicKey = memberPrivateKey.xOnlyPublicKey().value.toHex()
val walletKey = walletPrivateKey.publicKey()
@@ -152,6 +164,7 @@ object MemberWalletRequestEvent {
arrayOf(DESCRIPTOR_TAG, account.receiveDescriptor, RECEIVE_MARKER),
arrayOf(DESCRIPTOR_TAG, account.changeDescriptor, CHANGE_MARKER),
label?.trim()?.takeIf { it.isNotEmpty() }?.let { arrayOf(LABEL_TAG, it.take(MAX_LABEL_LENGTH)) },
+ policy?.let { arrayOf(POLICY_TAG, it.toJson()) },
arrayOf(POSSESSION_TAG, possession.toHex()),
).toTypedArray()
@@ -173,6 +186,11 @@ object MemberWalletRequestEvent {
val label = labels.singleOrNull()?.getOrNull(1)?.takeIf { it.isNotBlank() && it.length <= MAX_LABEL_LENGTH }
if (labels.isNotEmpty() && label == null) return null
+ // Present and unreadable is not "built under no policy".
+ val policies = event.tags.filter { it.isNotEmpty() && it[0] == POLICY_TAG }
+ if (policies.size > 1) return null
+ val policy = policies.singleOrNull()?.let { tag -> tag.getOrNull(1)?.let { Event.fromJsonOrNull(it) } ?: return null }
+
Reading(
memberPublicKey = event.pubKey.lowercase(),
groupChatRoomId = single(ROOM_TAG)?.lowercase() ?: return null,
@@ -185,6 +203,7 @@ object MemberWalletRequestEvent {
guardians = GuardianTag.parseAll(event.tags)?.takeIf { it.isNotEmpty() } ?: return null,
label = label,
possession = single(POSSESSION_TAG)?.let { ByteVector64(it) } ?: return null,
+ policy = policy,
)
}.getOrNull()
@@ -197,7 +216,12 @@ object MemberWalletRequestEvent {
* 4. its nearest guardian is the group it asks, so a request cannot leave
* out the one group it is asking;
* 5. the wallet key, under those guardians, rederives the xpub and both
- * descriptors byte for byte.
+ * descriptors byte for byte;
+ * 6. a policy it carries is an open one the group it asks signed, and its
+ * nearest guardian's delay is that policy's -- `docs/member-wallet-delay.md`.
+ * A request carrying none still reads: certificates signed before
+ * policies embed one, and their wallets are guarded all the same. That
+ * a *new* request must carry one is the signers' rule, not a reader's.
*
* Whether the guardians are the ones the group grants is not here: only a
* device holding the group's key can say, and the group's signers do.
@@ -215,7 +239,13 @@ object MemberWalletRequestEvent {
val account = MemberWalletDerivation.account(reading.walletKey, reading.chain, reading.guardians)
if (account.xpub != reading.xpub || account.receiveDescriptor != reading.receiveDescriptor || account.changeDescriptor != reading.changeDescriptor) return null
- Verified(request = event, reading = reading, account = account)
+ val policy = reading.policy?.let { carried ->
+ val open = MemberWalletPolicyEvent.verify(carried, reading.groupChatRoomId) as? MemberWalletPolicyEvent.Policy.Open ?: return null
+ if (reading.guardians.first().delay != open.delay) return null
+ open
+ }
+
+ Verified(request = event, reading = reading, account = account, policy = policy)
}.getOrNull()
/**
diff --git a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/ui/composable/NewMemberWalletScreen.kt b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/ui/composable/NewMemberWalletScreen.kt
index e02cce7f..a73b37a0 100644
--- a/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/ui/composable/NewMemberWalletScreen.kt
+++ b/composeApp/src/commonMain/kotlin/com/machankura/bennu/compose/ui/composable/NewMemberWalletScreen.kt
@@ -1,5 +1,7 @@
package com.machankura.bennu.compose.ui.composable
+import bennu.composeapp.generated.resources.this_group_has_stopped_guarding_members_wallets
+import bennu.composeapp.generated.resources.this_group_doesn_t_guard_members_wallets
import com.machankura.bennu.compose.ui.composable.widgets.delayText
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
@@ -244,5 +246,7 @@ private fun refusalText(refusal: MemberWalletManager.Refusal): String = stringRe
MemberWalletManager.Refusal.GUARDIANS_UNREADABLE -> Res.string.this_group_s_guardian_keys_can_t_be_read_to_guard_a_wallet
MemberWalletManager.Refusal.NOT_ON_THIS_NETWORK -> Res.string.member_wallets_are_not_offered_on_this_network
MemberWalletManager.Refusal.CANNOT_WATCH -> Res.string.this_profile_cannot_watch_its_own_coins
+ MemberWalletManager.Refusal.NOT_OFFERED -> Res.string.this_group_doesn_t_guard_members_wallets
+ MemberWalletManager.Refusal.CLOSED -> Res.string.this_group_has_stopped_guarding_members_wallets
}
)
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/GroupFixtures.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/GroupFixtures.kt
index f92b4ffb..5cc8ab0d 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/GroupFixtures.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/GroupFixtures.kt
@@ -76,6 +76,16 @@ internal object GroupFixtures {
return signedAsRoom(group, template.kind, template.tags, template.content, createdAt)
}
+ /**
+ * [group] opened to its members' wallets at [delay]: the policy every member
+ * wallet test needs before a member can ask, since a group with none does
+ * not guard members' wallets. `docs/member-wallet-delay.md`, D8.
+ */
+ suspend fun openToMembers(db: BennuDatabase, group: KeyMaterial, delay: Long = GuardianDerivation.DEFAULT_DELAY, createdAt: Long = 1_600_000_000) {
+ if (db.chatRoomDao().findChatRoomById(roomOf(group)) == null) seedRoom(db, roomOf(group))
+ filePolicy(db, group, memberWalletPolicy(group, delay, createdAt))
+ }
+
/** [policy] filed as [group]'s room files a signed event: a `GroupSignedEvent` row. */
suspend fun filePolicy(db: BennuDatabase, group: KeyMaterial, policy: Event) {
db.groupSignedEventDao().upsert(
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletGuardianJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletGuardianJvmTest.kt
index 4d5ea6ae..effe0858 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletGuardianJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletGuardianJvmTest.kt
@@ -95,6 +95,7 @@ class MemberWalletGuardianJvmTest {
private suspend fun inRoom(material: fr.acinq.bitcoin.crypto.frost.KeyMaterial, certificate: Event? = null) {
signingRoom(db, material, members = listOf(memberPublicKey), subject = "#" + roomOf(material).take(4))
fileKeyState(db, material, certificate)
+ GroupFixtures.openToMembers(db, material)
}
private suspend fun fileSigned(certificate: Event) =
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPagesJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPagesJvmTest.kt
index 14d50912..35703654 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPagesJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPagesJvmTest.kt
@@ -63,6 +63,7 @@ class MemberWalletPagesJvmTest {
GroupFixtures.seedProfile(db, alicePublicKey, name = "alice")
signingRoom(db, group, members = listOf(alicePublicKey, bobPublicKey), holdsShare = false)
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
val certified = MemberWalletManager.request(db, groupRoom, alice, chain, label = "Savings")
certify(certified.requestJson)
@@ -80,8 +81,10 @@ class MemberWalletPagesJvmTest {
fun `the person's page lists every group here that guards them`(): Unit = runBlocking {
signingRoom(db, group, members = listOf(alicePublicKey))
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
signingRoom(db, parent, members = listOf(alicePublicKey), holdsShare = false, subject = "#Root")
fileKeyState(db, parent)
+ GroupFixtures.openToMembers(db, parent)
val wallet = MemberWalletManager.request(db, groupRoom, alice, chain, label = null)
val certificate = certify(wallet.requestJson)
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPolicyJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPolicyJvmTest.kt
index aef0b0e3..95e53d1a 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPolicyJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletPolicyJvmTest.kt
@@ -1,5 +1,15 @@
package com.machankura.bennu.compose.managers
+import kotlin.test.assertTrue
+import kotlin.test.assertNotNull
+import kotlin.test.assertFailsWith
+import com.machankura.bennu.compose.managers.GroupFixtures.thresholdKeyOf
+import com.machankura.bennu.compose.nostr.wallet.MemberWalletRequestEvent
+import com.vitorpamplona.quartz.nip01Core.core.Event
+import fr.acinq.secp256k1.Hex
+import fr.acinq.bitcoin.PrivateKey
+import fr.acinq.bitcoin.ByteVector32
+import fr.acinq.bitcoin.Chain
import androidx.room3.Room
import com.machankura.bennu.compose.database.BennuDatabase
import com.machankura.bennu.compose.database.builder.getRoomDatabase
@@ -68,4 +78,61 @@ class MemberWalletPolicyJvmTest {
val closed = memberWalletPolicy(group, null)
assertEquals("no new ones ยท wallets already guarded stay guarded", ProposedEvent.summarize(closed).detail)
}
+
+ // ---- Phase 4: the member builds under it -------------------------------
+
+ private val parent = keyMaterial("9a9e")
+ private val chain = Chain.Regtest
+ private val member = PrivateKey(ByteVector32(Hex.decode("3e3be7".padStart(64, '0'))))
+ private val memberPublicKey = member.xOnlyPublicKey().value.toHex()
+
+ private suspend fun asMember() {
+ GroupFixtures.signingRoom(db, group, members = listOf(memberPublicKey), holdsShare = false)
+ GroupFixtures.fileKeyState(db, group, GroupFixtures.guardedCertificate(parent, group))
+ }
+
+ @Test
+ fun `a member asks only a group that has opened`(): Unit = runBlocking {
+ asMember()
+ assertEquals(MemberWalletManager.Refusal.NOT_OFFERED, MemberWalletManager.refusal(db, groupRoom, canSign = true, chain))
+ assertFailsWith { MemberWalletManager.request(db, groupRoom, member, chain, label = null) }
+ assertNull(MemberWalletManager.delaysOf(db, groupRoom))
+
+ filePolicy(db, group, memberWalletPolicy(group, null))
+ assertEquals(MemberWalletManager.Refusal.CLOSED, MemberWalletManager.refusal(db, groupRoom, canSign = true, chain))
+ assertFailsWith { MemberWalletManager.request(db, groupRoom, member, chain, label = null) }
+ assertTrue(db.memberWalletDao().getByOwner(memberPublicKey).isEmpty(), "a refused request makes no key")
+ }
+
+ @Test
+ fun `a request is built at the group's delay and carries the policy it was built under`(): Unit = runBlocking {
+ asMember()
+ val policy = memberWalletPolicy(group, 4_320)
+ filePolicy(db, group, policy)
+
+ assertNull(MemberWalletManager.refusal(db, groupRoom, canSign = true, chain))
+ assertEquals(listOf(4_320L, GuardianDerivation.DEFAULT_DELAY), MemberWalletManager.delaysOf(db, groupRoom), "the parent's keeps its own")
+
+ val wallet = MemberWalletManager.request(db, groupRoom, member, chain, label = null)
+ val verified = assertNotNull(MemberWalletRequestEvent.verified(Event.fromJson(wallet.requestJson)))
+ assertEquals(4_320L, verified.reading.guardians.first().delay)
+ assertEquals(policy.id, verified.policy?.event?.id)
+ }
+
+ @Test
+ fun `a request whose leaf disagrees with the policy it carries does not check out`(): Unit = runBlocking {
+ asMember()
+ val walletKey = MemberWalletDerivation.generate()
+ val walletId = MemberWalletDerivation.walletId(walletKey.publicKey())
+ val atDefault = GuardianDerivation.grant(thresholdKeyOf(group), groupRoom, emptyList(), walletId)
+ val account = MemberWalletDerivation.account(walletKey.publicKey(), chain, atDefault)
+ fun build(policy: Event?) = MemberWalletRequestEvent.build(member, groupRoom, walletKey, account, label = null, policy = policy)
+
+ assertNull(MemberWalletRequestEvent.verified(build(memberWalletPolicy(group, 4_320))), "built at 12 under a policy of 4,320")
+ assertNull(MemberWalletRequestEvent.verified(build(memberWalletPolicy(group, null))), "built under a closed policy")
+ assertNull(MemberWalletRequestEvent.verified(build(memberWalletPolicy(stranger, 12))), "under another group's policy")
+ assertNotNull(MemberWalletRequestEvent.verified(build(memberWalletPolicy(group, 12))))
+ // A request from before policies still reads: old certificates embed one.
+ assertNotNull(MemberWalletRequestEvent.verified(build(null)))
+ }
}
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletRequestJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletRequestJvmTest.kt
index da9ab233..d4cb80c7 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletRequestJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletRequestJvmTest.kt
@@ -58,6 +58,7 @@ class MemberWalletRequestJvmTest {
private suspend fun asMember(knowsKey: Boolean = true) {
signingRoom(db, group, members = listOf(memberPublicKey), holdsShare = false)
if (knowsKey) fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
}
private suspend fun requestsSent(): List =
@@ -104,6 +105,7 @@ class MemberWalletRequestJvmTest {
// A share-holding member: one of the ceremony's participants on this device.
signingRoom(db, group, members = listOf(memberPublicKey))
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
val wallet = MemberWalletManager.request(db, groupRoom, member, chain, label = null)
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSigningJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSigningJvmTest.kt
index 7014f273..0a0391ca 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSigningJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSigningJvmTest.kt
@@ -68,6 +68,7 @@ class MemberWalletSigningJvmTest {
private suspend fun groupRoomHere() = signingRoom(db, group, members = listOf(memberPublicKey)).also {
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
}
private fun request(guardians: List = grant, by: PrivateKey = member, asking: String = groupRoom) =
@@ -133,6 +134,7 @@ class MemberWalletSigningJvmTest {
// A root group: no certificate, so nothing to pass down.
signingRoom(db, group, members = listOf(memberPublicKey))
fileKeyState(db, group, certificate = null)
+ GroupFixtures.openToMembers(db, group)
assertNull(refusal(request(guardians = grant.take(1))))
assertEquals("grants guardian keys this group does not", refusal(request()))
}
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSpendJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSpendJvmTest.kt
index f7a61e7d..6577863c 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSpendJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletSpendJvmTest.kt
@@ -67,6 +67,7 @@ class MemberWalletSpendJvmTest {
private suspend fun certifiedWallet(): MemberWallet {
signingRoom(db, group, members = listOf(memberPublicKey), holdsShare = false)
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
val wallet = MemberWalletManager.request(db, groupRoom, member, chain, label = null)
val template = MemberWalletCertificateEvent.template(Event.fromJson(wallet.requestJson))
val signed = signedAsRoom(group, template.kind, template.tags, template.content, template.createdAt)
@@ -123,6 +124,7 @@ class MemberWalletSpendJvmTest {
fun `nothing is signed before a group certifies the wallet, or without its key`(): Unit = runBlocking {
signingRoom(db, group, members = listOf(memberPublicKey), holdsShare = false)
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
val asked = MemberWalletManager.request(db, groupRoom, member, chain, label = null)
val account = assertNotNull(MemberWalletManager.walletOf(db, memberPublicKey, asked.walletId)).account
val built = assertIs(GroupSpendBuilder.sendAll(stateWith(account), destination, 3L, emptySet()))
diff --git a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletsJvmTest.kt b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletsJvmTest.kt
index d9e9e823..27bd1eec 100644
--- a/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletsJvmTest.kt
+++ b/composeApp/src/jvmTest/kotlin/com/machankura/bennu/compose/managers/MemberWalletsJvmTest.kt
@@ -53,6 +53,7 @@ class MemberWalletsJvmTest {
private suspend fun setUp(signer: Boolean = false) {
signingRoom(db, group, members = listOf(memberPublicKey), holdsShare = signer)
fileKeyState(db, group, guardedCertificate(parent, group))
+ GroupFixtures.openToMembers(db, group)
}
private suspend fun certify(request: Event) {