fix(frost): a knock past the nonces is for the signers, not the quiet

A resend had one idea of who it was for at every stage -- the share
holders it had heard nothing at all from -- and that is a question only
the first stage can answer. A session reaches
COLLECTING_PARTIAL_SIGNATURES because enough members offered a nonce, so
every member who could be holding it up has been heard from: the set came
back holding the members who were never chosen and owe nothing, while the
chosen signer whose partial signature went missing was named nowhere.
Once the unchosen had answered or refused the set was empty, and the
control gave up before it reached the branch written for the stall it was
meant to repair.

So the set asks what the stage can answer. Of the signers the coordinator
chose, who has yet to send a partial signature -- which is the half of a
resend only they can carry out, since a partial signature is read by
nobody but the coordinator and no other device can repeat it. COMPLETE
keeps the old reading, and correctly: the signature is the coordinator's
own and nobody answers it.

The screen now asks the manager who is owed rather than deriving it from
the rows beside the button, the way it already asks about approvals: the
same reading decides whether a resend publishes anything, and two copies
of a rule that changes with the stage is a screen offering a knock the
manager would refuse. The transcript line and the notice say what the
members named are short of, since past the nonces they have answered once
already.

The test that looked like it covered this passed because it wrote the
stage into the row with no nonce on file anywhere -- a state the protocol
cannot produce, and exactly the state that hid the bug. It now reaches
the stage by offering a real nonce.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Kgothatso NgakoandClaude Opus 5 committed 2026-10-08 14:32:09 -05:00
1 parent ce6646201e
commit 1e59fd2334
10 files changed
+342 -94

No files matched your search

@@ -200,6 +200,10 @@
<string name="everyone_has_answered_this_session">Everyone has answered. There is nobody left to ask.</string>
<string name="one_member_has_not_answered">One member has not answered. They may never have received it.</string>
<string name="members_have_not_answered">%1$s members have not answered. They may never have received it.</string>
<string name="asked_again_to_sign">Asked the signers who have not signed their part to take another look</string>
<string name="one_signer_has_not_signed">One signer has not sent their part. They may never have received the signer set.</string>
<string name="signers_have_not_signed">%1$s signers have not sent their part. They may never have received the signer set.</string>
<string name="everyone_has_signed_this_session">Every signer has sent their part. There is nobody left to ask.</string>
<string name="asked_again_recently">Asked again just now. You can ask again in a few minutes.</string>
<string name="read_to_the_end_of_the_list_to_sign">Read to the end of the list to sign.</string>
<string name="recovery_phrase">Recovery phrase</string>