feat(proposals): tell the two open stages apart, because they are not alike
"In progress" was one chip over two situations that ask different things of the reader, and collapsing them was the wrong call. Short of members, a proposal can still die of indifference: refusals are counted against `declinesThatAbandon`, so one more may end it, and a member who is offline is indistinguishable from one who has not looked. It is also the only stage the coordinator's resend is for. These are the proposals somebody may have to do something about. Once the signer set is written, none of that is true. `signerIds` is written once and never revised, so no further refusal is counted against it, and what is left is arithmetic the chosen devices have already committed to. Where one asks whether this will happen, the other says it is happening. So: WAITING_ON_MEMBERS and BEING_SIGNED, named for what the reader is waiting on rather than for the protocol step -- "collecting nonces" is true and says nothing. The icons carry it as well as the labels, people against machinery, which is the only signal a monochrome display has. What is *not* split, and the comments say why: whether this device was picked to sign, and whether the reader agreed or declined. Those are facts about the reader rather than states of the proposal, so they stay a sentence on the row. Splitting on them would be splitting every state by who is looking. The classification is now the stage plus one, which is the shape it was always going to take -- the one being NEEDS_YOU, which no stage can express. Six chips means the last two now sit past the fold at phone widths, so the screen test measures order only over what the viewport lays out and the full lifecycle order is pinned on the enum, where no viewport is involved. 1342 jvm tests pass, the Android target compiles, all audit budgets met. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
18c6245181
commit
13ae0a1def
9 files changed
+286
-81
No files matched your search
@@ -40,6 +40,7 @@
|
||||
<string name="backup_confirmation">Backup confirmation</string>
|
||||
<string name="be_sure_to_keep_this_nsec_safe">Be sure to keep this nsec safe.</string>
|
||||
<string name="be_the_first_to_comment">Be the first to comment.</string>
|
||||
<string name="being_signed">Being signed</string>
|
||||
<string name="bio">Bio</string>
|
||||
<string name="bip39_seed_with_the_standard_bip84">BIP39 seed with the standard BIP84 derivation path. The profile\'s nostr key comes off the same seed, so these 12 words restore both.</string>
|
||||
<string name="block_user">Block user</string>
|
||||
@@ -110,7 +111,6 @@
|
||||
<string name="i_have_saved_my_recovery_phrase_somewhere">I have saved my recovery phrase somewhere safe.</string>
|
||||
<string name="i_understand_that_if_i_lose_this_phone_and">I understand that if I lose this phone and my recovery phrase, I lose this profile and the funds in its wallet.</string>
|
||||
<string name="if_you_are_new_to_torch_or_just_want_to">If you are new to Curare or just want to create a fresh profile</string>
|
||||
<string name="in_progress">In progress</string>
|
||||
<string name="initial_version_label">Initial version label</string>
|
||||
<string name="input_npub_or_nip05">Input npub... or nip05</string>
|
||||
<string name="introduce_yourself">Introduce yourself</string>
|
||||
@@ -156,6 +156,8 @@
|
||||
<string name="name_of_artifact">Name of artifact</string>
|
||||
<string name="needs_you">Needs you</string>
|
||||
<string name="network_relays">Network relays</string>
|
||||
<string name="no_proposal_is_being_signed">No proposal is being signed.</string>
|
||||
<string name="no_proposal_is_waiting_on_members">No proposal is waiting on members.</string>
|
||||
<string name="no_wallet_is_open_on_this_device_so_there">No wallet is open on this device, so there is no phrase to show.</string>
|
||||
<string name="not_backed_up_yet">Not backed up yet</string>
|
||||
<string name="new_chat">New chat</string>
|
||||
@@ -172,7 +174,6 @@
|
||||
<string name="no_one_to_add_yet">No one to add yet.</string>
|
||||
<string name="no_projects_exists_in_this_group">No projects exists in this group.</string>
|
||||
<string name="no_proposal_has_been_abandoned">No proposal has been abandoned.</string>
|
||||
<string name="no_proposal_is_in_progress">No proposal is in progress.</string>
|
||||
<string name="no_translations_yet">No translations yet.</string>
|
||||
<string name="no_versions">No versions.</string>
|
||||
<string name="not_now">Not now</string>
|
||||
@@ -310,6 +311,7 @@
|
||||
<string name="view_invites">View invites</string>
|
||||
<string name="waiting_for_you">Waiting for you</string>
|
||||
<string name="waiting_for_your_signature">Waiting for your signature</string>
|
||||
<string name="waiting_on_members">Waiting on members</string>
|
||||
<string name="we_are_looking_for_your_profile_on_as_many">We are looking for your profile on as many relays as possible. Nostr aims to be decentralized by distributing data to multiple nodse.</string>
|
||||
<string name="we_are_searching_the_internet_to_find_your">We are searching the internet to find your profile and complete sign in.</string>
|
||||
<string name="we_couldn_t_find_the_local_profile_please">We couldn't find the local profile. Please try again later.</string>
|
||||
|
||||
Reference in new issue
Block a user