Second of six commits adding the frost_enrollment module. This one is scaffolding only: the five entry points are stubs that validate their pointer arguments, zero their outputs and return 0. What is being verified here is that the module configures, compiles, links, exports its symbols and registers its test module in both build systems -- so that the next commit changes nothing but arithmetic. Ordering is the one thing in this commit that can go silently wrong, and it goes wrong in opposite directions in the two build systems: - configure.ac executes its `if` blocks in file order, and enable_module_frost defaults to no (configure.ac:243). A block placed after the frost block at :601 that sets enable_module_frost=yes flips the variable too late: AM_CONDITIONAL goes true, so the header is installed and the Makefile fragment is pulled in, but -DENABLE_MODULE_FROST=1 is never appended, so src/secp256k1.c never includes frost's implementation and every secp256k1_frost_* symbol fails to link. The new block therefore goes ahead of both the frost block and prefractal's, which documents the same trap. - src/CMakeLists.txt processes dependents FIRST, so the same block goes above the FROST block there, beside prefractal's. Verified rather than assumed: configuring with ONLY --enable-module-frost-enrollment emits -DENABLE_MODULE_FROST=1 alongside -DENABLE_MODULE_FROST_ENROLLMENT=1, and the CMake summary prints "frost ON" for the same configuration -- the latter is what the PARENT_SCOPE lift buys, since the summary runs after add_subdirectory(src) and would otherwise report a module it is compiling in as OFF. The dependency guard is prefractal's implies-frost idiom, copied verbatim along with its reasoning. frost is default-OFF, so the `test x"$enable_module_frost" = x"no"` / `DEFINED X AND NOT X` guard every other module uses -- which reads as "the user disabled it explicitly" for a default-ON dependency -- is true by default here and cannot tell an explicit --disable-module-frost from the default once both are in the cache. Enabling frost-enrollment simply implies frost, with no error. The one frost-module change in the whole series is in this commit: src/modules/frost/session.h gains a declaration for secp256k1_frost_sort_ids, which is defined at session_impl.h:517 and declared nowhere. The params hash needs it to canonicalize identifier order. Prefractal reaches frost's statics through translation-unit ordering alone; rather than inherit reuse-by-link-order, this declares the function where keygen.h:48 already declares derive_pubshare_at, so the reuse goes through an interface. No behavior change: it is a declaration for an existing static definition in the same TU. CI wiring is two files, and skipping either half fails quietly: - ci/ci.sh gets FROST_ENROLLMENT in the reproduction header's variable list and --enable-module-frost-enrollment="$FROST_ENROLLMENT" after the prefractal line. - .github/workflows/ci.yml gets FROST_ENROLLMENT at every PREFRACTAL site: the global default, 11 inline matrix entries and 10 job-level env blocks. Without the default, ci.sh runs under set -eux with an empty $FROST_ENROLLMENT, passes --enable-module-frost-enrollment="", `test x"" = x"yes"` is false, and the module is off in all of CI while ci.sh visibly has the plumbing. Verified programmatically over the parsed workflow: across the 106 effective job contexts, PREFRACTAL and FROST_ENROLLMENT now agree in every single one (45 set to yes, no mismatches), no context sets FROST_ENROLLMENT without FROST or without EXPERIMENTAL, and no context leaves it undefined. ci.sh passes sh -n. The stub test is not a placeholder that has to be deleted later: every entry point must reject an empty helper set and leave its output zeroed, which is true of the stubs and stays true of the finished implementation, so it doubles as the check that all five symbols are reachable from the test binary. Verification. Autotools: ./autogen.sh, then a frost-enrollment-only configure and a full configure with frost, chilldkg, iceberg, prefractal and frost-enrollment all on -- both build with zero warnings under the project's -Werror-grade flag set, ./tests and ./exhaustive_tests exit 0, and `./tests -l` lists the frost_enrollment module. CMake: configure with -DSECP256K1_EXPERIMENTAL=ON -DSECP256K1_ENABLE_MODULE_FROST_ENROLLMENT=ON builds clean and ctest passes 391 tests. nm shows the five new symbols exported from libsecp256k1.so; tools/symbol-check.py could not be run here because python3-lief is not installed in this environment, but all five carry the required secp256k1_ prefix. make dist succeeds and the tarball carries src/modules/frost_enrollment/frost_enrollment.md alongside the other module documents. One unrelated observation from this build: a stale src/ctime_tests-ctime_tests.o left over from an earlier configure with a different module set will fail to link, because automake does not track CPPFLAGS changes across reconfigures. make clean between configurations with different module sets, not a fault in this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
166 lines
4.8 KiB
Bash
Executable File
166 lines
4.8 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
set -eux
|
|
|
|
export LC_ALL=C
|
|
|
|
# Print commit and relevant CI environment to allow reproducing the job outside of CI.
|
|
git show --no-patch
|
|
print_environment() {
|
|
# Turn off -x because it messes up the output
|
|
set +x
|
|
# There are many ways to print variable names and their content. This one
|
|
# does not rely on bash.
|
|
for var in WERROR_CFLAGS MAKEFLAGS BUILD \
|
|
ECMULTWINDOW ECMULTGENKB ASM WIDEMUL WITH_VALGRIND EXTRAFLAGS \
|
|
EXPERIMENTAL ECDH RECOVERY EXTRAKEYS SCHNORRSIG MUSIG SCHNORRSIG_HALFAGG ELLSWIFT \
|
|
ECDSA_S2C GENERATOR RANGEPROOF SURJECTIONPROOF WHITELIST ECDSAADAPTOR BPPP \
|
|
FROST CHILLDKG ICEBERG PREFRACTAL FROST_ENROLLMENT SECP256K1_TEST_ITERS BENCH SECP256K1_BENCH_ITERS CTIMETESTS SYMBOL_CHECK \
|
|
EXAMPLES \
|
|
HOST WRAPPER_CMD \
|
|
CC CFLAGS CPPFLAGS AR NM \
|
|
UBSAN_OPTIONS ASAN_OPTIONS LSAN_OPTIONS
|
|
do
|
|
eval "isset=\${$var+x}"
|
|
if [ -n "$isset" ]; then
|
|
eval "val=\${$var}"
|
|
# shellcheck disable=SC2154
|
|
printf '%s="%s" ' "$var" "$val"
|
|
fi
|
|
done
|
|
echo "$0"
|
|
set -x
|
|
}
|
|
print_environment
|
|
|
|
env >> test_env.log
|
|
|
|
# If gcc is requested, assert that it's in fact gcc (and not some symlinked Apple clang).
|
|
case "${CC:-undefined}" in
|
|
*gcc*)
|
|
$CC -v 2>&1 | grep -q "gcc version" || exit 1;
|
|
;;
|
|
esac
|
|
|
|
if [ -n "${CC+x}" ]; then
|
|
# The MSVC compiler "cl" doesn't understand "-v"
|
|
$CC -v || true
|
|
fi
|
|
if [ "$WITH_VALGRIND" = "yes" ]; then
|
|
valgrind --version
|
|
fi
|
|
if [ -n "$WRAPPER_CMD" ]; then
|
|
$WRAPPER_CMD --version
|
|
fi
|
|
|
|
./autogen.sh
|
|
|
|
./configure \
|
|
--enable-experimental="$EXPERIMENTAL" \
|
|
--with-test-override-wide-multiply="$WIDEMUL" --with-asm="$ASM" \
|
|
--with-ecmult-window="$ECMULTWINDOW" \
|
|
--with-ecmult-gen-kb="$ECMULTGENKB" \
|
|
--enable-module-ecdh="$ECDH" --enable-module-recovery="$RECOVERY" \
|
|
--enable-module-ellswift="$ELLSWIFT" \
|
|
--enable-module-extrakeys="$EXTRAKEYS" \
|
|
--enable-module-ecdsa-s2c="$ECDSA_S2C" \
|
|
--enable-module-bppp="$BPPP" \
|
|
--enable-module-rangeproof="$RANGEPROOF" --enable-module-surjectionproof="$SURJECTIONPROOF" --enable-module-whitelist="$WHITELIST" --enable-module-generator="$GENERATOR" \
|
|
--enable-module-schnorrsig="$SCHNORRSIG" --enable-module-ecdsa-adaptor="$ECDSAADAPTOR" \
|
|
--enable-module-musig="$MUSIG" \
|
|
--enable-module-schnorrsig-halfagg="$SCHNORRSIG_HALFAGG" \
|
|
--enable-module-frost="$FROST" \
|
|
--enable-module-chilldkg="$CHILLDKG" \
|
|
--enable-module-iceberg="$ICEBERG" \
|
|
--enable-module-prefractal="$PREFRACTAL" \
|
|
--enable-module-frost-enrollment="$FROST_ENROLLMENT" \
|
|
--enable-examples="$EXAMPLES" \
|
|
--enable-ctime-tests="$CTIMETESTS" \
|
|
--with-valgrind="$WITH_VALGRIND" \
|
|
--host="$HOST" $EXTRAFLAGS
|
|
|
|
# We have set "-j<n>" in MAKEFLAGS.
|
|
build_exit_code=0
|
|
make > make.log 2>&1 || build_exit_code=$?
|
|
cat make.log
|
|
if [ $build_exit_code -ne 0 ]; then
|
|
case "${CC:-undefined}" in
|
|
*snapshot*)
|
|
# Ignore internal compiler errors in gcc-snapshot and clang-snapshot
|
|
grep -e "internal compiler error:" -e "PLEASE submit a bug report" make.log
|
|
exit $?
|
|
;;
|
|
*)
|
|
exit 1
|
|
;;
|
|
esac
|
|
fi
|
|
|
|
# Print information about binaries so that we can see that the architecture is correct
|
|
file *tests* || true
|
|
file bench* || true
|
|
file .libs/* || true
|
|
|
|
if [ "$SYMBOL_CHECK" = "yes" ]
|
|
then
|
|
python3 --version
|
|
case "$HOST" in
|
|
*mingw*)
|
|
ls -l .libs
|
|
python3 ./tools/symbol-check.py .libs/libsecp256k1-*.dll
|
|
;;
|
|
*)
|
|
python3 ./tools/symbol-check.py .libs/libsecp256k1.so
|
|
;;
|
|
esac
|
|
fi
|
|
|
|
# This tells `make check` to wrap test invocations.
|
|
export LOG_COMPILER="$WRAPPER_CMD"
|
|
|
|
make "$BUILD"
|
|
|
|
# Using the local `libtool` because on macOS the system's libtool has nothing to do with GNU libtool
|
|
EXEC='./libtool --mode=execute'
|
|
if [ -n "$WRAPPER_CMD" ]
|
|
then
|
|
EXEC="$EXEC $WRAPPER_CMD"
|
|
fi
|
|
|
|
if [ "$BENCH" = "yes" ]
|
|
then
|
|
{
|
|
$EXEC ./bench_ecmult
|
|
$EXEC ./bench_internal
|
|
$EXEC ./bench
|
|
if [ "$BPPP" = "yes" ]
|
|
then
|
|
$EXEC ./bench_bppp
|
|
fi
|
|
if [ "$ICEBERG" = "yes" ]
|
|
then
|
|
$EXEC ./bench_iceberg
|
|
fi
|
|
} >> bench.log 2>&1
|
|
fi
|
|
|
|
if [ "$CTIMETESTS" = "yes" ]
|
|
then
|
|
if [ "$WITH_VALGRIND" = "yes" ]; then
|
|
./libtool --mode=execute valgrind --error-exitcode=42 ./ctime_tests > ctime_tests.log 2>&1
|
|
else
|
|
$EXEC ./ctime_tests > ctime_tests.log 2>&1
|
|
fi
|
|
fi
|
|
|
|
# Rebuild precomputed files (if not cross-compiling).
|
|
if [ -z "$HOST" ]
|
|
then
|
|
make clean-precomp clean-testvectors
|
|
make precomp testvectors
|
|
fi
|
|
|
|
# Check that no repo files have been modified by the build.
|
|
# (This fails for example if the precomp files need to be updated in the repo.)
|
|
git diff --exit-code
|