517 Commits

Author SHA1 Message Date
Tim Ruffing
95c31389fc Test for rejection of trailing bytes in range proofs 2018-05-24 13:29:36 +02:00
Tim Ruffing
5fd8271f03 Test for rejection of trailing bytes in surjection proofs 2018-05-23 15:59:01 +02:00
Tim Ruffing
af7d4b0744 Reject surjection proofs with trailing garbage 2018-05-23 14:56:14 +02:00
datavetaren
6e7db6fd3b Minor bugfix. Wrong length due to NUL character. 2018-05-16 05:02:21 +02:00
Jonas Nick
410326df67 Add whitelisting benchmark 2018-04-17 22:06:06 +00:00
Gregory Sanders
7b05707c8f add whitelist_impl.h to include for dist 2018-04-05 16:39:34 -07:00
Andrew Poelstra
bad5b3dc92 generator: add API tests 2018-04-05 16:39:34 -07:00
Andrew Poelstra
1c966a2989 generator: remove unnecessary ARG_CHECK from generate() 2018-04-05 16:39:34 -07:00
Gregory Sanders
dd13b2b439 Fix generator makefile
Include test_impl.h
2018-04-05 16:39:34 -07:00
Jonas Nick
3d6ac31103 Add n_keys argument to whitelist_verify 2018-04-05 16:39:34 -07:00
Jonas Nick
ee1e30de90 Fix checks of whitelist serialize/parse arguments 2018-04-05 16:39:34 -07:00
Andrew Poelstra
c28edd75fc whitelist: fix serialize/parse API to take serialized length 2018-04-05 16:39:34 -07:00
Andrew Poelstra
0ba915f214 rangeproof: add API tests 2018-04-05 16:39:34 -07:00
Andrew Poelstra
1bb1723d4e surjectionproof: rename unit test functions to be more consistent with other modules 2018-04-05 16:39:34 -07:00
Andrew Poelstra
01a8848609 surjectionproof: add API unit tests 2018-04-05 16:39:34 -07:00
Andrew Poelstra
0ca14dcca0 surjectionproof: tests_impl.h s/assert/CHECK/g 2018-04-05 16:39:34 -07:00
Andrew Poelstra
995e5b709f rangeproof: fix memory leak in unit tests 2018-04-05 16:39:34 -07:00
Andrew Poelstra
88e52d6eec add surjection proof module
Includes fix and tests by Jonas Nick.
2018-04-05 16:39:34 -07:00
Andrew Poelstra
1a0ae1b0af Implement ring-signature based whitelist delegation scheme 2018-04-05 16:39:34 -07:00
Andrew Poelstra
f948ca216d rangeproof: several API changes
* add summing function for blinded generators
* drop `excess` and `gen` from `verify_tally`
* add extra_commit to rangeproof sign and verify
2018-04-05 16:39:34 -07:00
Pieter Wuille
c3db107c44 Expose generator in pedersen/rangeproof API 2018-04-05 16:39:34 -07:00
Pieter Wuille
c2f471f11d Constant-time generator module 2018-04-05 16:39:34 -07:00
Andrew Poelstra
5912d2665f rangeproof: expose sidechannel message field in the signing API
Including a fix by Jonas Nick.
2018-04-05 16:39:33 -07:00
Andrew Poelstra
e28302cbd7 [RANGEPROOF BREAK] Use quadratic residue for tie break and modularity cleanup
Switch to secp256k1_pedersen_commitment by Andrew Poelstra.
Switch to quadratic residue based disambiguation by Pieter Wuille.
2018-04-05 16:39:33 -07:00
Andrew Poelstra
e596d3a389 Get rid of precomputed H tables (Pieter Wuille) 2018-04-05 16:39:33 -07:00
Gregory Maxwell
a6dd429dc7 Pedersen commitments, borromean ring signatures, and ZK range proofs.
This commit adds three new cryptosystems to libsecp256k1:

Pedersen commitments are a system for making blinded commitments
 to a value.  Functionally they work like:
  commit_b,v = H(blind_b || value_v),
 except they are additively homorphic, e.g.
  C(b1, v1) - C(b2, v2) = C(b1 - b2, v1 - v2) and
  C(b1, v1) - C(b1, v1) = 0, etc.
 The commitments themselves are EC points, serialized as 33 bytes.
 In addition to the commit function this implementation includes
 utility functions for verifying that a set of commitments sums
 to zero, and for picking blinding factors that sum to zero.
 If the blinding factors are uniformly random, pedersen commitments
 have information theoretic privacy.

Borromean ring signatures are a novel efficient ring signature
 construction for AND/OR admissions policies (the code here implements
 an AND of ORs, each of any size).  This construction requires
 32 bytes of signature per pubkey used plus 32 bytes of constant
 overhead. With these you can construct signatures like "Given pubkeys
 A B C D E F G, the signer knows the discrete logs
 satisifying (A || B) & (C || D || E) & (F || G)".

ZK range proofs allow someone to prove a pedersen commitment is in
 a particular range (e.g. [0..2^64)) without revealing the specific
 value.  The construction here is based on the above borromean
 ring signature and uses a radix-4 encoding and other optimizations
 to maximize efficiency.  It also supports encoding proofs with a
 non-private base-10 exponent and minimum-value to allow trading
 off secrecy for size and speed (or just avoiding wasting space
 keeping data private that was already public due to external
 constraints).

A proof for a 32-bit mantissa takes 2564 bytes, but 2048 bytes of
 this can be used to communicate a private message to a receiver
 who shares a secret random seed with the prover.
2018-04-05 16:39:33 -07:00
Greg Maxwell
26156da781 Add 64-bit integer utilities 2018-04-05 16:39:33 -07:00
Andrew Poelstra
6fe50439ae scratch: add stack frame support 2018-04-05 22:49:29 +00:00
Andrew Poelstra
7c1b91ba4b parameterize ecmult_const over input size 2018-04-05 21:05:13 +00:00
Pieter Wuille
dbc3ddd5e2
Merge #513: Increase sparsity of pippenger fixed window naf representation
ec0a7b3 Don't touch leading zeros in wnaf_fixed. (Jonas Nick)
9e36d1b Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. (Jonas Nick)
96f68a0 Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros. (Jonas Nick)
6dbb007 Increase sparsity of pippenger fixed window naf representation (Jonas Nick)

Pull request description:

  Fixes #506

Tree-SHA512: 49a237a7d09c0c376ba4e6b1f522b9aff2517e420dfef9df810fd5ba920e0b98be8fe3f730b32e41b4aef475bc4cf3b13220024bd8d6f40c2744e6f392ff97a8
2018-04-05 09:46:08 -07:00
Pieter Wuille
fb9271dcf0
Merge #510: add a couple missing consts to ecmult_pippenger_wnaf
9b3ff03 add a couple missing `const`s to ecmult_pippenger_wnaf (Andrew Poelstra)

Pull request description:

Tree-SHA512: a58458bb4cb1af357b13a506ce8720ce9ecd0c1771a49d9f3ce9398ba7afc56977d722bbd30a63c7c76e63e659ed956d5e82ff762efc4b49488adf0756dc656a
2018-03-26 18:28:56 -07:00
Jonas Nick
ec0a7b3ae3 Don't touch leading zeros in wnaf_fixed. 2018-03-23 14:52:13 +00:00
Jonas Nick
9e36d1bfe2 Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. 2018-03-23 14:52:02 +00:00
Jonas Nick
96f68a0afc Don't invert scalar in wnaf_fixed when it is even because a caller might
intentionally give a scalar with many leading zeros.
2018-03-23 14:51:53 +00:00
Dimitris Apostolou
9b7c47a21e
Fix typo 2018-03-05 18:53:33 +02:00
Jonas Nick
6dbb007869 Increase sparsity of pippenger fixed window naf representation 2018-03-01 18:20:36 +00:00
Andrew Poelstra
9b3ff0309d add a couple missing consts to ecmult_pippenger_wnaf 2018-02-24 17:29:34 +00:00
Gregory Maxwell
7f9c1a1565
Merge #498: tests: Avoid calling fclose(...) with an invalid argument
5aae5b5 Avoid calling fclose(...) with an invalid argument (practicalswift)

Pull request description:

  Avoid calling `fclose(...)` with an invalid argument.

Tree-SHA512: f1a057b8c52089a3af1d9bfe97b751a4003b944d293147855eca452d1766c4ead5701d06f546153e654c9cb07b3fe2bcc4e28c8a54a27263d1e2434be123ca3b
2018-02-06 23:04:51 +00:00
Gregory Maxwell
f99aa8d4d3
Merge #499: tests: Make sure we get the requested number of bytes from /dev/urandom
82a96e4 tests: Make sure we get the requested number of bytes from /dev/urandom (practicalswift)

Pull request description:

  Make sure we get the requested number of bytes from `/dev/urandom`.

Tree-SHA512: 1b035942fd2a6ee2423fb2a2a0a0f294682c51434f86e5c106fb493d77f45aa8070662190aca6441fe389b8cdcc132d432517b8e826be2ac530a1511cd0c8919
2018-02-06 23:00:25 +00:00
practicalswift
82a96e4587 tests: Make sure we get the requested number of bytes from /dev/urandom 2018-01-12 11:24:43 +01:00
practicalswift
5aae5b5bb2 Avoid calling fclose(...) with an invalid argument 2018-01-12 11:18:25 +01:00
Alexander Block
31abd3ab8d Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
The only reason OpenSSL 1.1 was not supported was the removal of direct
access to r and s in ECDSA_SIG. This commit adds a simplified version of
ECDSA_SIG_get0 for < 1.1 that can be used like ECDSA_SIG_get0 in >= 1.1
2017-12-28 11:36:24 +01:00
Pieter Wuille
c95f6f1360
Merge #487: fix tests typo, s/changed/unchanged
0e96cdc fix typo, s/changed/unchanged (Daniel Cousens)

Pull request description:

Tree-SHA512: 023f04d3743318123977d1c4600d664e2b7578ad973db54b9e65629344be087949540b3450ba467de33d319738304a46aa4caae084cfe387fdf87ed8242ac9ce
2017-12-21 14:29:57 -08:00
Pieter Wuille
fb46c83881
Merge #463: Reduce usage of hardcoded size constants
c7680e5 Reduce usage of hardcoded size constants (Thomas Snider)

Pull request description:

  In particular the usage of keylen in nonce_function_rfc6979 seemed precarious - in one conditional it was unconditionally set, then in the next it was added to.  While it was clearly correct as written, I think this change makes it easier to reason about for new eyes and more resistant to breakage if there is any future change to what gets fed into the PRNG.

Tree-SHA512: 2241c183acc0f318f85a11ccff7fe28de7777bc53dea93ab8308bad15871047a268c6a2b36f77a599dce536fca48ab305ea746223840bc10953c893daffa0a50
2017-12-21 14:10:50 -08:00
Pieter Wuille
1f46d6089e Disambiguate bench functions and types 2017-12-18 18:22:09 -08:00
Pieter Wuille
f54c6c5083
Merge #480: Enable benchmark building by default
7a78f60 Print whether we're building benchmarks (Pieter Wuille)
4afec9f Build benchmarks by default (Pieter Wuille)

Pull request description:

  Building benchmarks is fast, and I have on more than one occasion forgotten to pass `--enable-benchmark`, resulting in accidentally benchmarking a former build.

  Build them by default.

Tree-SHA512: ce9096e42d9c19b63644f6b7ae153e92f9a37c3727f380329dfa332ce22a5e43151f1525979bd3516dd12f568e5e389b0acda2c383fca0e80c3cadc1d9b1d55a
2017-12-18 14:39:37 -08:00
Jonas Nick
d2f9c6b5dc Use more precise pippenger bucket windows 2017-12-07 20:13:04 +00:00
Peter Dettman
4c950bbeaf Save some additions per window in _pippenger_wnaf 2017-12-07 20:13:04 +00:00
Jonas Nick
a58f543f5a Add flags for choosing algorithm in ecmult_multi benchmark 2017-12-07 20:13:04 +00:00
Jonas Nick
36b22c9337 Use scratch space dependent batching in ecmult_multi 2017-12-07 20:13:04 +00:00