frost/secp256k1-zkp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: remove unnecessary test in run_ec_pubkey_parse_test

Browse Source 
This test tested whether setting the callback works correctly which should be
tested in the context tests.
This commit is contained in:
Jonas Nick 2023-07-28 21:51:37 +00:00
parent 875b0ada25
commit a1d52e3e12
No known key found for this signature in database
GPG Key ID: 4861DBF262123605
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tests.c
View File

@ -5983,7 +5983,6 @@ static void run_ec_pubkey_parse_test(void) {
size_t len; size_t len;
int32_t i; int32_t i;
int32_t ecount; int32_t ecount;
int32_t ecount2;
ecount = 0; ecount = 0;
/* Nothing should be reading this far into pubkeyc. */ /* Nothing should be reading this far into pubkeyc. */
SECP256K1_CHECKMEM_UNDEFINE(&pubkeyc[65], 1); SECP256K1_CHECKMEM_UNDEFINE(&pubkeyc[65], 1);
@ -6104,15 +6103,8 @@ static void run_ec_pubkey_parse_test(void) {
CHECK(len == 65); CHECK(len == 65);
/* Multiple illegal args. Should still set arg error only once. */ /* Multiple illegal args. Should still set arg error only once. */
ecount = 0; ecount = 0;
ecount2 = 11;
CHECK(secp256k1_ec_pubkey_parse(CTX, NULL, NULL, 65) == 0); CHECK(secp256k1_ec_pubkey_parse(CTX, NULL, NULL, 65) == 0);
CHECK(ecount == 1); CHECK(ecount == 1);
/* Does the illegal arg callback actually change the behavior? */
secp256k1_context_set_illegal_callback(CTX, uncounting_illegal_callback_fn, &ecount2);
CHECK(secp256k1_ec_pubkey_parse(CTX, NULL, NULL, 65) == 0);
CHECK(ecount == 1);
CHECK(ecount2 == 10);
secp256k1_context_set_illegal_callback(CTX, NULL, NULL);
/* Try a bunch of prefabbed points with all possible encodings. */ /* Try a bunch of prefabbed points with all possible encodings. */
for (i = 0; i < SECP256K1_EC_PARSE_TEST_NVALID; i++) { for (i = 0; i < SECP256K1_EC_PARSE_TEST_NVALID; i++) {
ec_pubkey_parse_pointtest(valid[i], 1, 1); ec_pubkey_parse_pointtest(valid[i], 1, 1);