From 83d0fa25a826d716f809e00ef0a67385b776aec9 Mon Sep 17 00:00:00 2001 From: Jonas Nick Date: Mon, 8 Sep 2025 19:18:39 +0000 Subject: [PATCH] extrakeys: fix pubkey_sort_cmp test Instead of providing CTX directly, pass a cmp_data object containing CTX. Otherwise, memory sanitizer fails with "use-of-uninitialized-value". --- src/modules/extrakeys/tests_impl.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/extrakeys/tests_impl.h b/src/modules/extrakeys/tests_impl.h index 60299ce0..1f10ceed 100644 --- a/src/modules/extrakeys/tests_impl.h +++ b/src/modules/extrakeys/tests_impl.h @@ -605,7 +605,9 @@ static void test_sort(void) { } secp256k1_pubkey_sort(CTX, pk_ptr, 5); for (j = 1; j < 5; j++) { - CHECK(secp256k1_pubkey_sort_cmp(&pk_ptr[j - 1], &pk_ptr[j], CTX) <= 0); + secp256k1_pubkey_sort_cmp_data cmp_data; + cmp_data.ctx = CTX; + CHECK(secp256k1_pubkey_sort_cmp(&pk_ptr[j - 1], &pk_ptr[j], &cmp_data) <= 0); } } }