frost/secp256k1-zkp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge #773: Fix some compile problems on weird/old compilers.

Browse Source 
1309c03c45beece646a7d21fdb6a0e3d38adee2b Fix some compile problems on weird/old compilers. (Gregory Maxwell)

Pull request description:

  The visibility attribute is a GCC 4+ feature.
  GCC 2.95 also warns about the unsigned/signed comparision.

ACKs for top commit:
  real-or-random:
    ACK 1309c03c45beece646a7d21fdb6a0e3d38adee2b I inspected the diff

Tree-SHA512: b5a5175416b67b2619f68ad82a208052ad678955e59c2f3457799abd1dd6fd817c40f6bc2941b2bda207c6f58ad0fbe46221a2f92b726e824702c4c0b177377c
This commit is contained in:
Tim Ruffing 2020-07-26 11:05:08 +02:00
commit 66bb9320c0
No known key found for this signature in database
GPG Key ID: 8C461CCD293F6011
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/secp256k1.h
View File

@ -134,7 +134,7 @@ typedef int (*secp256k1_nonce_function)(
# else # else
# define SECP256K1_API # define SECP256K1_API
# endif # endif
# elif defined(__GNUC__) && defined(SECP256K1_BUILD) # elif defined(__GNUC__) && (__GNUC__ >= 4) && defined(SECP256K1_BUILD)
# define SECP256K1_API __attribute__ ((visibility ("default"))) # define SECP256K1_API __attribute__ ((visibility ("default")))
# else # else
# define SECP256K1_API # define SECP256K1_API

2
src/secp256k1.c
View File

@ -291,7 +291,7 @@ int secp256k1_ec_pubkey_serialize(const secp256k1_context* ctx, unsigned char *o
VERIFY_CHECK(ctx != NULL); VERIFY_CHECK(ctx != NULL);
ARG_CHECK(outputlen != NULL); ARG_CHECK(outputlen != NULL);
ARG_CHECK(*outputlen >= ((flags & SECP256K1_FLAGS_BIT_COMPRESSION) ? 33 : 65)); ARG_CHECK(*outputlen >= ((flags & SECP256K1_FLAGS_BIT_COMPRESSION) ? 33u : 65u));
len = *outputlen; len = *outputlen;
*outputlen = 0; *outputlen = 0;
ARG_CHECK(output != NULL); ARG_CHECK(output != NULL);