From 6162d577fec175c620f759675eb09ffa10368de1 Mon Sep 17 00:00:00 2001 From: Andrew Poelstra Date: Tue, 12 Jul 2022 18:56:44 +0000 Subject: [PATCH] generator: cleanups in Pedersen/generator code Silence a compiler warning about an unitialized use of a scalar in case the user tries to provide a 0-length list of commitments. Also ensures that commitments have normalized field elements when they are loaded into ges. --- src/modules/generator/main_impl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/generator/main_impl.h b/src/modules/generator/main_impl.h index c9f6ec8b..e60ecdc2 100644 --- a/src/modules/generator/main_impl.h +++ b/src/modules/generator/main_impl.h @@ -391,6 +391,7 @@ int secp256k1_pedersen_blind_generator_blind_sum(const secp256k1_context* ctx, c } secp256k1_scalar_set_int(&sum, 0); + secp256k1_scalar_set_int(&tmp, 0); /* Here, n_total > 0. Thus the loop runs at least once. Thus we may use a do-while loop, which checks the loop