Rename valgrind_ctime_test -> ctime_tests

This commit is contained in:
Pieter Wuille 2022-12-06 18:45:43 -05:00
parent 6eed6c18de
commit 5048be17e9
6 changed files with 10 additions and 10 deletions

View File

@ -40,8 +40,8 @@ cat_logs_snippet: &CAT_LOGS
- cat noverify_tests.log || true - cat noverify_tests.log || true
cat_exhaustive_tests_log_script: cat_exhaustive_tests_log_script:
- cat exhaustive_tests.log || true - cat exhaustive_tests.log || true
cat_valgrind_ctime_test_log_script: cat_ctime_tests_log_script:
- cat valgrind_ctime_test.log || true - cat ctime_tests.log || true
cat_bench_log_script: cat_bench_log_script:
- cat bench.log || true - cat bench.log || true
cat_config_log_script: cat_config_log_script:

2
.gitignore vendored
View File

@ -5,7 +5,7 @@ tests
exhaustive_tests exhaustive_tests
precompute_ecmult_gen precompute_ecmult_gen
precompute_ecmult precompute_ecmult
valgrind_ctime_test ctime_tests
ecdh_example ecdh_example
ecdsa_example ecdsa_example
schnorr_example schnorr_example

View File

@ -120,10 +120,10 @@ noverify_tests_CPPFLAGS = $(SECP_INCLUDES) $(SECP_TEST_INCLUDES) $(SECP_CONFIG_D
noverify_tests_LDADD = $(SECP_LIBS) $(SECP_TEST_LIBS) $(COMMON_LIB) $(PRECOMPUTED_LIB) noverify_tests_LDADD = $(SECP_LIBS) $(SECP_TEST_LIBS) $(COMMON_LIB) $(PRECOMPUTED_LIB)
noverify_tests_LDFLAGS = -static noverify_tests_LDFLAGS = -static
if VALGRIND_ENABLED if VALGRIND_ENABLED
noinst_PROGRAMS += valgrind_ctime_test noinst_PROGRAMS += ctime_tests
valgrind_ctime_test_SOURCES = src/valgrind_ctime_test.c ctime_tests_SOURCES = src/ctime_tests.c
valgrind_ctime_test_LDADD = libsecp256k1.la $(SECP_LIBS) $(COMMON_LIB) ctime_tests_LDADD = libsecp256k1.la $(SECP_LIBS) $(COMMON_LIB)
valgrind_ctime_test_CPPFLAGS = $(SECP_CONFIG_DEFINES) ctime_tests_CPPFLAGS = $(SECP_CONFIG_DEFINES)
endif endif
if !ENABLE_COVERAGE if !ENABLE_COVERAGE
TESTS += tests TESTS += tests

View File

@ -95,7 +95,7 @@ fi
if [ "$CTIMETEST" = "yes" ] if [ "$CTIMETEST" = "yes" ]
then then
./libtool --mode=execute valgrind --error-exitcode=42 ./valgrind_ctime_test > valgrind_ctime_test.log 2>&1 ./libtool --mode=execute valgrind --error-exitcode=42 ./ctime_tests > ctime_tests.log 2>&1
fi fi
# Rebuild precomputed files (if not cross-compiling). # Rebuild precomputed files (if not cross-compiling).

View File

@ -410,7 +410,7 @@ sufficient even. Given that every loop iteration performs *N* divsteps, it will
To deal with the branches in `divsteps_n_matrix` we will replace them with constant-time bitwise To deal with the branches in `divsteps_n_matrix` we will replace them with constant-time bitwise
operations (and hope the C compiler isn't smart enough to turn them back into branches; see operations (and hope the C compiler isn't smart enough to turn them back into branches; see
`valgrind_ctime_test.c` for automated tests that this isn't the case). To do so, observe that a `ctime_tests.c` for automated tests that this isn't the case). To do so, observe that a
divstep can be written instead as (compare to the inner loop of `gcd` in section 1). divstep can be written instead as (compare to the inner loop of `gcd` in section 1).
```python ```python

View File

@ -39,7 +39,7 @@ int main(void) {
if (!SECP256K1_CHECKMEM_RUNNING()) { if (!SECP256K1_CHECKMEM_RUNNING()) {
fprintf(stderr, "Unless compiled under msan, this test can only usefully be run inside valgrind.\n"); fprintf(stderr, "Unless compiled under msan, this test can only usefully be run inside valgrind.\n");
fprintf(stderr, "Usage: libtool --mode=execute valgrind ./valgrind_ctime_test\n"); fprintf(stderr, "Usage: libtool --mode=execute valgrind ./ctime_tests\n");
return 1; return 1;
} }
ctx = secp256k1_context_create(SECP256K1_CONTEXT_DECLASSIFY); ctx = secp256k1_context_create(SECP256K1_CONTEXT_DECLASSIFY);