From 4ab4ec38a04c8cc820294704bb5d8958bc222787 Mon Sep 17 00:00:00 2001 From: Jonas Nick Date: Thu, 11 May 2023 17:22:27 +0000 Subject: [PATCH] musig: add note about missing verification to partial_sign to doc --- include/secp256k1_musig.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/secp256k1_musig.h b/include/secp256k1_musig.h index dadef182..fdf60e51 100644 --- a/include/secp256k1_musig.h +++ b/include/secp256k1_musig.h @@ -442,6 +442,11 @@ SECP256K1_API SECP256K1_WARN_UNUSED_RESULT int secp256k1_musig_nonce_process( * created by calling musig_nonce_gen with that pubkey. Otherwise, the * illegal_callback is called. * + * This function does not verify the output partial signature, deviating from + * the BIP 327 specification. It is recommended to verify the output partial + * signature with `secp256k1_musig_partial_sig_verify` to prevent random or + * adversarially provoked computation errors. + * * Returns: 0 if the arguments are invalid or the provided secnonce has already * been used for signing, 1 otherwise * Args: ctx: pointer to a context object