Merge bitcoindevkit/bdk#1530: chore: fix clippy lints

8bf8c7d080194872188e1ab7a6f14c06b121e371 chore: fix clippy lints (Jose Storopoli)

Pull request description:

  ### Description

  Fix some clippy CI lints

  ### Notes to the reviewers

  More caught by the Nix CI in #1320.

  ### Changelog notice

  chore: clippy lints

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 8bf8c7d080194872188e1ab7a6f14c06b121e371

Tree-SHA512: 6b53cb739e506d79106a2f42aa2b8fa28ef226543fbbf100225f10ed82257f6fd0218f09c0f1291803fbc9c1c88e32ba1c7e02fe3f601ccc9dc5be8a6efea6e1

.github/workflows/cont_integration.yml

@@ -36,6 +36,7 @@ jobs:
           cargo update -p proptest --precise "1.2.0"
           cargo update -p url --precise "2.5.0"
           cargo update -p cc --precise "1.0.105"
+          cargo update -p tokio --precise "1.38.1"
       - name: Build
         run: cargo build ${{ matrix.features }}
       - name: Test

README.md

@@ -74,6 +74,7 @@ cargo update -p home --precise "0.5.5"
 cargo update -p proptest --precise "1.2.0"
 cargo update -p url --precise "2.5.0"
 cargo update -p cc --precise "1.0.105"
+cargo update -p tokio --precise "1.38.1"
 ```
 
 ## License

crates/chain/src/indexer/spk_txout.rs

@@ -84,7 +84,7 @@ impl<I: Clone + Ord + core::fmt::Debug> SpkTxOutIndex<I> {
     /// Typically, this is used in two situations:
     ///
     /// 1. After loading transaction data from the disk, you may scan over all the txouts to restore all
-    /// your txouts.
+    ///    your txouts.
     /// 2. When getting new data from the chain, you usually scan it before incorporating it into your chain state.
     pub fn scan(&mut self, tx: &Transaction) -> BTreeSet<I> {
         let mut scanned_indices = BTreeSet::new();

crates/chain/src/persist.rs

@@ -107,7 +107,7 @@ impl<T> Persisted<T> {
         Ok(T::load(db, params)?.map(|inner| Self { inner }))
     }
 
-    /// Contruct a persisted `T` from an async `Db`.
+    /// Construct a persisted `T` from an async `Db`.
     pub async fn load_async<Db>(
         db: &mut Db,
         params: T::LoadParams,

crates/wallet/src/wallet/changeset.rs

@@ -93,7 +93,6 @@ impl ChangeSet {
         Self::init_wallet_sqlite_tables(db_tx)?;
         use chain::rusqlite::OptionalExtension;
         use chain::Impl;
-        use miniscript::{Descriptor, DescriptorPublicKey};
 
         let mut changeset = Self::default();
 

crates/wallet/src/wallet/params.rs

@@ -150,7 +150,7 @@ impl LoadParams {
     }
 
     /// Checks that `descriptor` of `keychain` matches this, and extracts private keys (if
-    /// avaliable).
+    /// available).
     pub fn descriptors<D>(mut self, descriptor: D, change_descriptor: D) -> Self
     where
         D: IntoWalletDescriptor + 'static,

crates/wallet/src/wallet/persisted.rs

@@ -154,7 +154,7 @@ impl<E: fmt::Debug + fmt::Display> std::error::Error for LoadWithPersistError<E>
 pub enum CreateWithPersistError<E> {
     /// Error from persistence.
     Persist(E),
-    /// Occurs when the loaded changeset cannot contruct [`Wallet`].
+    /// Occurs when the loaded changeset cannot construct [`Wallet`].
     Descriptor(DescriptorError),
 }
 

crates/wallet/src/wallet/tx_builder.rs

@@ -575,7 +575,7 @@ impl<'a, Cs> TxBuilder<'a, Cs> {
     ///
     /// This will be used to:
     /// 1. Set the nLockTime for preventing fee sniping.
-    /// **Note**: This will be ignored if you manually specify a nlocktime using [`TxBuilder::nlocktime`].
+    ///    **Note**: This will be ignored if you manually specify a nlocktime using [`TxBuilder::nlocktime`].
     /// 2. Decide whether coinbase outputs are mature or not. If the coinbase outputs are not
     ///    mature at `current_height`, we ignore them in the coin selection.
     ///    If you want to create a transaction that spends immature coinbase inputs, manually