Alekos Filini
18254110c6
Merge commit 'refs/pull/348/head' of github.com:bitcoindevkit/bdk
2021-06-11 11:41:23 +02:00
Tobin Harding
12de13b95c
Remove redundant borrows
...
Clippy emits:
warning: this expression borrows a reference
As suggested remove the borrows from the front of vars that are already references.
2021-06-10 13:16:07 +10:00
Alekos Filini
224be27aa8
Fix example/doctests format
2021-06-04 15:53:15 +02:00
Riccardo Casatta
bfef2e3cfe
Implements RPC Backend
2021-06-03 10:55:58 +02:00
Paul Miller
0ec064ef13
Use AddressInfo in private methods
2021-05-27 17:11:16 -04:00
Paul Miller
6b60914ca1
return AddressInfo from get_address
2021-05-27 17:11:16 -04:00
Alekos Filini
881ca8d1e3
[signer] Add an option to explicitly allow using non-ALL
sighashes
...
Instead of blindly using the `sighash_type` set in a psbt input, we
now only sign `SIGHASH_ALL` inputs by default, and require the user to
explicitly opt-in to using other sighashes if they desire to do so.
Fixes #350
2021-05-26 10:38:15 +02:00
Alekos Filini
5633475ce8
Merge commit 'refs/pull/347/head' of github.com:bitcoindevkit/bdk
2021-05-26 08:56:38 +02:00
LLFourn
d60c5003bf
Merge testutils crate into the main crate
...
This avoids having to keep the apis in sync between the macros and the
main project.
2021-05-19 16:45:48 +10:00
Steve Myers
9f04a9d82d
Merge commit 'refs/pull/338/head' of github.com:bitcoindevkit/bdk
2021-05-18 16:41:45 -07:00
Tobin Harding
6546b77c08
Remove stale comments
...
The two fields this comment references are not `Option` type. This
comment seems to be stale.
2021-05-11 13:29:22 +10:00
Tobin Harding
de40351710
Use consistent field ordering
...
Clippy emits:
warning: struct constructor field order is inconsistent with struct
definition field order
As suggested, re-order the fields to be consistent with the struct
definition.
2021-05-11 10:51:44 +10:00
Tobin Harding
de811bea30
Use !any() instead of find()...is_none()
...
Clippy emits:
warning: called `is_none()` after searching an `Iterator` with `find`
As suggested, use the construct: `!foo.iter().any(...)`
2021-05-11 10:51:44 +10:00
Tobin Harding
74cc80d127
Remove unnecessary clone
...
Clippy emits:
warning: using `clone` on type `descriptor::policy::Condition` which
implements the `Copy` trait
Remove the clone and rely on `Copy`.
2021-05-11 10:51:44 +10:00
Tobin Harding
009f68a06a
Use assert!(foo) instead of assert_eq!(foo, true)
...
It is redundant to pass true/false to `assert_eq!` since `assert!`
already asserts true/false.
This may, however, be controversial if someone thinks that
```
assert_eq!(foo, false);
```
is more clear than
```
assert!(!foo);
```
Use `assert!` directly instead of `assert_eq!` with true/false argument.
2021-05-11 10:51:44 +10:00
Tobin Harding
12641b9e8f
Use PsbtKey instead of PSBT
...
We recently converted uses of `PSBT` -> `Psbt` inline with idiomatic
Rust acronym identifiers. Do the same to `PSBTKey`.
Use `PsbtKey` instead of `PSBTKey` when aliasing the import of
`psbt::raw::Key` from `bitcoin` library.
2021-05-07 16:29:53 +02:00
Tobin Harding
aa3707b5b4
Use Psbt instead of PSBT
...
Idiomatic Rust uses lowercase for acronyms for all characters after the
first e.g. `std::net::TcpStream`. PSBT (Partially Signed Bitcoin
Transaction) should be rendered `Psbt` in Rust code if we want to write
idiomatic Rust.
Use `Psbt` instead of `PSBT` when aliasing the import of
`PartiallySignedTransaction` from `bitcoin` library.
2021-05-07 16:29:50 +02:00
Riccardo Casatta
f6631e35b8
continue signing when finding already finalized inputs
2021-05-07 13:52:20 +02:00
Riccardo Casatta
898dfe6cf1
get psbt inputs with bounds check
2021-05-06 16:10:11 +02:00
Riccardo Casatta
7961ae7f8e
Check index out of bound also for tx inputs not only for psbt inputs
2021-05-06 15:13:25 +02:00
Alekos Filini
3c7bae9ce9
Rewrite the non_witness_utxo
check
2021-05-06 11:39:01 +02:00
Alekos Filini
17bcd8ed7d
[signer] Replace force_non_witness_utxo
with only_witness_utxo
...
Instead of providing an opt-in option to force the addition of the
`non_witness_utxo`, we will now add them by default and provide the
option to disable them when they aren't considered necessary.
2021-05-06 08:58:39 +02:00
Alekos Filini
b5e9589803
[signer] Adjust signing behavior with SignOptions
2021-05-06 08:58:38 +02:00
Alekos Filini
1d628d84b5
[signer] Fix error variant
2021-05-05 16:59:59 +02:00
LLFourn
5a0c150ff9
Make wallet methods take &mut psbt
...
Rather than consuming it because that is unergonomic.
2021-04-28 15:34:25 +10:00
Riccardo Casatta
8f422a1bf9
Add timelocks to policy satisfaction results
...
Also for signature the logic has been refactored to handle appropriately nested cases.
2021-04-15 15:57:35 +02:00
Alekos Filini
45983d2166
Merge commit 'refs/pull/322/head' of github.com:bitcoindevkit/bdk
2021-04-15 11:40:34 +02:00
Richard Ulrich
98127cc5da
Allow setting RBF when bumping the fee of a transaction. This enables to further bump the fee.
2021-04-13 09:18:46 +02:00
Richard Ulrich
e243107bb6
Adding tests to demonstrate that we can't keep RBF when bumping the fee of a transaction.
2021-04-13 09:18:43 +02:00
Steve Myers
5f873ae500
Use .any() instead of .find().is_some(), clippy warning
...
https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
2021-04-08 14:18:07 -07:00
Steve Myers
2380634496
Use .get(0) instead of .iter().next(), clippy warning
...
https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice
2021-04-08 14:18:07 -07:00
Steve Myers
af98b8da06
Compare float equality using error margin EPSILON, clippy warning
...
https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
2021-04-08 14:17:59 -07:00
Riccardo Casatta
192965413c
Convert upper-case acronyms as suggested by CamelCase convention
...
see https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
2021-04-07 22:14:54 +02:00
Riccardo Casatta
745be7bea8
remove format! from assert! (will be an error in rust edition 2021)
2021-04-07 22:09:08 +02:00
Daniel Karzel
e5ecc7f541
Avoid over-/underflow error in coin_select
...
Adds fix for edge-cases involving small UTXOs (where value < fee) where the coin_select calculation would panic with overflow/underflow errors.
Bitcoin is limited to 21*(10^6), so any Bitcoin amount fits into i64.
2021-04-06 10:21:55 +10:00
Steve Myers
1e6b8e12b2
Merge commit 'refs/pull/310/head' of github.com:bitcoindevkit/bdk
2021-03-31 16:06:53 -07:00
Steve Myers
7041e96737
Fix new test to use new get_address() fn
2021-03-22 10:26:56 -07:00
davemo88
e82dfa971e
brevity
2021-03-16 10:20:07 -04:00
davemo88
3798b4d115
add get_psbt_input
2021-03-15 21:50:51 -04:00
Steve Myers
2d0f6c4ec5
[wallet] Add get_address(AddressIndex::Reset(u32)), update CHANGELOG
2021-03-15 09:13:23 -07:00
Steve Myers
f3b475ff0e
[wallet] Refactor get_*_address() into get_address(AddressIndex), update CHANGELOG
2021-03-15 08:58:11 -07:00
Steve Myers
41ae202d02
[wallet] Add get_unused_address() function, update CHANGELOG
2021-03-15 08:58:09 -07:00
Steve Myers
fef6176275
[wallet] Add fetch_index() helper function
2021-03-15 08:58:07 -07:00
davemo88
dc83db273a
better derivation path building
2021-03-11 21:54:00 -05:00
davemo88
201bd6ee02
better derivation path building
2021-03-11 21:35:16 -05:00
davemo88
396ffb42f9
handle descriptor xkey origin
2021-03-11 17:39:02 -05:00
Steve Myers
12ae1c3479
Update license to Apache 2.0 or MIT, copyright to Bitcoin Dev Kit Developers
2021-03-03 13:23:25 -08:00
Alekos Filini
1cbd47b988
Merge commit 'refs/pull/285/head' of github.com:bitcoindevkit/bdk
2021-02-26 10:14:01 +01:00
LLFourn
ac7c1bd97b
Clean up add_foreign_utxo tests a bit
...
Noticed some suboptimal things while reviewing myself.
2021-02-26 13:33:52 +11:00
Lloyd Fournier
7c1dcd8a72
Apply typo fixes from @tcharding
...
Co-authored-by: Tobin C. Harding <me@tobin.cc>
2021-02-26 13:33:52 +11:00