docs(esplora): fixed full_scan and sync documentation

This commit is contained in:
Wei Chen 2024-05-06 16:51:19 +08:00
parent 2703cc6e78
commit f6dc6890c3
No known key found for this signature in database
2 changed files with 8 additions and 20 deletions

View File

@ -28,8 +28,8 @@ pub trait EsploraAsyncExt {
/// Scan keychain scripts for transactions against Esplora, returning an update that can be /// Scan keychain scripts for transactions against Esplora, returning an update that can be
/// applied to the receiving structures. /// applied to the receiving structures.
/// ///
/// * `local_tip`: the previously seen tip from [`LocalChain::tip`]. /// - `request`: struct with data required to perform a spk-based blockchain client full scan,
/// * `keychain_spks`: keychains that we want to scan transactions for /// see [`FullScanRequest`]
/// ///
/// The full scan for each keychain stops after a gap of `stop_gap` script pubkeys with no /// The full scan for each keychain stops after a gap of `stop_gap` script pubkeys with no
/// associated transactions. `parallel_requests` specifies the max number of HTTP requests to /// associated transactions. `parallel_requests` specifies the max number of HTTP requests to
@ -47,8 +47,6 @@ pub trait EsploraAsyncExt {
/// and [Sparrow](https://www.sparrowwallet.com/docs/faq.html#ive-restored-my-wallet-but-some-of-my-funds-are-missing). /// and [Sparrow](https://www.sparrowwallet.com/docs/faq.html#ive-restored-my-wallet-but-some-of-my-funds-are-missing).
/// ///
/// A `stop_gap` of 0 will be treated as a `stop_gap` of 1. /// A `stop_gap` of 0 will be treated as a `stop_gap` of 1.
///
/// [`LocalChain::tip`]: bdk_chain::local_chain::LocalChain::tip
async fn full_scan<K: Ord + Clone + Send>( async fn full_scan<K: Ord + Clone + Send>(
&self, &self,
request: FullScanRequest<K>, request: FullScanRequest<K>,
@ -59,16 +57,12 @@ pub trait EsploraAsyncExt {
/// Sync a set of scripts with the blockchain (via an Esplora client) for the data /// Sync a set of scripts with the blockchain (via an Esplora client) for the data
/// specified and return a [`TxGraph`]. /// specified and return a [`TxGraph`].
/// ///
/// * `local_tip`: the previously seen tip from [`LocalChain::tip`]. /// - `request`: struct with data required to perform a spk-based blockchain client sync, see
/// * `misc_spks`: scripts that we want to sync transactions for /// [`SyncRequest`]
/// * `txids`: transactions for which we want updated [`ConfirmationTimeHeightAnchor`]s
/// * `outpoints`: transactions associated with these outpoints (residing, spending) that we
/// want to include in the update
/// ///
/// If the scripts to sync are unknown, such as when restoring or importing a keychain that /// If the scripts to sync are unknown, such as when restoring or importing a keychain that
/// may include scripts that have been used, use [`full_scan`] with the keychain. /// may include scripts that have been used, use [`full_scan`] with the keychain.
/// ///
/// [`LocalChain::tip`]: bdk_chain::local_chain::LocalChain::tip
/// [`full_scan`]: EsploraAsyncExt::full_scan /// [`full_scan`]: EsploraAsyncExt::full_scan
async fn sync( async fn sync(
&self, &self,

View File

@ -26,8 +26,8 @@ pub trait EsploraExt {
/// Scan keychain scripts for transactions against Esplora, returning an update that can be /// Scan keychain scripts for transactions against Esplora, returning an update that can be
/// applied to the receiving structures. /// applied to the receiving structures.
/// ///
/// * `local_tip`: the previously seen tip from [`LocalChain::tip`]. /// - `request`: struct with data required to perform a spk-based blockchain client full scan,
/// * `keychain_spks`: keychains that we want to scan transactions for /// see [`FullScanRequest`]
/// ///
/// The full scan for each keychain stops after a gap of `stop_gap` script pubkeys with no /// The full scan for each keychain stops after a gap of `stop_gap` script pubkeys with no
/// associated transactions. `parallel_requests` specifies the max number of HTTP requests to /// associated transactions. `parallel_requests` specifies the max number of HTTP requests to
@ -45,8 +45,6 @@ pub trait EsploraExt {
/// and [Sparrow](https://www.sparrowwallet.com/docs/faq.html#ive-restored-my-wallet-but-some-of-my-funds-are-missing). /// and [Sparrow](https://www.sparrowwallet.com/docs/faq.html#ive-restored-my-wallet-but-some-of-my-funds-are-missing).
/// ///
/// A `stop_gap` of 0 will be treated as a `stop_gap` of 1. /// A `stop_gap` of 0 will be treated as a `stop_gap` of 1.
///
/// [`LocalChain::tip`]: bdk_chain::local_chain::LocalChain::tip
fn full_scan<K: Ord + Clone>( fn full_scan<K: Ord + Clone>(
&self, &self,
request: FullScanRequest<K>, request: FullScanRequest<K>,
@ -57,16 +55,12 @@ pub trait EsploraExt {
/// Sync a set of scripts with the blockchain (via an Esplora client) for the data /// Sync a set of scripts with the blockchain (via an Esplora client) for the data
/// specified and return a [`TxGraph`]. /// specified and return a [`TxGraph`].
/// ///
/// * `local_tip`: the previously seen tip from [`LocalChain::tip`]. /// - `request`: struct with data required to perform a spk-based blockchain client sync, see
/// * `misc_spks`: scripts that we want to sync transactions for /// [`SyncRequest`]
/// * `txids`: transactions for which we want updated [`ConfirmationTimeHeightAnchor`]s
/// * `outpoints`: transactions associated with these outpoints (residing, spending) that we
/// want to include in the update
/// ///
/// If the scripts to sync are unknown, such as when restoring or importing a keychain that /// If the scripts to sync are unknown, such as when restoring or importing a keychain that
/// may include scripts that have been used, use [`full_scan`] with the keychain. /// may include scripts that have been used, use [`full_scan`] with the keychain.
/// ///
/// [`LocalChain::tip`]: bdk_chain::local_chain::LocalChain::tip
/// [`full_scan`]: EsploraExt::full_scan /// [`full_scan`]: EsploraExt::full_scan
fn sync(&self, request: SyncRequest, parallel_requests: usize) -> Result<SyncResult, Error>; fn sync(&self, request: SyncRequest, parallel_requests: usize) -> Result<SyncResult, Error>;
} }