Merge bitcoindevkit/bdk#1247: ci: pin home dependency to 0.5.5 and check_clippy to rust stable version

e7fbc8bcf36de110e88095dba8be0c62e2c8e0ef ci: run clippy_check with rust stable (Steve Myers)
2251b8d41661deb5d8ef7b98abef55efe6437180 ci: pin home version to 0.5.5 for 1.63 MSRV (Steve Myers)

Pull request description:

  ### Description

  Fixed 1.63 MSRV error by pinning `home` dependency to `0.5.5`, and `clippy` error by changing `check_clippy` job to using rust `stable` version.

  ### Notes to the reviewers

  It's OK to use rust `stable` version for clippy because we already have a `clippy.toml` file to tell it which version of the clippy rules to check against.

  ### Changelog notice

  None

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK e7fbc8bcf36de110e88095dba8be0c62e2c8e0ef

Tree-SHA512: 4e9e12488d44a940ea80ecc32ae74dade13d04d5088cb2206271401a2d77b56407af36482df952354b187a52b83631dcdf53bd60d9084a910f4be278059df93b
This commit is contained in:
志宇 2023-12-21 10:41:46 +08:00
commit b5612f269a
No known key found for this signature in database
GPG Key ID: F6345C9837C2BDE8
2 changed files with 6 additions and 8 deletions

View File

@ -33,7 +33,7 @@ jobs:
cargo update -p zip --precise "0.6.2" cargo update -p zip --precise "0.6.2"
cargo update -p time --precise "0.3.20" cargo update -p time --precise "0.3.20"
cargo update -p jobserver --precise "0.1.26" cargo update -p jobserver --precise "0.1.26"
cargo update -p reqwest --precise "0.11.19" cargo update -p home --precise "0.5.5"
- name: Build - name: Build
run: cargo build ${{ matrix.features }} run: cargo build ${{ matrix.features }}
- name: Test - name: Test
@ -118,9 +118,7 @@ jobs:
- uses: actions/checkout@v1 - uses: actions/checkout@v1
- uses: actions-rs/toolchain@v1 - uses: actions-rs/toolchain@v1
with: with:
# we pin clippy instead of using "stable" so that our CI doesn't break toolchain: "stable"
# at each new cargo release
toolchain: "1.67.0"
components: clippy components: clippy
override: true override: true
- name: Rust Cache - name: Rust Cache

View File

@ -65,14 +65,14 @@ This library should compile with any combination of features with Rust 1.63.0.
To build with the MSRV you will need to pin dependencies as follows: To build with the MSRV you will need to pin dependencies as follows:
```shell ```shell
# zip 0.6.3 has MSRV 1.64.0+ # zip 0.6.3 has MSRV 1.64.0
cargo update -p zip --precise "0.6.2" cargo update -p zip --precise "0.6.2"
# time 0.3.21 has MSRV 1.65.0+ # time 0.3.21 has MSRV 1.65.0
cargo update -p time --precise "0.3.20" cargo update -p time --precise "0.3.20"
# jobserver 0.1.27 has MSRV 1.66.0 # jobserver 0.1.27 has MSRV 1.66.0
cargo update -p jobserver --precise "0.1.26" cargo update -p jobserver --precise "0.1.26"
# reqwest 0.11.20 has MSRV > 1.63.0+ # home 0.5.9 has MSRV 1.70.0
cargo update -p reqwest --precise "0.11.19" cargo update -p home --precise "0.5.5"
``` ```
## License ## License