Rename DumbCS to LargestFirstCoinSelection

This commit is contained in:
Murch 2020-10-26 14:16:25 -04:00
parent 8d65581825
commit b2ec6e3683
No known key found for this signature in database
GPG Key ID: 7BA035CA5B901713

View File

@ -115,7 +115,7 @@ use crate::types::{FeeRate, UTXO};
/// Default coin selection algorithm used by [`TxBuilder`](super::tx_builder::TxBuilder) if not /// Default coin selection algorithm used by [`TxBuilder`](super::tx_builder::TxBuilder) if not
/// overridden /// overridden
pub type DefaultCoinSelectionAlgorithm = DumbCoinSelection; pub type DefaultCoinSelectionAlgorithm = LargestFirstCoinSelection;
/// Result of a successful coin selection /// Result of a successful coin selection
#[derive(Debug)] #[derive(Debug)]
@ -163,9 +163,9 @@ pub trait CoinSelectionAlgorithm<D: Database>: std::fmt::Debug {
/// This coin selection algorithm sorts the available UTXOs by value and then picks them starting /// This coin selection algorithm sorts the available UTXOs by value and then picks them starting
/// from the largest ones until the required amount is reached. /// from the largest ones until the required amount is reached.
#[derive(Debug, Default)] #[derive(Debug, Default)]
pub struct DumbCoinSelection; pub struct LargestFirstCoinSelection;
impl<D: Database> CoinSelectionAlgorithm<D> for DumbCoinSelection { impl<D: Database> CoinSelectionAlgorithm<D> for LargestFirstCoinSelection {
fn coin_select( fn coin_select(
&self, &self,
_database: &D, _database: &D,
@ -284,11 +284,11 @@ mod test {
} }
#[test] #[test]
fn test_dumb_coin_selection_success() { fn test_largest_first_coin_selection_success() {
let utxos = get_test_utxos(); let utxos = get_test_utxos();
let database = MemoryDatabase::default(); let database = MemoryDatabase::default();
let result = DumbCoinSelection::default() let result = LargestFirstCoinSelection::default()
.coin_select( .coin_select(
&database, &database,
utxos, utxos,
@ -305,11 +305,11 @@ mod test {
} }
#[test] #[test]
fn test_dumb_coin_selection_use_all() { fn test_largest_first_coin_selection_use_all() {
let utxos = get_test_utxos(); let utxos = get_test_utxos();
let database = MemoryDatabase::default(); let database = MemoryDatabase::default();
let result = DumbCoinSelection::default() let result = LargestFirstCoinSelection::default()
.coin_select( .coin_select(
&database, &database,
utxos, utxos,
@ -326,11 +326,11 @@ mod test {
} }
#[test] #[test]
fn test_dumb_coin_selection_use_only_necessary() { fn test_largest_first_coin_selection_use_only_necessary() {
let utxos = get_test_utxos(); let utxos = get_test_utxos();
let database = MemoryDatabase::default(); let database = MemoryDatabase::default();
let result = DumbCoinSelection::default() let result = LargestFirstCoinSelection::default()
.coin_select( .coin_select(
&database, &database,
vec![], vec![],
@ -348,11 +348,11 @@ mod test {
#[test] #[test]
#[should_panic(expected = "InsufficientFunds")] #[should_panic(expected = "InsufficientFunds")]
fn test_dumb_coin_selection_insufficient_funds() { fn test_largest_first_coin_selection_insufficient_funds() {
let utxos = get_test_utxos(); let utxos = get_test_utxos();
let database = MemoryDatabase::default(); let database = MemoryDatabase::default();
DumbCoinSelection::default() LargestFirstCoinSelection::default()
.coin_select( .coin_select(
&database, &database,
vec![], vec![],
@ -366,11 +366,11 @@ mod test {
#[test] #[test]
#[should_panic(expected = "InsufficientFunds")] #[should_panic(expected = "InsufficientFunds")]
fn test_dumb_coin_selection_insufficient_funds_high_fees() { fn test_largest_first_coin_selection_insufficient_funds_high_fees() {
let utxos = get_test_utxos(); let utxos = get_test_utxos();
let database = MemoryDatabase::default(); let database = MemoryDatabase::default();
DumbCoinSelection::default() LargestFirstCoinSelection::default()
.coin_select( .coin_select(
&database, &database,
vec![], vec![],