frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Verify signatures after signing

Browse Source 
As per [BIP-340, footnote 14][fn]:
> Verifying the signature before leaving the signer prevents random or
> attacker provoked computation errors. This prevents publishing invalid
> signatures which may leak information about the secret key. It is
> recommended, but can be omitted if the computation cost is prohibitive.

[fn]: https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki#cite_note-14
This commit is contained in:
Scott Robinson 2022-08-15 15:07:14 +10:00
parent 9f9ffd0efd
commit 7b1ad1b629
No known key found for this signature in database
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/wallet/signer.rs
View File

@ -475,10 +475,10 @@ fn sign_psbt_ecdsa(
hash_ty: EcdsaSighashType, hash_ty: EcdsaSighashType,
secp: &SecpCtx, secp: &SecpCtx,
) { ) {
let sig = secp.sign_ecdsa( let msg = &Message::from_slice(&hash.into_inner()[..]).unwrap();
&Message::from_slice(&hash.into_inner()[..]).unwrap(), let sig = secp.sign_ecdsa(msg, secret_key);
secret_key, secp.verify_ecdsa(msg, &sig, &pubkey.inner)
); .expect("invalid or corrupted ecdsa signature");
let final_signature = ecdsa::EcdsaSig { sig, hash_ty }; let final_signature = ecdsa::EcdsaSig { sig, hash_ty };
psbt_input.partial_sigs.insert(pubkey, final_signature); psbt_input.partial_sigs.insert(pubkey, final_signature);
@ -504,10 +504,10 @@ fn sign_psbt_schnorr(
Some(_) => keypair, // no tweak for script spend Some(_) => keypair, // no tweak for script spend
}; };
let sig = secp.sign_schnorr( let msg = &Message::from_slice(&hash.into_inner()[..]).unwrap();
&Message::from_slice(&hash.into_inner()[..]).unwrap(), let sig = secp.sign_schnorr(msg, &keypair);
&keypair, secp.verify_schnorr(&sig, msg, &XOnlyPublicKey::from_keypair(&keypair))
); .expect("invalid or corrupted schnorr signature");
let final_signature = schnorr::SchnorrSig { sig, hash_ty }; let final_signature = schnorr::SchnorrSig { sig, hash_ty };