frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge bitcoindevkit/bdk#1530: chore: fix clippy lints
Some checks failed
Code Coverage / Code Coverage (push) Failing after 1m1s
Details
CI / Build and test (--all-features, map[clippy:true version:stable]) (push) Failing after 7m39s
Details
CI / Build and test (--all-features, map[version:1.63.0]) (push) Failing after 18m9s
Details
CI / Build and test (--no-default-features, map[clippy:true version:stable]) (push) Failing after 8m41s
Details
CI / Build and test (--no-default-features, map[version:1.63.0]) (push) Failing after 16m42s
Details
CI / Check no_std (push) Successful in 1m37s
Details
CI / Check WASM (push) Successful in 3m15s
Details
CI / Rust fmt (push) Successful in 21s
Details
CI / clippy_check (push) Failing after 16s
Details
Publish Nightly Docs / Build docs (push) Failing after 7s
Details
Publish Nightly Docs / Publish docs (push) Has been skipped
Details

Browse Source 
8bf8c7d080194872188e1ab7a6f14c06b121e371 chore: fix clippy lints (Jose Storopoli)

Pull request description:

  ### Description

  Fix some clippy CI lints

  ### Notes to the reviewers

  More caught by the Nix CI in #1320.

  ### Changelog notice

  chore: clippy lints

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 8bf8c7d080194872188e1ab7a6f14c06b121e371

Tree-SHA512: 6b53cb739e506d79106a2f42aa2b8fa28ef226543fbbf100225f10ed82257f6fd0218f09c0f1291803fbc9c1c88e32ba1c7e02fe3f601ccc9dc5be8a6efea6e1
This commit is contained in:
Steve Myers 2024-07-31 23:02:59 -05:00
commit 785371e0a1
No known key found for this signature in database
GPG Key ID: 8105A46B22C2D051
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/chain/src/indexer/spk_txout.rs
View File

@ -84,7 +84,7 @@ impl<I: Clone + Ord + core::fmt::Debug> SpkTxOutIndex<I> {
/// Typically, this is used in two situations: /// Typically, this is used in two situations:
/// ///
/// 1. After loading transaction data from the disk, you may scan over all the txouts to restore all /// 1. After loading transaction data from the disk, you may scan over all the txouts to restore all
/// your txouts. /// your txouts.
/// 2. When getting new data from the chain, you usually scan it before incorporating it into your chain state. /// 2. When getting new data from the chain, you usually scan it before incorporating it into your chain state.
pub fn scan(&mut self, tx: &Transaction) -> BTreeSet<I> { pub fn scan(&mut self, tx: &Transaction) -> BTreeSet<I> {
let mut scanned_indices = BTreeSet::new(); let mut scanned_indices = BTreeSet::new();

1
crates/wallet/src/wallet/changeset.rs
View File

@ -93,7 +93,6 @@ impl ChangeSet {
Self::init_wallet_sqlite_tables(db_tx)?; Self::init_wallet_sqlite_tables(db_tx)?;
use chain::rusqlite::OptionalExtension; use chain::rusqlite::OptionalExtension;
use chain::Impl; use chain::Impl;
use miniscript::{Descriptor, DescriptorPublicKey};
let mut changeset = Self::default(); let mut changeset = Self::default();

2
crates/wallet/src/wallet/tx_builder.rs
View File

@ -575,7 +575,7 @@ impl<'a, Cs> TxBuilder<'a, Cs> {
/// ///
/// This will be used to: /// This will be used to:
/// 1. Set the nLockTime for preventing fee sniping. /// 1. Set the nLockTime for preventing fee sniping.
/// **Note**: This will be ignored if you manually specify a nlocktime using [`TxBuilder::nlocktime`]. /// **Note**: This will be ignored if you manually specify a nlocktime using [`TxBuilder::nlocktime`].
/// 2. Decide whether coinbase outputs are mature or not. If the coinbase outputs are not /// 2. Decide whether coinbase outputs are mature or not. If the coinbase outputs are not
/// mature at `current_height`, we ignore them in the coin selection. /// mature at `current_height`, we ignore them in the coin selection.
/// If you want to create a transaction that spends immature coinbase inputs, manually /// If you want to create a transaction that spends immature coinbase inputs, manually