frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(wallet): remove duplicated InsufficientFunds error member from CreateTxError

Browse Source 
review: move back to old error naming
This commit is contained in:
e1a0a0ea 2024-05-13 09:28:43 +02:00 committed by 志宇
parent 8eef350bd0
commit 29c8a00b43
No known key found for this signature in database
GPG Key ID: F6345C9837C2BDE8
2 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
crates/wallet/src/wallet/error.rs
View File

@ -94,13 +94,6 @@ pub enum CreateTxError {
ChangePolicyDescriptor,
/// There was an error with coin selection
CoinSelection(coin_selection::Error),
/// Wallet's UTXO set is not enough to cover recipient's requested plus fee
InsufficientFunds {
/// Sats needed for some transaction
needed: u64,
/// Sats available for spending
available: u64,
},
/// Cannot build a tx without recipients
NoRecipients,
/// Partially signed bitcoin transaction error
@ -184,13 +177,6 @@ impl fmt::Display for CreateTxError {
)
}
CreateTxError::CoinSelection(e) => e.fmt(f),
CreateTxError::InsufficientFunds { needed, available } => {
write!(
f,
"Insufficient funds: {} sat available of {} sat needed",
available, needed
)
}
CreateTxError::NoRecipients => {
write!(f, "Cannot build tx without recipients")
}

6
crates/wallet/src/wallet/mod.rs
View File

@ -73,6 +73,8 @@ use crate::types::*;
use crate::wallet::coin_selection::Excess::{Change, NoChange};
use crate::wallet::error::{BuildFeeBumpError, CreateTxError, MiniscriptPsbtError};
use self::coin_selection::Error;
const COINBASE_MATURITY: u32 = 100;
/// A Bitcoin wallet
@ -1595,10 +1597,10 @@ impl Wallet {
change_fee,
} = excess
{
return Err(CreateTxError::InsufficientFunds {
return Err(CreateTxError::CoinSelection(Error::InsufficientFunds {
needed: *dust_threshold,
available: remaining_amount.saturating_sub(*change_fee),
});
}));
}
} else {
return Err(CreateTxError::NoRecipients);